Bug 422828 - New annotation toolbar button/action mismatch
Summary: New annotation toolbar button/action mismatch
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-11 16:05 UTC by ederag
Modified: 2020-06-12 20:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ederag 2020-06-11 16:05:11 UTC
The new annotation toolbar buttons and their actions do not match, e.g.:
Underline => new text note
Strike through => highlighter
Inline Note => Straight line
Freehand line => Underline

SOFTWARE/OS VERSIONS
openSUSE Leap-15.1, with okular built through kdesrc-build.
KDE Frameworks Version: KDE Frameworks 5.71.0
Qt Version: Qt 5.14.2 (built against 5.14.2)

ADDITIONAL INFORMATION
First occurrence in 0b05d7ce9 ("Overhaul annotations UX", 2020-06-04)
Comment 1 Laura David Hurka 2020-06-11 22:03:02 UTC
Well, at least something works. ;) I am sure your feedback is much welcome.

I think some update script needs to be run, like wiping the existing “quick” annotations. Did you `install` Okular, or did you just copy the executable binaries? 

Same for Bug 422827
Comment 2 ederag 2020-06-11 22:57:29 UTC
It would be normal to have some adjustments after such a huge change,
and my setup may be non-standard.

okular was first built together with dependencies through kdesrc-build,
with the build and the install directories on a dedicated drive.
Then for testing,
cd /usr/local/build/kde/build/okular
cmake -v ~/share/prog/kde/dev/okular
make install
bash
source ./prefix.sh
okular
exit

There are no scripts run in the output of the make install step.
I already wiped aside ~/.config/okularrc and ~/.config/okularpartrc
And my old "quick annotations" are indeed gone.
Note: wiped them out again, and even without touching the toolbar position,
the mismatch still occurs.
Comment 3 Simone Gaiarin 2020-06-12 07:12:17 UTC
From what I have seen this mismatch should be caused by a dirty ~/.config/okularpartrc file (or the one in your prefix). 

The fact is that the standard tools in the toolbar are read from the key AnnotationTools in ~/.config/okularpartrc (which once was the custom user tools).

Theoretically kconf_update script should migrate AnnotationTools to QuickAnnotationTools avoiding this problem, but I am not sure where and when kconf_update is run, maybe kdesrc-build does not run it.

Removing ~/.config/okularpartrc should solve the problem but does not seem so in your case.

Do the wrong activated annotation tools match your old custom annotations order?
Comment 4 ederag 2020-06-12 15:48:26 UTC
(In reply to Simone Gaiarin from comment #3)
> Removing ~/.config/okularpartrc should solve the problem but does not seem
> so in your case.

Indeed, the old ~/.kde4/share/config/okularpartrc was picked up as a replacement.
It had the same [Reviews] field as ~/.config/okularpartrc before 0b05d7ce9.

Fixed by
mv ~/.kde4 ~/.kde4_bck
rm ~/.config/okularrc ~/.config/okularpartrc
One mystery solved, thanks !
Comment 5 Nate Graham 2020-06-12 20:42:54 UTC
Aha, that makes sense. Not sure this particular issue is worth handling in the code as it's caused by a local config issue.