Bug 422827 - Annotation toolbar fails to appear, unless rc-files are wiped out
Summary: Annotation toolbar fails to appear, unless rc-files are wiped out
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Simone Gaiarin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-11 15:59 UTC by ederag
Modified: 2020-07-12 22:47 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/okular/commit/a73012a91c32227ee5e6862052c3eb6c6e91d942
Version Fixed In:

Attachments
original part.rc (4.05 KB, application/vnd.kde.kxmlguirc)
2020-06-12 16:16 UTC, ederag 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ederag 2020-06-11 15:59:33 UTC 
The new annotation toolbar remained invisible (e.g. F6 did nothing).
The toolbar appeared after following the test instructions and restart okular:
rm -i ~/.config/okularpartrc \
      ~/.config/okularrc \
      ~/.local/share/kxmlgui5/okular/part.rc \
      ~/.local/share/kxmlgui5/okular/shell.rc
(note: shell.rc was absent on my system)

SOFTWARE/OS VERSIONS
openSUSE Leap-15.1, with okular built through kdesrc-build.
KDE Frameworks Version: KDE Frameworks 5.71.0
Qt Version: Qt 5.14.2 (built against 5.14.2)

ADDITIONAL INFORMATION
First occurrence in 0b05d7ce9 ("Overhaul annotations UX", 2020-06-04)
Comment 1 Simone Gaiarin 2020-06-12 07:04:57 UTC 
The likely culprit is ~/.local/share/kxmlgui5/okular/part.rc, do you still have the old one to share?
Comment 2 Simone Gaiarin 2020-06-12 07:06:02 UTC 
I am not sure there is a way to migrate part.rc automatically, possibly the only solution is to manually delete that file.
Comment 3 Nate Graham 2020-06-12 15:26:22 UTC 
Hmm, we need a solution without making the user do that manually, then. Nobody will know that they have to do that.
Comment 4 ederag 2020-06-12 16:16:56 UTC 
Created attachment 129268 [details]
original part.rc

Here is the backup file.
If you find a way and look for a tester, I'm ready to help.

Congratulations: it's cool for the annotations toolbar to be moveable.
Comment 5 Albert Astals Cid 2020-06-12 16:27:17 UTC 
(In reply to Simone Gaiarin from comment #2)
> I am not sure there is a way to migrate part.rc automatically, possibly the
> only solution is to manually delete that file.

https://techbase.kde.org/Development/Tools/Using_kconf_update ?
Comment 6 Simone Gaiarin 2020-06-16 19:02:25 UTC 
See https://invent.kde.org/graphics/okular/-/merge_requests/197
Comment 7 Albert Astals Cid 2020-06-16 21:25:39 UTC 
Nate, if you assign something to someone, please make sure you add okular-devel to the CC
Comment 8 Nate Graham 2020-06-16 21:38:04 UTC 
ok
Comment 9 Bug Janitor Service 2020-07-09 21:24:25 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/207
Comment 10 Albert Astals Cid 2020-07-12 22:47:05 UTC 
Git commit a73012a91c32227ee5e6862052c3eb6c6e91d942 by Albert Astals Cid.
Committed on 12/07/2020 at 21:52.
Pushed by aacid into branch 'release/20.08'.

Cleanup part.rc files older than version 47

Otherwise we crash because we introduced a mandatory new toolbar and
kxmlgui doesn't seem to merge them properly

M  +1    -0    CMakeLists.txt
M  +8    -0    part.cpp
A  +103  -0    xmlgui_helper.cpp     [License: GPL (v2+)]
A  +15   -0    xmlgui_helper.h     [License: GPL (v2+)]

https://invent.kde.org/graphics/okular/commit/a73012a91c32227ee5e6862052c3eb6c6e91d942