Bug 419135 - On the fonts settings page, the Apply button is enabled, even if there were no changes
Summary: On the fonts settings page, the Apply button is enabled, even if there were n...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_fonts (show other bugs)
Version: 5.18.5
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 420232 421211 421751 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-23 09:25 UTC by popov895
Modified: 2020-06-14 13:34 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19
Sentry Crash Report:


Attachments
non-default font settings of affected user account (69.65 KB, image/png)
2020-04-01 20:00 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-03-23 09:25:02 UTC
SUMMARY

On the fonts settings page, the "Apply" button is enabled, even if there were no changes. When closing the settings window, you are prompted to apply/discard the changes.

STEPS TO REPRODUCE

1. Open "Settings"
2. Go to "Fonts" > "Fonts" page;
3. The "Apply" button is enabled.

OBSERVED RESULT

The "Apply" button is enabled

EXPECTED RESULT

The "Apply" button is disabled

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE Neon 5.18
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 1 popov895 2020-03-23 10:02:09 UTC
https://streamable.com/28uxe
Comment 2 Patrick Silva 2020-04-01 20:00:10 UTC
Created attachment 127173 [details]
non-default font settings of affected user account

Same problem here after update to Qt 5.14.2.
I have two user accounts on my system, only the one with non-default font settings is affected.
I'm attaching a screenshot showing the font settings of the affected user account.

Operating System: Arch Linux 
KDE Plasma Version: 5.18.4
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.2
Comment 3 Harry 2020-04-09 14:18:30 UTC
Additional observations:

This is occurs after you change any of the default fonts.
Also I see in the system log when you navigate away from this setting page:
Warning org.kde.fontinst Connecting to session bus
                         Failed to register service!

If you hit the defaults button at the bottom of the page, you would think this would go away after it resets the fonts to all the defaults.  It does not, the issue persists.
Comment 4 Nate Graham 2020-04-17 15:20:56 UTC
Seems to be caused by Bug 416140.

*** This bug has been marked as a duplicate of bug 416140 ***
Comment 5 Nate Graham 2020-05-06 17:13:16 UTC
Not actually a duplicate, but also fixed now in Plasma 5.19.
Comment 6 Nate Graham 2020-05-06 17:13:51 UTC
*** Bug 420232 has been marked as a duplicate of this bug. ***
Comment 7 Patrick Silva 2020-05-10 18:50:43 UTC
*** Bug 421211 has been marked as a duplicate of this bug. ***
Comment 8 Patrick Silva 2020-05-19 21:18:13 UTC
*** Bug 421751 has been marked as a duplicate of this bug. ***
Comment 9 popov895 2020-06-12 15:48:28 UTC
Can be reproduced on Plasma 5.18.5 LTS
Comment 10 Nate Graham 2020-06-13 02:01:43 UTC
It's fixed in 5.19
Comment 11 popov895 2020-06-13 07:17:23 UTC
What about Plasma 5.18? Is it out of date? As I know, Plasma 5.18 has an LTS status and it will be supported for two years. This bug was reported for Plasma 5.18, so it should be fixed for Plasma 5.18 as well. The same applies to bug 421344 and bug 416510. Otherwise, I see no reason to report bugs and send patches, that will not get into the Plasma version, that I'm using.
Comment 12 Nate Graham 2020-06-14 03:32:55 UTC
(In reply to popov895 from comment #11)
> What about Plasma 5.18? Is it out of date?
Yes, we just released Plasma 5.19.


> As I know, Plasma 5.18 has an LTS status and it will be supported for two
> years. This bug was reported for Plasma 5.18, so it should be fixed for
> Plasma 5.18 as well. The same applies to bug 421344 and bug 416510.
That's not really how this works, I'm afraid. Not all bugs are possible to fix in the LTS. For example sometimes fixing a bug requires implementing a new feature ore re-architecting the backend, neither of which are appropriates changes for an LTS release.


> Otherwise, I see no reason to report bugs and
> send patches, that will not get into the Plasma version, that I'm using.
You should consider using the latest released version. :) IMO always using the newest one makes more sense than using the LTS version. In fact, yo already implicitly agree by using KDE Neon, which does not stick to the LTS version and already offers 5.19. Consider upgrading to that.
Comment 13 popov895 2020-06-14 09:44:22 UTC
"There is a Plasma 5.18 LTS that will be supported for two years and will have two bugfixes, but don't use it. Use the latest released version." It sounds very strange. I don't like some of the changes made in Plasma 5.19, so I decided to switch to the LTS version. If I send patches for the LTS version, will they be accepted?
Comment 14 Nate Graham 2020-06-14 13:34:32 UTC
But of course! :) Please feel free.

However you can't stay on 5.18 forever. If there's stuff you don't like in 5.19, please feel free to speak up and help fix the issues you've identified there. We're always open to changes.