Bug 418698 - Applying Global theme which use a widget style not installed, default still used but config refer to missing style
Summary: Applying Global theme which use a widget style not installed, default still u...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_lookandfeel (show other bugs)
Version: 5.18.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Cyril Rossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-10 09:28 UTC by Cyril Rossi
Modified: 2020-04-22 14:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cyril Rossi 2020-03-10 09:28:26 UTC
SUMMARY

When applying a global theme from KCM Look and Feel, if the theme use a widget style that is not installed, it will still use Breeze, but in kdeglobals it will refer to the missing widget style, and subsequently fail to highlight the proper widget Style in the KCM Application Style.

STEPS TO REPRODUCE
1. kvantum is not installed,
2. Open Look and Feel KCM, install Qogir-light and apply it.
3. Open Application Style KCM

OBSERVED RESULT

Application Style KCM has not style highlighted.
Widget Style used is Breeze, but kdeglobals indicates widgetStyle=kvantum in group KDE

EXPECTED RESULT

kdeglobals should refer the current style used and Application Style KCM should show (highlight) the current style used.  

SOFTWARE/OS VERSIONS

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Kernel Version: 5.3.0-40-generic
OS Type: 64-bit

ADDITIONAL INFORMATION

https://bugs.kde.org/show_bug.cgi?id=417515
Comment 1 Nate Graham 2020-04-07 19:06:38 UTC
*** Bug 419552 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2020-04-07 19:07:10 UTC
https://phabricator.kde.org/D28662
Comment 3 Cyril Rossi 2020-04-22 14:44:09 UTC
Git commit 17ef374a8cc469a9eefc516fc4885cbbce0c0afc by Cyril Rossi.
Committed on 22/04/2020 at 14:39.
Pushed by crossi into branch 'Plasma/5.18'.

KCM LookAndFeel check widgetStyle availability before applying it

Summary:
Related: bug 419552
* Some Global Theme may refer to breeze widget style with a lower case b, apply the proper name `Breeze`
* Some Global Theme use widget style that may not be installed, then don't apply it.

Test Plan:
* Open KCM LookAndFeel, open GHNS and install Qogir-light theme, then apply it. Open Application Style KCM, if kvantum is not installed, Breeze is highlighted.
* Open KCM LookAndFeel, open GHNS and install Aritim-Light, then apply it. Open Application Style KCM, Breeze is highlighted.

Reviewers: #plasma, ervin, bport, meven, ngraham

Reviewed By: ervin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28662

M  +17   -5    kcms/lookandfeel/kcm.cpp

https://commits.kde.org/plasma-desktop/17ef374a8cc469a9eefc516fc4885cbbce0c0afc