Bug 417515 - In Application Style current style is not highlighted (no global theme)
Summary: In Application Style current style is not highlighted (no global theme)
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_style (show other bugs)
Version: 5.18.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 414855 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-12 19:52 UTC by Piotr Mierzwinski
Modified: 2020-03-06 11:29 UTC (History)
7 users (show)

See Also:
Latest Commit: https://cgit.kde.org/plasma-workspace.git/commit/?id=c7c190488e46f49d85ab8695f32008eb6f352ad8
Version Fixed In: 5.19.0

Attachments
my kdeglobals in Plasma 5.18.0 (5.33 KB, text/plain)
2020-02-17 21:22 UTC, Piotr Mierzwinski 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Mierzwinski 2020-02-12 19:52:18 UTC 
SUMMARY
After update to Plasma 5.18 I noticed that current style (in Application Style) is not highlighted. Whereas "Window Decorations" works well.
Comparing look of buttons and other widgets I think I have applied "Oxygen".
Because of this now I don't know which one I have applied previously. Workaround is checking configuration file.
BTW. I have installed kvantum, but I don't use theme provided by this extension.

STEPS TO REPRODUCE
1. open System Settings
2. click into "Application Style"
3. 

OBSERVED RESULT
No one application style is any how highlighted / marked as currently applied.

EXPECTED RESULT
Currently applied application style should be highlighted / marked, for example in similar to "Window Decorations".

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 5.18
KDE Frameworks Version: 5.67
Qt Version: 5.14.1

ADDITIONAL INFORMATION
Comment 1 Piotr Mierzwinski 2020-02-12 19:56:19 UTC 
I found similar bug (Bug 414855), and seems the issue is related with new Pasma 5.18 (in mentioned one reported for 5.17.80.
Comment 2 Nate Graham 2020-02-12 22:35:10 UTC 
Can reproduce.
Comment 3 Cyril Rossi 2020-02-14 18:07:39 UTC 
Could you post here the value of the widgetStyle entry from your configuration file kdeglobals.
Comment 4 Piotr Mierzwinski 2020-02-17 21:16:14 UTC 
(In reply to Cyril Rossi from comment #3)
> Could you post here the value of the widgetStyle entry from your
> configuration file kdeglobals.

Requested by you entry appears twice - in two sections in file ~/.config/kdeglobals, which looks for me like below:

[General]
BrowserApplication[$e]=opera.desktop
ColorScheme=MateriaManjaroDark
Name=Breeze
XftAntialias=true
XftHintStyle=hintfull
XftSubPixel=
dbfile=/home/piotra/.mozilla/firefox/l3r4fo8u.default/places.sqlite
fixed=Monospace,9,-1,5,50,0,0,0,0,0
font=Noto Sans Adlam,10,-1,5,50,0,0,0,0,0,Regular
menuFont=Noto Sans,10,-1,5,50,0,0,0,0,0,Regular
shadeSortColumn=true
smallestReadableFont=Noto Sans,8,-1,5,50,0,0,0,0,0,Regular
toolBarFont=Noto Sans,10,-1,5,50,0,0,0,0,0,Regular
widgetStyle=Breeze


[KDE]
AnimationDurationFactor=1.000000
ColorScheme=Breeze
ShowDeleteCommand=false
ShowIconsInMenuItems=true
ShowIconsOnPushButtons=true
SingleClick=false
contrast=4
widgetStyle=oxygen
Comment 5 Piotr Mierzwinski 2020-02-17 21:22:32 UTC 
Created attachment 126108 [details]
my kdeglobals in Plasma 5.18.0
Comment 7 Cyril Rossi 2020-02-18 15:39:05 UTC 
(In reply to Piotr Mierzwinski from comment #4)
> Requested by you entry appears twice - in two sections in file
> ~/.config/kdeglobals, which looks for me like below:
> 
> [General]
> widgetStyle=Breeze
> 
> [KDE]
> widgetStyle=oxygen

Thank you for posting your kdeglobals.

After further investigation, the one in General has nothing to do here.

The one in KDE group, is the right one. But KCM Style use widgetStyle value registered in the kstyle/themes/*.themerc files, which is in your case Oxygen with an upper case O, so the KCM can't match the name and highlight the proper Application Style.
Comment 8 Cyril Rossi 2020-02-18 16:32:40 UTC 
btw, re-applying the Application Style should fix the issue.
Comment 9 Piotr Mierzwinski 2020-02-18 19:27:51 UTC 
(In reply to Cyril Rossi from comment #8)
> btw, re-applying the Application Style should fix the issue.

It helped. Thank you.
Comment 10 Patrick Silva 2020-02-19 00:04:41 UTC 
*** Bug 414855 has been marked as a duplicate of this bug. ***
Comment 11 Patrick Silva 2020-02-19 00:13:05 UTC 
Thanks Cyril. Your patch fixes the bug if we set global theme to Breeze.
But if we set a third-party global theme, current application style is still
not highlighted in "Application style" kcm. Now I'm using Qogir-light global theme installed via "Get new global themes..." button and nothing is highlighted
in "Application style" kcm.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.68.0
Qt Version: 5.14.1
Comment 12 Cyril Rossi 2020-02-21 16:26:22 UTC 
(In reply to Patrick Silva from comment #11)
> But if we set a third-party global theme, current application style is still
> not highlighted in "Application style" kcm. Now I'm using Qogir-light global
> theme installed via "Get new global themes..." button and nothing is
> highlighted
> in "Application style" kcm.

I did some tests. I installed from KCM look and feel Qogir global theme and applyed it.
Qogir requires kvantum that I didn't have, so the Application Style was not selected, but the style used was still Breeze.
In my kdeglobals, I had :

[KDE]
widgetStyle=kvantum

Then I installed some qt5-style-kvantum package, and then I get the Application Style properly selected.
Comment 13 Patrick Silva 2020-02-21 17:57:57 UTC 
(In reply to Cyril Rossi from comment #12)
> Then I installed some qt5-style-kvantum package, and then I get the
> Application Style properly selected.

yes, I can confirm on Neon unstable. :)
However other themes with Breeze widget style make style highlighting in "Application Style" kcm to fail
on the same system. For example, install Aritim-light global theme via "Get new global themes" button and apply it. kdeglobals file says that widgetstyle is "breeze" under its "[KDE]" section and Breeze style is not highlighted in "Application style" kcm.
Comment 14 Cyril Rossi 2020-02-25 09:48:54 UTC 
To sum up, I see 2 things :

1) When applying a global theme from KCM Look and Feel, if the theme use a widget theme that is not installed, it will style use Breeze but the kdeglobals, but the kdeglobals will be wrong and fail to highlight the proper Application Style in the KCM.

2) Some global themes refer to "breeze" as widgetStyle instead of "Breeze", which cause the highlight to fail as well.
Comment 15 Christoph Feck 2020-03-06 11:29:17 UTC 
If the recent comments describe more issues that still need to be fixed, I suggest to report them separately.