Bug 418322 - dolphin: sometimes(?) launches window on session restore when 'dolphin --daemon' runs in background
Summary: dolphin: sometimes(?) launches window on session restore when 'dolphin --daem...
Status: RESOLVED UPSTREAM
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 19.12.1
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL: https://bugzilla.redhat.com/show_bug....
Keywords:
: 419559 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-29 12:42 UTC by Patrick O'Callaghan
Modified: 2020-09-30 17:01 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick O'Callaghan 2020-02-29 12:42:59 UTC
SUMMARY
Dolphin binary is installed in two locations, possibly leading to spurious autostart behaviour

STEPS TO REPRODUCE
1. Install Dolphin
2. Restart login session
3. Dolphin starts a new window separate from any that were included in the autostart list

OBSERVED RESULT
See only saved windows

EXPECTED RESULT
See saved windows plus one extra

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.17.5
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
The RPM package for Fedora 31 installs two independent
copies of the Dolphin binary (i.e. two files, not a link from one to the other), one in /bin/dolphin and one in /usr/bin/dolphin. The ~/.config/ksmserverrc shows references to both of them, leading to the suspicion that this is where the extra window is coming from.
Comment 1 Nate Graham 2020-02-29 13:32:36 UTC
Sounds like a packaging issue. Please contact the Fedora packagers. Thanks!
Comment 2 Patrick O'Callaghan 2020-02-29 13:41:43 UTC
(In reply to Nate Graham from comment #1)
> Sounds like a packaging issue. Please contact the Fedora packagers. Thanks!

That was my thought as well. However, the Fedora Bugzilla doesn't have a specific item for Dolphin, so it will have to be against KDE or Plasma. I'd welcome advice on this.
Comment 3 Nate Graham 2020-02-29 14:06:36 UTC
Just KDE in general
Comment 4 Patrick O'Callaghan 2020-02-29 16:45:37 UTC
(In reply to Nate Graham from comment #3)
> Just KDE in general

Filed at https://bugzilla.redhat.com/show_bug.cgi?id=1808716 (against kde-filesystem for lack of an obvious alternative)
Comment 5 Patrick O'Callaghan 2020-03-02 11:16:41 UTC
(In reply to Patrick O'Callaghan from comment #4)
> (In reply to Nate Graham from comment #3)
> > Just KDE in general
> 
> Filed at https://bugzilla.redhat.com/show_bug.cgi?id=1808716 (against
> kde-filesystem for lack of an obvious alternative)

Reopening.

Further discussion (see the Redhat BZ report) indicates that this is not a packaging issue, but seems to be caused by the session-save code thinking that the Dolphin daemon is a window to be saved in ksmserverrc.

This should probably be reassigned to some Plasma component.
Comment 6 Rex Dieter 2020-03-03 14:38:14 UTC
Adjusting summary to match observations
Comment 7 Rex Dieter 2020-03-03 15:23:24 UTC
Some background why fedora autostarts 'dolphin --daemon' is documented in
https://bugzilla.redhat.com/show_bug.cgi?id=1394927
https://bugs.freedesktop.org/show_bug.cgi?id=20099

In short, dbus activation for org.freedesktop.FileManager1 was... unreliable and sometime problematic if a system had multiple providers.  So, we remove the dbus activation, and instead autostart 'dolphin --daemon' in plasma environments.

Probably should have made an effort to move that upstream to kde, apologies.
Comment 8 Nate Graham 2020-03-04 23:50:26 UTC
I'm afraid your explanation doesn't convince me that this issue is anything other than a Fedora packaging bug. :) Autostarting `dolphin --daemon` isn't the intended upstream behavior and it's not surprising to me that the behavior is a bit buggy.

Please do feel free to submit your improvement upstream. If it helps you to get rid of a local patch, that's good.
Comment 9 Rex Dieter 2020-04-04 21:40:00 UTC
I will do so, thanks.  Then we can re-open this. :)
Comment 10 Rex Dieter 2020-04-04 21:41:05 UTC
*** Bug 419559 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2020-09-30 17:01:17 UTC
*** Bug 417219 has been marked as a duplicate of this bug. ***