SUMMARY Users have issues with HDR mode affecting their PNG image sequences and videos. STEPS TO REPRODUCE 1. Create an animation in sRGB. Use bright colors. 2. Go to File -> Render Animation. 3. Open tab "Both". Go to image sequence options. 4. Make sure it uses HDR mode. 5. Return to "Video" tab. Note: no way to change PNG settings there. 6. Render the video. OBSERVED RESULT Video's colors are washed out. EXPECTED RESULT Video's colors are just the same as they were before. Or at least, I have access to settings that influence those colors. ADDITIONAL INFORMATION Related to bug 416772 Examples: - bug 417470 - https://www.reddit.com/r/krita/comments/f2awke/everytime_when_i_try_to_export_an_animation_into/ - https://www.reddit.com/r/krita/comments/epbwuy/grey_washed_out_colors_when_exporting_animation/ - (most probably the same issue) https://www.reddit.com/r/krita/comments/emku5w/greyed_out_rendered_videos_and_animation/ SOFTWARE/OS VERSIONS Linux Mint, 4.2.8 (system probably irrelevant; I guess most reports are from Windows anyway). Qt Version (compiled): 5.11.1 Version (loaded): 5.11.1 OS Information Build ABI: x86_64-little_endian-lp64 Build CPU: x86_64 CPU: x86_64 Kernel Type: linux Kernel Version: 5.3.7-050307-generic Pretty Productname: Linux Mint 19.2 Product Type: linuxmint Product Version: 19.2
Note: if we ever have the situation where for an 8 or 16 bit integer image any of the HDR specific code paths are used, then that's a big bug that needs to be fixed.
16-bit integer mode supports HDR perfectly fine. It is in PNG file format :)
Okay, I see several (possible) problems: 1) We share "last used" PNG settings with the ones the user used for saving normal images. The code is in DlgAnimationRenderer::sequenceMimeTypeOptionsClicked(). I don't know how good or bad it is from UIX point of view. Theoretically, it should be okay, but I'm not sure. 2) The main problem is that to enable HDR we should tick two checkboxes in different dialogs: in PNG export settings and in video settings. Ideally, there should be only one checkbox for it, but it clashes with point 1) :)
Git commit 06b236db5be6c27adda9f48855d4de0cc325e60a by Dmitry Kazakov, on behalf of Eoin O'Neill. Committed on 07/04/2020 at 15:21. Pushed by dkazakov into branch 'master'. Video tab and Image Sequence tab HDR synchronization fix. Previously, these two windows could have their own HDR states. That has been corrected by giving the animation export window it's own hdr state (overriding the ForceHDR variable, since it's no longer necessary) which can be used to determine whether or not the image sequence / video should be configured to support HDR. M +19 -5 plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp M +2 -1 plugins/extensions/animationrenderer/DlgAnimationRenderer.h M +10 -2 plugins/extensions/animationrenderer/video_export_options_dialog.cpp M +2 -1 plugins/extensions/animationrenderer/video_export_options_dialog.h https://invent.kde.org/kde/krita/commit/06b236db5be6c27adda9f48855d4de0cc325e60a
Git commit 7f8b4f066808dfce487ec4d2fa87e453bd34e079 by Dmitry Kazakov, on behalf of Eoin O'Neill. Committed on 08/04/2020 at 18:33. Pushed by dkazakov into branch 'krita/4.3'. Video tab and Image Sequence tab HDR synchronization fix. Previously, these two windows could have their own HDR states. That has been corrected by giving the animation export window it's own hdr state (overriding the ForceHDR variable, since it's no longer necessary) which can be used to determine whether or not the image sequence / video should be configured to support HDR. M +19 -5 plugins/extensions/animationrenderer/DlgAnimationRenderer.cpp M +2 -1 plugins/extensions/animationrenderer/DlgAnimationRenderer.h M +10 -2 plugins/extensions/animationrenderer/video_export_options_dialog.cpp M +2 -1 plugins/extensions/animationrenderer/video_export_options_dialog.h https://invent.kde.org/kde/krita/commit/7f8b4f066808dfce487ec4d2fa87e453bd34e079