Bug 417106 - Incorrect label color in Microphone section and Applications section
Summary: Incorrect label color in Microphone section and Applications section
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: applet (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-03 14:15 UTC by Christoph Feck
Modified: 2020-02-04 20:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
plasma-pa applet screenshot (39.29 KB, image/png)
2020-02-03 14:15 UTC, Christoph Feck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2020-02-03 14:15:14 UTC
Created attachment 125643 [details]
plasma-pa applet screenshot

SUMMARY
The plasma-pulseaudio system tray applet uses a wrong label color, making it hard to read.

STEPS TO REPRODUCE
1. Use light application theme and dark Plasma theme
2. open plasma-pa applet

OBSERVED RESULT
The "Internal Microphone" label, and the application labels in the "Applications" tab use a dark instead of a light text color.

EXPECTED RESULT
All text colors are consistent.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20200128 with Krypton K:U:* repositories
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1

Using "normal" severity because it affects accessibility.
Comment 1 Nate Graham 2020-02-04 20:28:17 UTC
Git commit bd7c146a95a9b736c347382c59e4232e5d9bc01f by Nate Graham, on behalf of George Vogiatzis.
Committed on 04/02/2020 at 20:28.
Pushed by ngraham into branch 'master'.

[Applet]Fix device label problems

Summary:
Limit label maximum width, to avoid breaking UI.
Change label to use plasma components 3, for theme color compatibility.
Use of implicit sizes, to avoid binding loops.
Related: bug 417074

Test Plan:
Use applet outside of systemtray and limit it's width.
If device description is not long enough, enable in the configuration
"Add virtual output device for simultaneous output on all local sound cars".
Before: Hamburger menu moves to the right, and there is no eliding.
After: Proper display.
{F8080583}

Reviewers: #plasma, #vdg, drosca, ngraham, davidedmundson

Reviewed By: #vdg, ngraham

Subscribers: cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27117

M  +9    -3    applet/contents/ui/ListItemBase.qml

https://commits.kde.org/plasma-pa/bd7c146a95a9b736c347382c59e4232e5d9bc01f