Bug 417074 - Broken applet UI with long device names
Summary: Broken applet UI with long device names
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: applet (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-02 20:41 UTC by Christophe Marin
Modified: 2020-02-04 20:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
plasma-pa with long device name (14.33 KB, image/png)
2020-02-02 20:41 UTC, Christophe Marin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2020-02-02 20:41:22 UTC
Created attachment 125628 [details]
plasma-pa with long device name

Using master. Check the screenshot.

The UI is broken when a device name doesn't fit the tray window width.
Comment 1 Nate Graham 2020-02-03 14:57:05 UTC
George beat me to a patch: https://phabricator.kde.org/D27117
Comment 2 Nate Graham 2020-02-04 20:28:17 UTC
Git commit bd7c146a95a9b736c347382c59e4232e5d9bc01f by Nate Graham, on behalf of George Vogiatzis.
Committed on 04/02/2020 at 20:28.
Pushed by ngraham into branch 'master'.

[Applet]Fix device label problems

Summary:
Limit label maximum width, to avoid breaking UI.
Change label to use plasma components 3, for theme color compatibility.
Use of implicit sizes, to avoid binding loops.
Related: bug 417106

Test Plan:
Use applet outside of systemtray and limit it's width.
If device description is not long enough, enable in the configuration
"Add virtual output device for simultaneous output on all local sound cars".
Before: Hamburger menu moves to the right, and there is no eliding.
After: Proper display.
{F8080583}

Reviewers: #plasma, #vdg, drosca, ngraham, davidedmundson

Reviewed By: #vdg, ngraham

Subscribers: cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27117

M  +9    -3    applet/contents/ui/ListItemBase.qml

https://commits.kde.org/plasma-pa/bd7c146a95a9b736c347382c59e4232e5d9bc01f