Bug 416311 - CompactRepresentation's MouseArea intercepts hover event, preventing icon from having a highlight effect
Summary: CompactRepresentation's MouseArea intercepts hover event, preventing icon fro...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: junior-jobs
Depends on:
Blocks: 400295
  Show dependency treegraph
 
Reported: 2020-01-15 20:24 UTC by Nate Graham
Modified: 2023-08-24 18:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-01-15 20:24:29 UTC
That way it will get a highlight effect when the cursor passes over it in the system tray. See Bug 400295 for more details.
Comment 1 David Edmundson 2020-01-15 20:33:27 UTC
It's not quite as described. 

There is an IconItem, but the parent MouseArea is intercepting the hover event and not propogating downwards.
Comment 2 Kai Uwe Broulik 2020-01-16 09:25:58 UTC
It also uses SVGItem for some graphics which can't glow
Comment 3 Konrad Materka 2020-01-16 21:32:50 UTC
I proposed an idea on how to glow SvgItem in Bug 416310.
Comment 4 Nate Graham 2023-08-24 18:16:19 UTC
Git commit 39f05d2d5b74057ed6d9a0a8a1022865ff5046e8 by Nate Graham.
Committed on 24/08/2023 at 20:13.
Pushed by ngraham into branch 'master'.

applets/{batterymonitor,notifications}: Show CompactRep hover highlights

Battery Monitor and Notifications have custom CompactRepresentations,
but were not conditionally setting the active: property on hover for
their custom icon items, causing them to lack the hover highlight
effect that all other System Tray icons have.
Related: bug 416310
FIXED-IN: 6.0

M  +3    -1    applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
M  +4    -0    applets/notifications/package/contents/ui/CompactRepresentation.qml
M  +5    -0    components/workspace/BatteryIcon.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/39f05d2d5b74057ed6d9a0a8a1022865ff5046e8