Bug 400295 - Metabug: Some tray icons aren't highlighted upon hovering over them with mouse cursor
Summary: Metabug: Some tray icons aren't highlighted upon hovering over them with mous...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: master
Platform: Other Linux
: NOR task
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on: 416310 416311
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-25 14:56 UTC by Alexander Mentyu
Modified: 2023-08-24 18:17 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2018-10-25 14:56:26 UTC
SUMMARY
For example Digital Clock, Battery, Networks tray icons aren't highlighted but Sound, Vaults, Clipboard are

SOFTWARE VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
Qt Version: 5.11.2
KDE Frameworks Version: 5.52.0
Comment 1 Nate Graham 2018-10-26 03:36:36 UTC
"Updates" also has a hover effect. Same with 3rd-party icons provided by Dropbox, Telegram, and Riot.
Comment 2 Konrad Materka 2019-10-17 14:11:04 UTC
Working:
* Bluetooth
* Clipboard
* Disk quota
* Display Configuration
* KDE Connect
* Networks
* Printers
* Touchpad
* Weather
* Vaults
* Volume
and all SNI icons (like Skype, Dropbox etc) + Updates 

No hover effect:
* Device Notifier - can be fixed, I will create patch
* Battery Monitor - it's not using PlasmaCore.IconItem, no easy way to fix
* Notification - it's not using PlasmaCore.IconItem, no easy way to fix
* Keyboard Indicator - can be fixed, I will create patch

Digital clock is not part of the System Tray.
Comment 3 Konrad Materka 2019-10-17 15:28:53 UTC
Git commit 532d4da7bfb51ef526349afbe6b08a1c1bdbce34 by Konrad Materka.
Committed on 17/10/2019 at 15:28.
Pushed by kmaterka into branch 'master'.

Highlight the icon in the system tray on mouse over

Summary:
Icon should be highlighted hover, as any other icons in the system tray.

Test Plan: Hover mouse over over the icon - it should highlight.

Reviewers: #plasma, davidedmundson, #plasma_workspaces, broulik

Reviewed By: #plasma, #plasma_workspaces, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24738

M  +3    -0    applets/devicenotifier/package/contents/ui/devicenotifier.qml

https://commits.kde.org/plasma-workspace/532d4da7bfb51ef526349afbe6b08a1c1bdbce34
Comment 4 Konrad Materka 2019-10-17 18:22:34 UTC
Git commit 7ad4b59b70478e2fb5e309a31504ffec744c5169 by Konrad Materka.
Committed on 17/10/2019 at 18:22.
Pushed by kmaterka into branch 'master'.

Correctly highlight the icon in the system tray

Summary:
Icon is highlighted when CapsLock or NumLock are locked. It should not
be used this way, icon should be highlithed on mouse hover, as any other
icon in system tray.

Test Plan: Hover mouse over the icon - highlight only when mouse is over the icon. It should not highlight when CapsLock or NumLock are used.

Reviewers: #plasma, davidedmundson, apol, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24737

M  +1    -1    applets/keyboardindicator/contents/ui/main.qml

https://commits.kde.org/kdeplasma-addons/7ad4b59b70478e2fb5e309a31504ffec744c5169
Comment 5 Konrad Materka 2019-10-18 08:58:41 UTC
Two left:
* Battery Monitor
* Notification
It is not trivial to fix. All other plasmoids are using PlasmaCore.IconItem which has this effect build in (it is enough to set "active" to true). Battery Monitor and Notification are rendering their own icons, using PlasmaCore.SvgItem, PlasmaCore.Svg and other. AFAIK there is no easy way to set this mouse over effect easily.
Comment 6 Nate Graham 2020-01-15 20:25:11 UTC
This needs bugs filed against those two remaining items; there's nothing we can do here.

Here, have some bugs:

- Notifications: Bug 416311
- Battery: 416310
Comment 7 guimarcalsilva 2021-06-24 03:10:42 UTC
(In reply to Konrad Materka from comment #2)
> Working:
> * Bluetooth
> * Clipboard
> * Disk quota
> * Display Configuration
> * KDE Connect
> * Networks
> * Printers
> * Touchpad
> * Weather
> * Vaults
> * Volume
> and all SNI icons (like Skype, Dropbox etc) + Updates 
> 
> No hover effect:
> * Device Notifier - can be fixed, I will create patch
> * Battery Monitor - it's not using PlasmaCore.IconItem, no easy way to fix
> * Notification - it's not using PlasmaCore.IconItem, no easy way to fix
> * Keyboard Indicator - can be fixed, I will create patch
> 
> Digital clock is not part of the System Tray.


KDE Connect icon is not getting the hover effect, at least not in the latest version.
Comment 8 Nate Graham 2023-08-24 18:17:44 UTC
All subtasks are now completed for Plasma 6. Closing.