Bug 416045 - Trashcan widget icon should always be monochrome
Summary: Trashcan widget icon should always be monochrome
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Trash (show other bugs)
Version: 5.22.4
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: junior-jobs
: 456272 (view as bug list)
Depends on:
Blocks: 473215
  Show dependency tree / graph
 
Reported: 2020-01-09 13:22 UTC by Patrick Silva
Modified: 2023-08-09 15:42 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/4d4aa8fb88b1d6035d3200787ca068a2303bcb96
Version Fixed In: 6.0

Attachments
panel height 38px (12.14 KB, image/png)
2020-01-09 13:22 UTC, Patrick Silva 		Details
panel height 34px (9.78 KB, image/png)
2020-01-09 13:23 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-01-09 13:22:58 UTC 
Created attachment 124995 [details]
panel height 38px

STEPS TO REPRODUCE
1. add Trashcan widget to plasma panel
2. set panel height to 34px or less

OBSERVED RESULT
icon of Trashcan widget changes. Compare the attached screenshots.

EXPECTED RESULT
icon of Trashcan widget is always the same

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.65.0
Qt Version: 5.14.0

ADDITIONAL INFORMATION
related to bug 381960
Comment 1 Patrick Silva 2020-01-09 13:23:36 UTC 
Created attachment 124996 [details]
panel height 34px
Comment 2 Nate Graham 2020-01-12 17:17:15 UTC 
We recently fixed the Show Desktop widget to always be monochrome. I guess we need to do the same thing for the Trash widget. This will entail adding monochrome versions of this icon to the Plasma theme (not the icon theme), as we did for the Show Desktop widget in https://cgit.kde.org/plasma-framework.git/commit/?id=e44cab6ab55bb7ca83281530515645ef46eef6a7
Comment 3 Felipe Kinoshita 2022-07-03 23:32:58 UTC 
*** Bug 456272 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2023-08-09 15:07:08 UTC 
We can do this now by using the user-trash-symbolic and user-trash-full-symbolic icons.
Comment 5 Nate Graham 2023-08-09 15:42:22 UTC 
Git commit 4d4aa8fb88b1d6035d3200787ca068a2303bcb96 by Nate Graham.
Committed on 09/08/2023 at 17:40.
Pushed by ngraham into branch 'master'.

applet/trash: ask for -symbolic versions of CompactRep icons

We want to use these versions if they exist, so the Panel icons will
always be monochrome when using a mixed mono/colorful icon theme.
FIXED-IN: 6.0

M  +1    -1    applets/trash/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/4d4aa8fb88b1d6035d3200787ca068a2303bcb96