Bug 415267 - Completely disfunctional dialog in 19.12
Summary: Completely disfunctional dialog in 19.12
Status: RESOLVED FIXED
Alias: None
Product: KAccounts
Classification: Frameworks and Libraries
Component: KCM (show other bugs)
Version: 19.12
Platform: Other Linux
: VHI critical
Target Milestone: ---
Assignee: Nicolas Fella
URL:
Keywords: usability
: 415586 416519 417313 420569 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-16 22:01 UTC by Antonio Rojas
Modified: 2020-04-25 13:42 UTC (History)
11 users (show)

See Also:
Latest Commit: https://commits.kde.org/kaccounts-integration/67fc8d83b71f2b1304615ea087023ef66a9c9d5d
Version Fixed In:
Sentry Crash Report:

Attachments
old KCM module displaying all accounts (111.46 KB, image/png)
2019-12-16 22:02 UTC, Antonio Rojas 		Details
19.12 KCM module (70.45 KB, image/png)
2019-12-16 22:03 UTC, Antonio Rojas 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2019-12-16 22:01:45 UTC 
SUMMARY
The kaccounts kcm is completely unusable in 19.12:
- It only shows one of the 5 configured accounts
- It is not possible to interact in any way, configure or delete the displayed account.

See attached screenshots
Comment 1 Antonio Rojas 2019-12-16 22:02:50 UTC 
Created attachment 124534 [details]
old KCM module displaying all accounts
Comment 2 Antonio Rojas 2019-12-16 22:03:22 UTC 
Created attachment 124535 [details]
19.12 KCM module
Comment 3 Antonio Rojas 2019-12-26 18:36:32 UTC 
*** Bug 415586 has been marked as a duplicate of this bug. ***
Comment 4 Antonio Rojas 2020-01-05 07:20:01 UTC 
Can this please be reverted to the 18.12 dialog until it is fixed? As it is now the dialog is totally unusable.
Comment 5 Andi Sardina 2020-01-05 09:56:13 UTC 
Sorry for the duplication! 

Another problematic thing is that Google doesn't allow logging now, it complains that KDE is a nonverified app. Does anybody know the reason?
Comment 6 Antonio Rojas 2020-01-05 10:05:34 UTC 
(In reply to Andi Sardina from comment #5)
> Sorry for the duplication! 
> 
> Another problematic thing is that Google doesn't allow logging now, it
> complains that KDE is a nonverified app. Does anybody know the reason?

That is a different issue: https://bugs.kde.org/show_bug.cgi?id=414219
Comment 7 Antonio Rojas 2020-01-05 10:06:10 UTC 
(In reply to Antonio Rojas from comment #4)
> Can this please be reverted to the 18.12 dialog until it is fixed? As it is
> now the dialog is totally unusable.

I meant 19.08 of course
Comment 8 Wolfgang Bauer 2020-01-22 10:24:55 UTC 
*** Bug 416519 has been marked as a duplicate of this bug. ***
Comment 9 Antonio Rojas 2020-02-08 18:29:06 UTC 
*** Bug 417313 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2020-02-15 20:11:51 UTC 
We really need to get these bugs fixed.
Comment 11 Dan Leinir Turthra Jensen 2020-02-17 12:13:31 UTC 
Just posted a review for a patch to fix the main issue in this report: https://phabricator.kde.org/D27454 (there is more which wants doing, but this makes the kcm actually function)
Comment 12 Dan Leinir Turthra Jensen 2020-02-17 13:42:59 UTC 
Git commit 2420b04e3d01cd02c26e238221a7603614830d15 by Dan Leinir Turthra Jensen.
Committed on 17/02/2020 at 13:42.
Pushed by leinir into branch 'master'.

Unbreak the Accounts KCM

Summary:
Prior to this, the Accounts KCM would show only the first account,
because the listview was a zero by zero size (which results in
the first item still being shown because labels will overpaint
unless told otherwise). The reson it looked like there was a
view there before was that the view was set to the ScrollViewKCM's
default scroll view. In other words: All the accounts were in fact
there, but they were not displayed because the listview was
not there.

Reviewers: #plasma, nicolasfella, bshah

Reviewed By: #plasma, bshah

Subscribers: arojas

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27454

M  +2    -2    src/kcm/package/contents/ui/Accounts.qml
M  +1    -3    src/kcm/package/contents/ui/AvailableAccounts.qml
M  +1    -2    src/kcm/package/contents/ui/AvailableServices.qml

https://commits.kde.org/kaccounts-integration/2420b04e3d01cd02c26e238221a7603614830d15
Comment 13 Wolfgang Bauer 2020-02-17 14:02:30 UTC 
Shouldn't the fix also be submitted to the 19.12 branch?
Comment 14 Wolfgang Bauer 2020-03-02 20:59:35 UTC 
Git commit 67fc8d83b71f2b1304615ea087023ef66a9c9d5d by Wolfgang Bauer, on behalf of Dan Leinir Turthra Jensen.
Committed on 02/03/2020 at 20:58.
Pushed by wbauer into branch 'release/19.12'.

Unbreak the Accounts KCM

Summary:
Prior to this, the Accounts KCM would show only the first account,
because the listview was a zero by zero size (which results in
the first item still being shown because labels will overpaint
unless told otherwise). The reson it looked like there was a
view there before was that the view was set to the ScrollViewKCM's
default scroll view. In other words: All the accounts were in fact
there, but they were not displayed because the listview was
not there.

Reviewers: #plasma, nicolasfella, bshah

Reviewed By: #plasma, bshah

Subscribers: arojas

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27454

(cherry picked from commit 2420b04e3d01cd02c26e238221a7603614830d15)

M  +2    -2    src/kcm/package/contents/ui/Accounts.qml
M  +1    -3    src/kcm/package/contents/ui/AvailableAccounts.qml
M  +1    -2    src/kcm/package/contents/ui/AvailableServices.qml

https://commits.kde.org/kaccounts-integration/67fc8d83b71f2b1304615ea087023ef66a9c9d5d
Comment 15 Antonio Rojas 2020-04-25 13:42:49 UTC 
*** Bug 420569 has been marked as a duplicate of this bug. ***