Ok, this is a suggestion based on bug #399338 that I reported myself a while ago. When you enable the item count for the tree view, the total number of items next to each Tag is not very intuitive. Apparently, it not only counts the number of elements with that tag, but also the number of elements contained in each sub-tag, regardless of the duplicates. Therefore, the total number is usually higher than the total existing elements. For example, I have a tag "Germany" with 6 subtags (and one of them, in turn, contains 8 subtags). When collapsed, Germany shows the number 412, but in reality, only 149 pictures exist in that tag structure. So 412 is the number of pictures that contain that tag, plus the number of pictures that contain each subtag. Apparently this is done on purpose, but I still find it a bit counterintuitive. In some cases I have some very detailed tag trees with show tens of thousands of pictures, when in reality they only contain 2000 pictures at most. So my proposal: Why not show only the total number of elements contained in the tree structure (so, the same number at the bottom of the screen), and also indicate the number of subtags? For instance "Germany (149, 14 subtags)" instead of "Germany (412)". Or maybe even just the first number, if you don't to clutter the interface. What do you think? I don't know if that has been previously discussed and there is an consensus on this topic, but I wouldn't mind exploring other options. Thanks for your time.
Hmm, the system has not posted the commit here so far, I'm doing it manually. I decided for this variant first. Further text behind the tag name I find confusing. Since tags with subtags occur in several images and thus the total number is not correct on a collapsed tag, we do not add them together anymore. https://invent.kde.org/kde/digikam/commit/a607c4f35819e10b982844109a9b92f2d18cd8a6 Maik
Hey. I tried the latest appimage (digikam-7.0.0-git-20191204T041752-x86-64.appimage) and I noticed that now the tag count only shows the number of pictures tagged with that specific tag, but ignoring subtags. Would it be possible to have a middle day, so it works exactly as the item count for Albums? That is, when expanded, only show the number of items with that tag, but when collapsed, also add the number of pictures of its subtags, but not both (The way it worked before, if a picture has a tag and a subtag, it would be counted twice). With an example it is clearer. Imagine I have a total of 57 pictures of Toronto, 10 of which also have been tagged with Ontario. This is how it used to be: Expanded: Collapsed: Ontario (10) Ontario (67) - Toronto (57) This is the current behavior (after your commit two weeks ago): Expanded: Collapsed: Ontario (10) Ontario (10) - Toronto (57) And this is how I believe would be more intuitive: Expanded: Collapsed: Ontario (10) Ontario (57) - Toronto (57) So basically the sum of both the parent and the child tags, but subtracting all elements that appear twice.
And that's the problem, we have a QMap stating that tag XX1 -> occurs 5 times and tag XX2 -> 8 times. But we have no breakdown of images, so whether tag XX1 also occurs in images tagged with XX2. This would mean additional database queries. We can not afford this at this point, because it has to be done quickly. Otherwise the repaint/create of the tag model will be slow. I do not have a simple solution yet. Maik
Oh, I see. So there is no quick way of showing the number of containing pictures (the number that appears at the bottom left in Digikam) without having to query each tag, right? In that case, maybe the initial behavior was more intuitive. Do you think it's better to indicate more pictures than expected, or less pictures than expected?
Git commit 8493c91be80b5941d850a86e0a5dd408ebdc5348 by Maik Qualmann. Committed on 07/12/2019 at 18:42. Pushed by mqualmann into branch 'master'. Revert "do not counting subtags when collapsed" M +1 -1 core/libs/models/abstractalbummodel.cpp https://invent.kde.org/kde/digikam/commit/8493c91be80b5941d850a86e0a5dd408ebdc5348
With next digiKam 7.4.0 release, AppImage bundle is compiled using a more recent Linux Mageia 7.1 host. Last stable Qt 5.15.2 and KF5 5.84 are used. ImageMagick codec 7 and libav 58 (ffmpeg) are used to supports extra image and video formats. https://i.imgur.com/XV1tZkL.png Please check if problem still reproducible with this version available as pre-release here: https://files.kde.org/digikam/ Gilles Caulier
Well, the behavior is the same. When a tag or folder is collapsed, the count number does not reflect the real number of items within it.
Maik, We will left as that the implementation to prevent a slowdown rendering of tags, or there is a solution to this wish ? Gilles
This behaviour is really confusing, any new about an update to get the right count ?
*** Bug 477225 has been marked as a duplicate of this bug. ***
*** Bug 485147 has been marked as a duplicate of this bug. ***
*** Bug 486974 has been marked as a duplicate of this bug. ***