Bug 413970 - No EXIF data for TIFF images
Summary: No EXIF data for TIFF images
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.2.7-beta1
Platform: Appimage Linux
: NOR wishlist
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-09 11:36 UTC by fotoclickclack
Modified: 2023-04-30 02:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description fotoclickclack 2019-11-09 11:36:33 UTC
SUMMARY
I miss EXIF data for TIFF files

STEPS TO REPRODUCE
1. Open attached TIFF file 
2. Go to LAYER -> EDIT METADATA


OBSERVED RESULT
EXIF data from JPG files are displayed but not from TIFF

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 wolthera 2019-11-09 12:24:42 UTC
Setting this to wishlist, it is just not implemented.
Comment 2 Tiar 2020-04-07 13:18:30 UTC
First the exif data dialog and stuff needs to be properly implemented.

bug 410341 (it shows internal problems with how the exif data dialog is implemented)
bug 396669
bug 396672

Phabricator task: https://phabricator.kde.org/T12935
Comment 3 Bug Janitor Service 2021-08-23 21:22:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1015
Comment 4 Dmitry Kazakov 2021-09-04 13:36:01 UTC
Git commit d8822ab986b82c7755c558950055ade1e7fc13c5 by Dmitry Kazakov, on behalf of L. E. Segovia.
Committed on 04/09/2021 at 13:08.
Pushed by dkazakov into branch 'master'.

TIFF: parse XMP metadata

M  +21   -0    plugins/impex/tiff/kis_tiff_converter.cc
M  +11   -0    plugins/impex/tiff/kis_tiff_writer_visitor.cpp

https://invent.kde.org/graphics/krita/commit/d8822ab986b82c7755c558950055ade1e7fc13c5
Comment 5 Dmitry Kazakov 2021-09-04 13:36:09 UTC
Git commit 25c2d09e4781d16ef26c9d3662fc3234977ecde2 by Dmitry Kazakov, on behalf of L. E. Segovia.
Committed on 04/09/2021 at 13:08.
Pushed by dkazakov into branch 'master'.

TIFF: parse IPTC metadata

M  +24   -0    plugins/impex/tiff/kis_tiff_converter.cc
M  +17   -1    plugins/impex/tiff/kis_tiff_writer_visitor.cpp

https://invent.kde.org/graphics/krita/commit/25c2d09e4781d16ef26c9d3662fc3234977ecde2
Comment 6 Dmitry Kazakov 2021-09-04 13:36:17 UTC
Git commit cd1b48251c6be36afa0d39af447ce8140dfd7203 by Dmitry Kazakov, on behalf of L. E. Segovia.
Committed on 04/09/2021 at 13:08.
Pushed by dkazakov into branch 'master'.

TIFF: parse Exif metadata

There are a couple limitations wrt Exiv2 which have been reported
upstream:

https://github.com/Exiv2/exiv2/issues/1879

M  +2    -2    plugins/impex/tiff/CMakeLists.txt
M  +165  -16   plugins/impex/tiff/kis_tiff_converter.cc

https://invent.kde.org/graphics/krita/commit/cd1b48251c6be36afa0d39af447ce8140dfd7203
Comment 7 amyspark 2023-04-30 02:22:24 UTC
Git commit bbee5eff34e7a17c4a1c7b59abe4823ccff7f58c by L. E. Segovia.
Committed on 30/04/2023 at 02:21.
Pushed by lsegovia into branch 'krita/5.1'.

tiff: Fix heap-buffer-overflow when endian swapping big-endian IPTC metadata

TIFFSwabArrayOfLong treats the array as N uint32_t, not N bytes (which
is what TIFFGetField returns).
Related: bug 468601

M  +4    -3    plugins/impex/tiff/kis_tiff_import.cc

https://invent.kde.org/graphics/krita/commit/bbee5eff34e7a17c4a1c7b59abe4823ccff7f58c
Comment 8 amyspark 2023-04-30 02:23:24 UTC
Git commit 0122d3461034d651ae7016db338857ddd11061c9 by L. E. Segovia.
Committed on 30/04/2023 at 02:22.
Pushed by lsegovia into branch 'master'.

tiff: Fix heap-buffer-overflow when endian swapping big-endian IPTC metadata

TIFFSwabArrayOfLong treats the array as N uint32_t, not N bytes (which
is what TIFFGetField returns).
Related: bug 468601
(cherry picked from commit bbee5eff34e7a17c4a1c7b59abe4823ccff7f58c)

M  +4    -3    plugins/impex/tiff/kis_tiff_import.cc

https://invent.kde.org/graphics/krita/commit/0122d3461034d651ae7016db338857ddd11061c9