Bug 411065 - double click on icon to make sound output default
Summary: double click on icon to make sound output default
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: applet (show other bugs)
Version: 5.16.4
Platform: Manjaro Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-19 14:31 UTC by woof
Modified: 2019-09-16 17:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
image of expected result (155.72 KB, image/jpeg)
2019-08-19 14:31 UTC, woof
Details

Note You need to log in before you can comment on or make changes to this bug.
Description woof 2019-08-19 14:31:12 UTC
Created attachment 122244 [details]
image of expected result

SUMMARY
it would be great to have a possibility to switch the default sound output device by double clicking on its icon in the tray menu.
in my everyday system usage i have to switch all sounds from speakers to headphones and back, and for now i always have to go the menu and click 'default' to make it happen.
i think that many kde users may find this option useful.  



EXPECTED RESULT
https://i.imgur.com/9cb1xCs.jpg
Comment 1 Nate Graham 2019-08-23 20:13:08 UTC
Here's a patch: https://phabricator.kde.org/D23386
Comment 2 Nate Graham 2019-09-16 17:13:52 UTC
Git commit 4a13cbf391b4faf30169fc096f0e7275248806b2 by Nate Graham.
Committed on 16/09/2019 at 17:13.
Pushed by ngraham into branch 'master'.

Use visible buttons to switch the default device

Summary:
We get numerous complaints that it's hard to figure out how to make an audio device the
default for playback or output. Despite the multiple methods (drag-and-drop, hamburger
menu item, radio button in the KCM), it still seems un-discoverable for many users.

This patch attempts to address the issue by standardizing on a single consistent method:
{nav Make default} buttons right there on the list items for the devices, for both the applet
and the KCM.The buttons are only shown when there is more than one device that could
be the default.

Various other elements of the UI are slightly adjusted or adapted to accommodate this change.
Related: bug 408490
FIXED-IN: 5.17.0

Test Plan:
Connected my Bluetooth speaker and toggled between it and the internal speakers using
the new button.

Applet: {F7341848}
KCM: {F7341852}

My wife was impressed by how easy it was and how the audio instantly switched.

Reviewers: drosca, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, GB_2, alexde, ndavis, anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23389

M  +25   -24   applet/contents/ui/ListItemBase.qml
D  +0    -30   src/kcm/package/contents/ui/DefaultDeviceButton.qml
M  +6    -10   src/kcm/package/contents/ui/DeviceListItem.qml
M  +1    -1    src/kcm/package/contents/ui/MuteButton.qml

https://commits.kde.org/plasma-pa/4a13cbf391b4faf30169fc096f0e7275248806b2