Bug 408490 - "Default" label is missing in "Devices" tab when fractional display scaling is used
Summary: "Default" label is missing in "Devices" tab when fractional display scaling i...
Status: RESOLVED FIXED
Alias: None
Product: plasma-pa
Classification: Plasma
Component: kcm (show other bugs)
Version: 5.15.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-09 17:01 UTC by Patrick Silva
Modified: 2019-09-16 17:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
"Device" tab accessed via system settings (109.12 KB, image/png)
2019-06-09 17:01 UTC, Patrick Silva
Details
"Device" tab accessed via plasma-pa applet (72.74 KB, image/png)
2019-06-09 17:02 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-06-09 17:01:48 UTC
Created attachment 120731 [details]
"Device" tab accessed via system settings

STEPS TO REPRODUCE
1. open system settings > display and monitor > click "Scale display" button and set display scale factor to 1.2 
2. relogin  
3. open system settings > Multimedia > Audio volume > "Devices" tab

OBSERVED RESULT
As we can see in the attached screenshots, "Default" label near the radio button is missing. Such bug does not occur when I access the same tab via plasma-pa applet.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.59.0
Qt Version: 5.13.0 RC
Comment 1 Patrick Silva 2019-06-09 17:02:52 UTC
Created attachment 120732 [details]
"Device" tab accessed via plasma-pa applet
Comment 2 Nate Graham 2019-09-03 16:45:58 UTC
Will be fixed by https://phabricator.kde.org/D23389
Comment 3 Nate Graham 2019-09-16 17:13:52 UTC
Git commit 4a13cbf391b4faf30169fc096f0e7275248806b2 by Nate Graham.
Committed on 16/09/2019 at 17:13.
Pushed by ngraham into branch 'master'.

Use visible buttons to switch the default device

Summary:
We get numerous complaints that it's hard to figure out how to make an audio device the
default for playback or output. Despite the multiple methods (drag-and-drop, hamburger
menu item, radio button in the KCM), it still seems un-discoverable for many users.

This patch attempts to address the issue by standardizing on a single consistent method:
{nav Make default} buttons right there on the list items for the devices, for both the applet
and the KCM.The buttons are only shown when there is more than one device that could
be the default.

Various other elements of the UI are slightly adjusted or adapted to accommodate this change.
Related: bug 411065
FIXED-IN: 5.17.0

Test Plan:
Connected my Bluetooth speaker and toggled between it and the internal speakers using
the new button.

Applet: {F7341848}
KCM: {F7341852}

My wife was impressed by how easy it was and how the audio instantly switched.

Reviewers: drosca, #plasma, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, GB_2, alexde, ndavis, anthonyfieroni, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23389

M  +25   -24   applet/contents/ui/ListItemBase.qml
D  +0    -30   src/kcm/package/contents/ui/DefaultDeviceButton.qml
M  +6    -10   src/kcm/package/contents/ui/DeviceListItem.qml
M  +1    -1    src/kcm/package/contents/ui/MuteButton.qml

https://commits.kde.org/plasma-pa/4a13cbf391b4faf30169fc096f0e7275248806b2