Bug 409814 - Reply-to SMS box is incorrectly opened when a single-sign-on SMS with a "Copy" button is clicked
Summary: Reply-to SMS box is incorrectly opened when a single-sign-on SMS with a "Copy...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Simon Redman
URL:
Keywords:
: 416326 416761 417554 418169 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-15 09:12 UTC by Simon Redman
Modified: 2020-06-04 16:58 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
The initial notification with the "Copy" action (26.91 KB, image/png)
2019-07-15 09:12 UTC, Simon Redman
Details
The same notification as shown in the Plasmoid with no reply button (21.57 KB, image/png)
2019-07-15 09:14 UTC, Simon Redman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Redman 2019-07-15 09:12:23 UTC
Created attachment 121527 [details]
The initial notification with the "Copy" action

SUMMARY
With the patch adding notification actions on desktop and Android, if we get a one-time code from a more-secure service via SMS (not that SMS codes are actually that secure...), Google's Messages app gives no "Reply" button, no text box to type in to (on Android's notification), and instead gives a "Copy <code>" button. If we click this, it copies to the clipboard on Android, which automatically syncs to the desktop clipboard, so we can paste it in to whatever service wanted the code on the desktop.

If we click the notification on the desktop, we would expect the same behavior. In fact, we do get the code into the clipboard, but in addition we get the reply-able notification reply box as a popup as well! Since there is no reply action on Android and since the button wasn't a reply button, this probably shouldn't happen.

STEPS TO REPRODUCE
1. Get one-time code via SMS
2. Click "Copy XXX" button on desktop notification
3. Get code into clipboard, but also get unwanted reply box

OBSERVED RESULT
One-time code + Reply box

EXPECTED RESULT
Just one-time code

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 29
(available in About System)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
CCing Nico since he originally wrote the code supporting notification actions. If you think there's an obvious answer, let me know! Otherwise, I have assigned this to myself since I am the dev in the best position to debug (though it is quite low on the priority list)
Comment 1 Simon Redman 2019-07-15 09:14:22 UTC
Created attachment 121528 [details]
The same notification as shown in the Plasmoid with no reply button

The notification in the list of phone notifications in the Plasmoid does not have the reply action, so maybe this is a very simple bug in spawning the notification

It would be nice to have the copy action in the Plasmoid.... Maybe we should have a way to access all actions from arbitrary notifications in any case?
Comment 2 Simon Redman 2020-01-18 02:09:40 UTC
*** Bug 416326 has been marked as a duplicate of this bug. ***
Comment 3 Simon Redman 2020-02-18 00:33:42 UTC
*** Bug 417554 has been marked as a duplicate of this bug. ***
Comment 4 Nicolas Fella 2020-02-27 18:59:17 UTC
*** Bug 418169 has been marked as a duplicate of this bug. ***
Comment 5 Simon Redman 2020-04-12 23:56:25 UTC
Please see https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/238 for a potential fix
Comment 6 Simon Redman 2020-04-24 00:29:39 UTC
This should be fixed with commit b59ef618b2809b709e3f833fb0ec1b3005decaa9 (https://invent.kde.org/kde/kdeconnect-kde/commit/b59ef618b2809b709e3f833fb0ec1b3005decaa9)
Comment 7 Simon Redman 2020-06-04 16:58:07 UTC
*** Bug 416761 has been marked as a duplicate of this bug. ***