Bug 409687 - Unset progress indicator on task manager button when quitting
Summary: Unset progress indicator on task manager button when quitting
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-10 13:53 UTC by Nate Graham
Modified: 2019-09-17 20:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.17.0


Attachments
Progress bar visible when app isn't running (15.68 KB, image/png)
2019-07-10 13:53 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-07-10 13:53:22 UTC
Created attachment 121443 [details]
Progress bar visible when app isn't running

When an app is pinned to an Icons-Only Task Manager, Plasmashell retains progress state shown for that app when the app is not running (See Bug 409660).

This manifests in Elisa's launcher icon showing a progress bar background corresponding to the playback position of the last-running song (see attached screenshot), even when the app isn't running.

This information is not useful or relevant when Elisa isn't running, so Elisa should un-set the progress information before it quits.
Comment 1 Nate Graham 2019-09-17 20:11:39 UTC
Git commit d360c5bc83ec059fb16417e6828e37e2d6651467 by Nate Graham.
Committed on 17/09/2019 at 20:11.
Pushed by ngraham into branch 'master'.

[Icons-Only Task Manager] Only show progress indicator for apps that are running

Summary:
Currently, Pinned Icons-Only Task Manager launchers are capable of showing progress
information even when they're not running, because the app didn't unset the progress
information before quitting, or crashed in the middle of an operation. But the concept
of an in-progress operation for an app that isn't running doesn't make logical sense.

This patch fixes that UI issue by only allowing pinned IOTM apps to show progress
information while they're actually running.
FIXED-IN: 5.17.0

Test Plan:
Pinned Elisa app no longer shows progress information on its icon after quitting while
playing a song

Pinned Discover app no longer shows progress information on its icon after crashing in
the middle of an update

IOTM apps still shows progress information while running

No change for regular Task Manager

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24001

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml

https://commits.kde.org/plasma-desktop/d360c5bc83ec059fb16417e6828e37e2d6651467