Bug 408593 - Duplicate Layer no move layer
Summary: Duplicate Layer no move layer
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 4.2.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
: 408032 408135 408474 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-06-12 00:37 UTC by Deo
Modified: 2019-06-27 13:12 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Deo 2019-06-12 00:37:10 UTC
SUMMARY
When you duplicate a Layer and even if you have the move tool active, you can move the layer until you press Esc key or another shortcut or tool and comeback to the move tool to be able to move the object

STEPS TO REPRODUCE
1. Layer>Duplicate it
2. Move tool active
3. drag it.

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2019-06-12 12:35:51 UTC
Hi,

Thanks for the report. I can confirm the issue.
Comment 2 Dmitry Kazakov 2019-06-13 13:46:14 UTC
Git commit 8b7be89122a1d5cab49683a44338305d2edf41d8 by Dmitry Kazakov.
Committed on 13/06/2019 at 13:45.
Pushed by dkazakov into branch 'master'.

Fix move and transform tools after quick layer duplication

Duplication happens in a node juggler that tries to keep the number of
actions/updates as low as possible, therefor it keeps a stroke open for a
couple of seconds after the user did the action. We should properly
close this stroke by emitting KisImage::sigStrokeEndRequested().

M  +1    -4    plugins/tools/basictools/kis_tool_move.cc
M  +1    -5    plugins/tools/tool_transform2/kis_tool_transform.cc

https://invent.kde.org/kde/krita/commit/8b7be89122a1d5cab49683a44338305d2edf41d8
Comment 3 Dmitry Kazakov 2019-06-13 14:16:22 UTC
*** Bug 408474 has been marked as a duplicate of this bug. ***
Comment 4 Dmitry Kazakov 2019-06-13 14:16:42 UTC
*** Bug 408135 has been marked as a duplicate of this bug. ***
Comment 5 Halla Rempt 2019-06-17 08:18:08 UTC
Git commit 93520ec52d46a4e406a60a9049c50827ea4090e9 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 17/06/2019 at 08:16.
Pushed by rempt into branch 'krita/4.2'.

Fix move and transform tools after quick layer duplication

Duplication happens in a node juggler that tries to keep the number of
actions/updates as low as possible, therefor it keeps a stroke open for a
couple of seconds after the user did the action. We should properly
close this stroke by emitting KisImage::sigStrokeEndRequested().

M  +1    -4    plugins/tools/basictools/kis_tool_move.cc
M  +1    -5    plugins/tools/tool_transform2/kis_tool_transform.cc

https://invent.kde.org/kde/krita/commit/93520ec52d46a4e406a60a9049c50827ea4090e9
Comment 6 Halla Rempt 2019-06-27 13:12:12 UTC
*** Bug 408032 has been marked as a duplicate of this bug. ***