Bug 408439 - Outline selection tool not working properly
Summary: Outline selection tool not working properly
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
: 408136 408691 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-06-08 01:03 UTC by Pia Lorena
Modified: 2019-07-17 09:13 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pia Lorena 2019-06-08 01:03:09 UTC
SUMMARY

Whenever I use the outline selection tool, it considers the place I last clicked as the first point in the curve instead of the first and last whenever I try to select a section, even though it shouldn't.

STEPS TO REPRODUCE
As explained in this video which I recorded recently (https://youtu.be/pp72jCFjUBE) these are the following steps:
1. Click on a random point on the canvas
2. Select the outline selection tool and attempt to select a section of the layer you want to modify.


OBSERVED RESULT
If the point selected in the step one is outside or inside the selection, it simply creates a weird shape instead of following the start and final point of the selection.

EXPECTED RESULT
Should simply follow the start and final path of the selection, not considering the last click before tracing it.


SOFTWARE/OS VERSIONS

 
Linux [name] 4.18.0-21-generic #22-Ubuntu SMP Wed May 15 13:13:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

GNOME VERSION: Ubuntu 18.10

ADITIONAL INFO: 
I'm using the krita-4.2.1-x86_64.appimage, but I had the same issue with the upgraded 4.2.0 version
Comment 1 vanyossi 2019-06-08 04:17:50 UTC
I can confirm this bug
Comment 2 Halla Rempt 2019-06-12 14:13:02 UTC
What is the action set to? And is the mode vector or raster? You can find those options in the tool option docker.
Comment 3 Pia Lorena 2019-06-12 21:29:33 UTC
(In reply to Boudewijn Rempt from comment #2)
> What is the action set to? And is the mode vector or raster? You can find
> those options in the tool option docker.

I already tested it in both; vector and pixel modes. It does seem to have the similar issue with the different actions, excluding Add and Subtract.
Comment 4 Bug Janitor Service 2019-06-13 04:33:12 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 Halla Rempt 2019-06-14 15:36:50 UTC
*** Bug 408691 has been marked as a duplicate of this bug. ***
Comment 6 vanyossi 2019-06-20 16:11:18 UTC
Git commit fc4216eb1caa8a24abe1ca50a574a6116583ce72 by Ivan Yossi.
Committed on 20/06/2019 at 15:42.
Pushed by ivany into branch 'master'.

Make sure we clear all points in outline selection on click

M  +1    -0    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/fc4216eb1caa8a24abe1ca50a574a6116583ce72
Comment 7 vanyossi 2019-06-21 01:47:22 UTC
*** Bug 408136 has been marked as a duplicate of this bug. ***
Comment 8 Halla Rempt 2019-06-24 08:21:44 UTC
Git commit 425109ba3c95163a978725a73fc23437c034d552 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 24/06/2019 at 08:20.
Pushed by rempt into branch 'krita/4.2'.

Make sure we clear all points in outline selection on click

M  +1    -0    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/425109ba3c95163a978725a73fc23437c034d552
Comment 9 acc4commissions 2019-07-05 17:13:39 UTC
This happens with Line Tool too... (in the nightly builds)
Comment 10 vanyossi 2019-07-16 04:54:16 UTC
Git commit 663d3d09da7b51c38004a9e057ed7672d80b86d5 by Ivan Yossi.
Committed on 16/07/2019 at 04:53.
Pushed by ivany into branch 'master'.

Clear any left over point in line tool on each use

We clear points on any single click in line tool to avoid false starts.

M  +1    -0    plugins/tools/basictools/kis_tool_line.cc
M  +7    -1    plugins/tools/basictools/kis_tool_line_helper.cpp
M  +1    -0    plugins/tools/basictools/kis_tool_line_helper.h

https://invent.kde.org/kde/krita/commit/663d3d09da7b51c38004a9e057ed7672d80b86d5
Comment 11 Halla Rempt 2019-07-17 09:13:47 UTC
Git commit 71b0a92e6fbaeff2781629f63c106ecd337906ec by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 17/07/2019 at 09:13.
Pushed by rempt into branch 'krita/4.2'.

Clear any left over point in line tool on each use

We clear points on any single click in line tool to avoid false starts.

M  +1    -0    plugins/tools/basictools/kis_tool_line.cc
M  +7    -1    plugins/tools/basictools/kis_tool_line_helper.cpp
M  +1    -0    plugins/tools/basictools/kis_tool_line_helper.h

https://invent.kde.org/kde/krita/commit/71b0a92e6fbaeff2781629f63c106ecd337906ec