Created attachment 120485 [details] Side toolbar text does not fade STEPS TO REPRODUCE 1. Go to System Settings > Colors 2. Edit the current color scheme 3. Check "Apply Inactive window effects" 4. Go to the "inactive" tab, change "Contrast" to "Fade" and move the slider a ways to the right 5. Open Okular and then make the window inactive OBSERVED RESULT The left side toolbar's text does not fade when the window becomes inactive EXPECTED RESULT The text should fade ADDITIONAL INFORMATION Discovered while working on https://phabricator.kde.org/T10201 SOFTWARE/OS VERSIONS Everything from git master
https://cgit.kde.org/okular.git/tree/ui/sidebar.cpp caches only 4 colors (fg/bg for normal/selected). It would also need to cache the inactive colors. Not sure if this is a junior job, because I haven't checked whether KStatefulBrush/KColorScheme supports QPalette::ColorGroup.
Git commit b8b36ae529599da358f433fe23d7bac4dea79fa8 by Nate Graham. Committed on 27/05/2020 at 13:37. Pushed by ngraham into branch 'master'. Improve the sidebar's navigation and UX Okular's sidebar vertical view chooser toolbar suffers from a few issues: * It's a nonstandard UI not used for category choosers in other pieces of KDE software, and not used in other FOSS document readers * What is shown and what is hidden is simultaneously too configurable while still not offering the desirable UI common to other programs (i.e. no visible category chooser, but a sidebar capable of displaying thumbnails, table of contents, search results, etc.) * With labels on it takes up quite a bit of horizontal space, while with labels off, the categories are less than clear * UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category to hide that category's view while keeping the view chooser visible, showing mostly disabled items) * It's made with custom painting code, which reduces maintainability and introduces bugs (e.g. https://bugs.kde.org/show_bug.cgi?id=408190) This patch removes the vertical category chooser entirely and replaces it with a tabbed view on the top of the sidebar itself. The tabs are icons-only and have large icons. A button is added on the left side of the default toolbar to quickly hide or show the sidebar. In order to make room for the new button, the Previous and Next buttons on the toolbar are removed, as previous/next buttons are already present on the Page Bar on the bottom of the window so there's no need to duplicate this functionality. This improves the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term maintainability.  Related: bug 213508, bug 334441, bug 344599, bug 335189 FIXED-IN: 1.11.0 CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space M +- -- doc/annotations.png M +- -- doc/bookmark-management.png M +8 -10 doc/index.docbook M +- -- doc/mainwindow.png M +- -- doc/signatures-panel.png M +34 -34 part.cpp M +4 -2 part.h M +2 -3 part.rc M +10 -1 ui/bookmarklist.cpp M +11 -1 ui/layers.cpp M +11 -1 ui/side_reviews.cpp M +21 -654 ui/sidebar.cpp M +1 -19 ui/sidebar.h M +14 -1 ui/signaturepanel.cpp M +23 -0 ui/thumbnaillist.cpp M +2 -3 ui/thumbnaillist.h M +10 -1 ui/toc.cpp https://invent.kde.org/graphics/okular/commit/b8b36ae529599da358f433fe23d7bac4dea79fa8