Bug 334441 - Allow users to disable the context menu on the left side of okular with the mouse button (right mouse button)
Summary: Allow users to disable the context menu on the left side of okular with the m...
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-06 20:52 UTC by shevegen
Modified: 2020-05-27 13:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.11.0
Sentry Crash Report:


Attachments
An illustration of the "hide sidebar"/"show sidebar" button in Gwenview (509.02 KB, image/png)
2017-01-06 18:51 UTC, Paul McAuley
Details
An illustration of the "hide sidebar"/"show sidebar" button in Gwenview (273.74 KB, video/mp4)
2017-01-06 19:02 UTC, Paul McAuley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description shevegen 2014-05-06 20:52:29 UTC
In Configuration there is a "Show Navigation Panel". This is useful, but I need to click
F7, or select on the menu.

What would be more intuitive would be to enable the same action via the contextmenu when clicking on the left side.

Reproducible: Always
Comment 1 Christoph Feck 2014-06-02 21:02:46 UTC
A user that hides it via a context menu there might wonder how to get it back. Having it hide/show with repeatable actions is better usability.
Comment 2 Paul McAuley 2017-01-06 18:51:39 UTC
Created attachment 103241 [details]
An illustration of the "hide sidebar"/"show sidebar" button in Gwenview

It would be good if there were a button to show/hide the navigation panel like Gwenview has a button to show/hide its sidebar.

The F7 keyboard shortcut is not always easy to remember and some visual cue to be able to hide and show the navigation panel would be good.
Comment 3 Paul McAuley 2017-01-06 19:02:27 UTC
Created attachment 103242 [details]
An illustration of the "hide sidebar"/"show sidebar" button in Gwenview
Comment 4 Nate Graham 2020-05-27 13:37:45 UTC
Git commit b8b36ae529599da358f433fe23d7bac4dea79fa8 by Nate Graham.
Committed on 27/05/2020 at 13:37.
Pushed by ngraham into branch 'master'.

Improve the sidebar's navigation and UX

Okular's sidebar vertical view chooser toolbar suffers from a few issues:

* It's a nonstandard UI not used for category choosers in other pieces of KDE software,
  and not used in other FOSS document readers
* What is shown and what is hidden is simultaneously too configurable while still not
  offering the desirable UI common to other programs (i.e. no visible category chooser,
  but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
* With labels on it takes up quite a bit of horizontal space, while with labels off, the
  categories are less than clear
* UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
  to hide that category's view while keeping the view chooser visible, showing mostly
  disabled items)
* It's made with custom painting code, which reduces maintainability and introduces bugs
  (e.g. https://bugs.kde.org/show_bug.cgi?id=408190)

This patch removes the vertical category chooser entirely and replaces it with a tabbed
view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
button is added on the left side of the default toolbar to quickly hide or show the
sidebar. In order to make room for the new button, the Previous and Next buttons on the
toolbar are removed, as previous/next buttons are already present on the Page Bar on the
bottom of the window so there's no need to duplicate this functionality. This improves
the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
maintainability.

![vokoscreenNG-2020-04-16_13-29-24](https://invent.kde.org/graphics/okular/uploads/a1f96a315b69282df51de9993b1befaf/vokoscreenNG-2020-04-16_13-29-24.webm)
Related: bug 213508, bug 344599, bug 408190, bug 335189

FIXED-IN: 1.11.0

CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space

M  +-    --    doc/annotations.png
M  +-    --    doc/bookmark-management.png
M  +8    -10   doc/index.docbook
M  +-    --    doc/mainwindow.png
M  +-    --    doc/signatures-panel.png
M  +34   -34   part.cpp
M  +4    -2    part.h
M  +2    -3    part.rc
M  +10   -1    ui/bookmarklist.cpp
M  +11   -1    ui/layers.cpp
M  +11   -1    ui/side_reviews.cpp
M  +21   -654  ui/sidebar.cpp
M  +1    -19   ui/sidebar.h
M  +14   -1    ui/signaturepanel.cpp
M  +23   -0    ui/thumbnaillist.cpp
M  +2    -3    ui/thumbnaillist.h
M  +10   -1    ui/toc.cpp

https://invent.kde.org/graphics/okular/commit/b8b36ae529599da358f433fe23d7bac4dea79fa8