Bug 407698 - Cannot deactivate samba shares on neon dev unstable
Summary: Cannot deactivate samba shares on neon dev unstable
Status: RESOLVED FIXED
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-18 18:37 UTC by Patrick Silva
Modified: 2019-05-21 20:57 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kdenetwork-filesharing/27ebbf47a81608fea27512fc08be8676411e71a8
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-05-18 18:37:11 UTC 
SUMMARY
maybe a regression related to the fix for bug 407500.

STEPS TO REPRODUCE
1. open Dolphin
2. open the properties window of any shared folder
3. click "Share" tab
4. uncheck "Share this folder..."

OBSERVED RESULT
you can not apply the change because "Ok" button is greyed out.

EXPECTED RESULT
"OK" button is clickable

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.16.80
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.0


ADDITIONAL INFORMATION
I can' reproduce with kdenetwork-filesharing 19.04.1 on Arch Linux.
Comment 1 Nate Graham 2019-05-21 20:46:11 UTC 
Oh goodness.
Comment 2 Nate Graham 2019-05-21 20:56:31 UTC 
Git commit 27ebbf47a81608fea27512fc08be8676411e71a8 by Nate Graham.
Committed on 21/05/2019 at 20:49.
Pushed by ngraham into branch 'Applications/19.04'.

Don't ever disable the OK button when the user is trying to remove a share

M  +5    -0    samba/filepropertiesplugin/sambausershareplugin.cpp

https://commits.kde.org/kdenetwork-filesharing/27ebbf47a81608fea27512fc08be8676411e71a8
Comment 3 Nate Graham 2019-05-21 20:57:20 UTC 
Thanks very much for noticing this quickly. Keep 'em coming! I'm going to be working on this code more.