Bug 407500 - "Allow guests" checkbox is enabled despite its state can not be changed
Summary: "Allow guests" checkbox is enabled despite its state can not be changed
Status: RESOLVED FIXED
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-13 15:18 UTC by Patrick Silva
Modified: 2019-05-17 20:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.04.2
Sentry Crash Report:


Attachments
screen recording (1.00 MB, video/webm)
2019-05-13 15:18 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-05-13 15:18:45 UTC
Created attachment 120045 [details]
screen recording

SUMMARY
Watch the screen recording.
"Allow guests" checkbox is enabled but it's impossible to check it.


EXPECTED RESULT
Keep "Allow guests" option greyed out until "Share with Samba (ms windows)" is checked.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.0
Comment 1 Nate Graham 2019-05-17 13:59:32 UTC
I think the root cause here is that the Samba share you're trying to create doesn't actually get created successfully (Bug 381301). Can you confirm?
Comment 2 Patrick Silva 2019-05-17 14:05:48 UTC
No. I can create samba shares.
The same behavior shown in the screen recording occurs on Arch Linux.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0 beta3
Comment 3 Nate Graham 2019-05-17 15:47:13 UTC
Oh, this is just a UI bug then. That checkbox shouldn't even be enabled if the folder isn't being shared. Here's a patch: https://phabricator.kde.org/D21253
Comment 4 Nate Graham 2019-05-17 20:30:23 UTC
Git commit 29c9fc1d09b92649c48b966b1df4ae3277e56634 by Nate Graham.
Committed on 17/05/2019 at 20:29.
Pushed by ngraham into branch 'Applications/19.04'.

Enable and disable UI controls properly based on sharing status

Summary:
When a folder isn't shared, all of the UI controls that depend on it being shared
should be disabled.
FIXED-IN: 19.04.1

Test Plan: {F6828673, size=full, loop=true, autoplay=true}

Reviewers: #vdg, filipf

Reviewed By: #vdg, filipf

Differential Revision: https://phabricator.kde.org/D21253

M  +4    -1    samba/filepropertiesplugin/sambausershareplugin.cpp
M  +4    -1    samba/filepropertiesplugin/sambausershareplugin.ui

https://commits.kde.org/kdenetwork-filesharing/29c9fc1d09b92649c48b966b1df4ae3277e56634