Bug 407667 - Clicking on an expired notification in the history should launch or focus the app that sent it
Summary: Clicking on an expired notification in the history should launch or focus the...
Status: ASSIGNED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.15.90
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: usability
: 416644 447389 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-17 21:19 UTC by Nate Graham
Modified: 2024-03-11 14:15 UTC (History)
16 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-05-17 21:19:55 UTC
I know we can't have interactive expired notifications (Bug 407361). However, we do store information about which app sent each notification, so we could at least make expired notifications in the history launch or focus the sending app when clicked. This would really help the typical notification workflow where you go to the history to see what you missed, then go to the app that sent each one to see everything or complete an action.
Comment 1 Kai Uwe Broulik 2020-01-23 15:39:08 UTC
*** Bug 416644 has been marked as a duplicate of this bug. ***
Comment 2 Michael D 2021-10-29 10:56:40 UTC
An "app" can have many open instances or associated windows (such as when one composes an email). Unless this specific information is stored, it could be a mess to randomly focus one of many open instances or one of many associated windows.
Comment 3 Nicolas Fella 2021-12-22 20:18:26 UTC
What we can do is activate the default action when clicking on the history item, just like with the popup. That however only works if 1) there is a default action set by the app 2) the app passes the "resident" hint
Comment 4 Nicolas Fella 2021-12-22 20:18:46 UTC
*** Bug 447389 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2021-12-23 16:23:51 UTC
Sounds good to me.

Though I wonder what the point is of making the app pass the resident hint? Wouldn't we want this for everything, unconditionally?
Comment 6 Nicolas Fella 2021-12-23 16:33:57 UTC
Without the resident hint the app throws away its internal notification object, so it could not react to the action being triggered
Comment 7 Nicolas Fella 2021-12-23 16:34:22 UTC
*throws away when the notification popup closes
Comment 8 Aroun 2023-05-03 09:17:59 UTC
Can we not vote for this?
Comment 9 Dmitry Alexandrov 2023-05-04 03:38:05 UTC
(In reply to Aroun from comment #8)
> Can[not we] vote for this?

Indeed, it seems, that `plasmashell` maintainers do not allow users to upvote their bugs.
Comment 10 Puspam Adak 2023-11-26 14:38:51 UTC
(In reply to Nicolas Fella from comment #6)
> Without the resident hint the app throws away its internal notification
> object, so it could not react to the action being triggered

That may not be true. Applications may not set the resident hint while still specifying notification actions. The applications won't be stupid enough to throw away its internal object if it sets any action.
Hence, the logic should be like if the notification has any action, keep it interactive in history.
Comment 11 Nicolas Fella 2023-11-26 14:43:10 UTC
(In reply to Puspam Adak from comment #10)
> (In reply to Nicolas Fella from comment #6)
> > Without the resident hint the app throws away its internal notification
> > object, so it could not react to the action being triggered
> 
> That may not be true. Applications may not set the resident hint while still
> specifying notification actions. The applications won't be stupid enough to
> throw away its internal object if it sets any action.
> Hence, the logic should be like if the notification has any action, keep it
> interactive in history.

We don't need to guess/assume here, only look at what KNotifications does.

KNotification objects self-delete when the notification popup is closed. Other implementations may behave differently, but we know how KNotifications behaves and have to consider that other implementations do as well
Comment 12 Naxdy 2024-03-02 11:25:16 UTC
FYI: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2178

Not sure why it wasn't auto linked here