Bug 407561 - Delete applet config window and move its two options into the KCM
Summary: Delete applet config window and move its two options into the KCM
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: applet (show other bugs)
Version: 5.15.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords: usability
: 412068 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-15 14:57 UTC by Kishore Gopalakrishnan
Modified: 2019-12-18 14:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2019-05-15 14:57:39 UTC
SUMMARY
If we right-click on the 'Networks' item in the system tray, we get two options. One of them opens the system settings panel to configure networks, while the other opens a configuration window for the plasmoid. Currently, it is difficult to distinguish which does what from the name alone. The option that opens the configuration for the plasmoid should be more clearly named as 'Configure Networks Plasmoid' or 'Configure this applet'.

SOFTWARE/OS VERSIONS
Linux distro: Arch Linux
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.57.0
Qt Version: 5.13.0

ADDITIONAL INFORMATION
Simliar to bug 407560, but for this plasmoid.
Comment 1 Nate Graham 2019-05-21 19:27:38 UTC
IMO the real solution here is to remove the configuration window and move its two options into the KCM. This is what we did for the Notifications applet recently.
Comment 2 fire f. 2019-08-09 12:26:09 UTC
I confirm that the wording of the 2 options is not helpful, is has very little explanatory value.
Comment 3 Nate Graham 2019-09-19 20:40:12 UTC
*** Bug 412068 has been marked as a duplicate of this bug. ***
Comment 4 Lukas Sabota 2019-09-19 20:41:49 UTC
Apologies for the dupe - thanks for marking it, Nate.  Glad to see this is already being tracked
Comment 5 Nate Graham 2019-09-19 20:45:22 UTC
No worries!
Comment 6 Jan Grulich 2019-12-18 13:48:25 UTC
Git commit 7601936e36429357b89b779b939fa231737fa3a5 by Jan Grulich.
Committed on 18/12/2019 at 13:48.
Pushed by grulich into branch 'master'.

Move applet configuration to KCM

Summary:
It doesn't make sense to have additional applet configuration, especially when
the configuration is not related only to the applet.

Reviewers: ngraham, #plasma

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26041

D  +0    -33   applet/contents/config/config.qml
D  +0    -19   applet/contents/config/main.xml
D  +0    -52   applet/contents/ui/configGeneral.qml
M  +2    -8    applet/contents/ui/main.qml
M  +2    -1    kcm/CMakeLists.txt
R  +0    -0    kcm/qml/AddConnectionDialog.qml [from: kcm/qml/Dialog.qml - 100% similarity]
A  +109  -0    kcm/qml/ConfigurationDialog.qml     [License: LGPL]
M  +40   -15   kcm/qml/main.qml

https://commits.kde.org/plasma-nm/7601936e36429357b89b779b939fa231737fa3a5