Bug 407560 - Delete applet config window and move its single option elsewhere (into the applet's context menu, maybe?)
Summary: Delete applet config window and move its single option elsewhere (into the ap...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Battery Monitor (show other bugs)
Version: 5.15.5
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-15 14:49 UTC by Kishore Gopalakrishnan
Modified: 2021-05-05 15:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2019-05-15 14:49:56 UTC
SUMMARY
If we right-click on the 'Battery and Brightness' item in the system tray, we get two options: 'Configure Power Saving', and 'Configure Battery and Brightness'. The former opens the system settings area, while the latter opens the configuration for the plasmoid. The option that opens the configuration window for the plasmoid should be named more clearly as 'Configure Battery and Brightness Plasmoid' or 'Configure this Plasmoid'. Currently, I find it confusing as to which option does what.

SOFTWARE/OS VERSIONS
Linux distro: Arch Linux
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.57.0
Qt Version: 5.13.0
Comment 1 Nate Graham 2019-05-21 19:30:35 UTC
The applet's config window only has a single checkbox. I think a whole settings window is total overkill and the better solution is to move this somewhere else. Maybe it could even be a checkable menu item in the right-click menu.
Comment 2 Bug Janitor Service 2021-04-23 18:01:19 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/811
Comment 3 Nate Graham 2021-05-05 15:43:13 UTC
Git commit 9eafbd28bd3d1c5fb5d6b5d1dae9f38c7ec278ef by Nate Graham.
Committed on 05/05/2021 at 15:42.
Pushed by ngraham into branch 'master'.

[applets/batterymonitor] Overhaul configuration and actions

Right now the applet puts the entries to open the KCM and Energy Info
page in a hamburger menu, while the Configure button opens the applet's
own settings window which has only one item in it. This emphasizes the
less important thing, while de-emphasizing the more important thing.

We can solve this by making the applet's configure button open the KCM
instead of the applet configuration window. This makes the configuration
window inaccessible, so we delete it and move its one setting into the
hamburger menu along with "Show Energy Information". This is okay as
these two are lesser-used settings.

Overall this should make the actions easier to access and use, and more
relevant to the user.
FIXED-IN: 5.22

D  +0    -30   applets/batterymonitor/package/contents/config/config.qml
D  +0    -41   applets/batterymonitor/package/contents/ui/ConfigGeneral.qml
M  +16   -4    applets/batterymonitor/package/contents/ui/batterymonitor.qml

https://invent.kde.org/plasma/plasma-workspace/commit/9eafbd28bd3d1c5fb5d6b5d1dae9f38c7ec278ef