Bug 406482 - Embedded album art visible in Dolphin sometimes not visible in Elisa
Summary: Embedded album art visible in Dolphin sometimes not visible in Elisa
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 393486 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-12 16:51 UTC by Nate Graham
Modified: 2019-05-03 13:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Art visible in Dolphin, but not visible in Elisa (467.20 KB, image/png)
2019-04-12 16:51 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-04-12 16:51:59 UTC
Created attachment 119385 [details]
Art visible in Dolphin, but not visible in Elisa

Elisa and all KDE frameworks from git master.

Elisa is now very good at displaying album art. However I still have a few albums whose art doesn't show up despite it being embedded in the file. For these albums, Dolphin is capable of showing the embedded artwork, but Elisa doesn't see it. See attached screenshot.
Comment 1 Nate Graham 2019-04-12 16:54:56 UTC
Affected music files: https://www.dropbox.com/s/8fnbhf8eqqya0gj/Affected%20items.tar.gz?dl=0 (too big to attach to the bug, sorry)
Comment 2 Matthieu Gallien 2019-04-18 12:53:33 UTC
Thanks for your report and the test data.
I will have a look quickly to fix it before the next release.
Comment 3 Matthieu Gallien 2019-04-28 14:55:51 UTC
Work in progress revision: https://phabricator.kde.org/D20879
Comment 4 Matthieu Gallien 2019-05-03 05:03:23 UTC
Git commit 9fd1e7bcafa11417a1271e770d33e33cb26ba6b6 by Matthieu Gallien.
Committed on 03/05/2019 at 05:03.
Pushed by mgallien into branch '0.4'.

do not forget the album cover when using embedded cover images

Summary:
Use embedded cover images when inserting an album in database allowing tracks and albums to use the right cover image

Currently require a reimport of database. Will fix that in a later revision.
Related: bug 393486

Test Plan: Auto tests are OK. Attached test files show an embedded cover image.

Reviewers: ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D20879

M  +185  -16   src/databaseinterface.cpp

https://commits.kde.org/elisa/9fd1e7bcafa11417a1271e770d33e33cb26ba6b6
Comment 5 Nate Graham 2019-05-03 13:39:54 UTC
That commit fixed the issue for all of my albums with embedded covers, thanks!
Comment 6 Nate Graham 2019-05-03 13:40:16 UTC
*** Bug 393486 has been marked as a duplicate of this bug. ***