Bug 393486 - Elisa not picking covers for songs
Summary: Elisa not picking covers for songs
Status: RESOLVED DUPLICATE of bug 406482
Alias: None
Product: Elisa
Classification: Applications
Component: baloo (show other bugs)
Version: 0.3.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-25 04:56 UTC by sk.griffinix
Modified: 2019-05-03 13:40 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (116.75 KB, image/png)
2018-05-31 05:17 UTC, sk.griffinix
Details
screenshot (116.75 KB, image/png)
2018-05-31 05:18 UTC, sk.griffinix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sk.griffinix 2018-04-25 04:56:44 UTC
elisa is not picking covers for song. If a png image is added to the folder, cover for all songs is displayed as that png
Comment 1 Matthieu Gallien 2018-05-02 16:12:13 UTC
Could you please test with the latest version ? For example, you can easily get it from the flatpak KDE repository.
Comment 2 Christoph Feck 2018-05-30 22:32:44 UTC
If you can provide the information requested in comment #1, please add it.
Comment 3 sk.griffinix 2018-05-31 05:15:56 UTC
(In reply to Christoph Feck from comment #2)
> If you can provide the information requested in comment #1, please add it.

I tested it on version 0.1.1-1 (not flatpack), and it still has same problem. I will add an image where it does not show covers
Comment 4 sk.griffinix 2018-05-31 05:17:04 UTC
Created attachment 112969 [details]
screenshot
Comment 5 sk.griffinix 2018-05-31 05:18:18 UTC
Created attachment 112971 [details]
screenshot
Comment 6 Matthieu Gallien 2018-09-05 19:23:38 UTC
Currently, it is not handling icon themes other than breeze very well. Could you the latest stable version with your icon theme and also with Breeze ?
Comment 7 sk.griffinix 2018-09-05 19:36:03 UTC
(In reply to Matthieu Gallien from comment #6)
> Currently, it is not handling icon themes other than breeze very well. Could
> you the latest stable version with your icon theme and also with Breeze ?

I installed version 0.2.1-1. My icon theme was papirus-adapta. The bug was same as before. I changed the theme to breeze and relaunched the player. Covers were still not displayed. Also the same result with breeze dark. As a final try, i first switched to breeze icon theme, then installed elisa again. Still the same result
Comment 8 sk.griffinix 2018-09-05 19:38:12 UTC
To confirm it was not a problem with song themselves, i tested them in lollypop player and covers were displayed
Comment 9 Elias 2018-10-10 16:34:00 UTC
I'm using Elisa 0.3 on Manjaro Linux.
Some cover arts are displayed, others not. It seems to depend on the file. I have only embedded covers. The cover images of some mp3 files are displayed, but not for ogg vorbis or opus files with embedded cover.
Comment 10 Christophe Caillet 2018-10-30 10:17:58 UTC
Hi all,

I confirm that Elisa doesn't display correctly my covers which are embedded as TAG on my MP3 files. I testd on my MP4A files from my iTunes library and result is the same : no covers are displayed.

Tested on Elisa 0.3.0-1 from Neon packages.
Comment 11 Matthieu Gallien 2018-10-30 10:49:52 UTC
(In reply to Christophe Caillet from comment #10)
> Hi all,
> 
> I confirm that Elisa doesn't display correctly my covers which are embedded
> as TAG on my MP3 files. I testd on my MP4A files from my iTunes library and
> result is the same : no covers are displayed.
> 
> Tested on Elisa 0.3.0-1 from Neon packages.

Support for embedded covers has been added in KFileMetaData but not yet in Elisa. It is not expected to work yet.
Comment 12 sk.griffinix 2019-04-28 19:51:56 UTC
> 
> Support for embedded covers has been added in KFileMetaData but not yet in
> Elisa. It is not expected to work yet.

Any progress made as to display of embedded covers? I still not getting them on elisa
Comment 13 Matthieu Gallien 2019-05-03 05:03:23 UTC
Git commit 9fd1e7bcafa11417a1271e770d33e33cb26ba6b6 by Matthieu Gallien.
Committed on 03/05/2019 at 05:03.
Pushed by mgallien into branch '0.4'.

do not forget the album cover when using embedded cover images

Summary:
Use embedded cover images when inserting an album in database allowing tracks and albums to use the right cover image

Currently require a reimport of database. Will fix that in a later revision.
Related: bug 406482

Test Plan: Auto tests are OK. Attached test files show an embedded cover image.

Reviewers: ngraham

Reviewed By: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D20879

M  +185  -16   src/databaseinterface.cpp

https://commits.kde.org/elisa/9fd1e7bcafa11417a1271e770d33e33cb26ba6b6
Comment 14 Nate Graham 2019-05-03 13:40:16 UTC
Embedded cover support was just added!

*** This bug has been marked as a duplicate of bug 406482 ***