Bug 405548 - Dark breeze: invalid tooltip/widget colors with compositing enabled
Summary: Dark breeze: invalid tooltip/widget colors with compositing enabled
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.15.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
: 405558 405607 405767 407044 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-17 08:07 UTC by Andrzej Rybczak
Modified: 2019-04-29 13:03 UTC (History)
18 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-framework/3aba8a7e10e509d4a321adb0b7540a73be023c10
Version Fixed In: 5.57
Sentry Crash Report:

Attachments
Widget with compositing enabled (42.80 KB, image/png)
2019-03-17 08:07 UTC, Andrzej Rybczak 		Details
Breeze Dark (25.80 KB, image/png)
2019-04-09 06:50 UTC, imraro 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Rybczak 2019-03-17 08:07:04 UTC 
Created attachment 118853 [details]
Widget with compositing enabled

SUMMARY

When Plasma theme is set to Dark Breeze and kwin compositing enabled, colors of the midgets are not what they're supposed to be. This is with plasma 5.15.3 and qt 5.12.2

It was fine with plasma 5.15.2 and qt 5.12.1. I'm not sure if qt version has anything to do with it, but I'm attaching that info since Arch updated both at once.

STEPS TO REPRODUCE
1. Set Plasma theme to Dark breeze.
2. Enable compositing.
3. Check how KDE menu or widgets look.

OBSERVED RESULT
See bad_widget.png.

EXPECTED RESULT
Dark widget background.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.15.3
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 5.12.2

ADDITIONAL INFORMATION
Comment 1 Andrzej Rybczak 2019-03-17 08:11:33 UTC 
Hmm, I made an interesting typo and now don't know how to edit the message.

I was of course talking about the colors of widgets, not midgets.
Comment 2 Antonio Rojas 2019-03-17 11:20:03 UTC 
*** Bug 405558 has been marked as a duplicate of this bug. ***
Comment 3 Antonio Rojas 2019-03-17 11:21:16 UTC 
Triggered by this qtsvg commit

https://code.qt.io/cgit/qt/qtsvg.git/commit/?h=5.12.2&id=dcc4e2c4d96a6ad1447b9fb679afca21bb381218
Comment 4 Denis Falqueto 2019-03-17 12:47:03 UTC 
Downgrading to Qt 5.12.1 fixes it for now.
Comment 5 Filip Fila 2019-03-17 12:48:52 UTC 
Fix under review: https://phabricator.kde.org/D19821
Comment 6 Ardith Metz 2019-03-17 14:21:18 UTC 
The fix isn't complete: https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417
Comment 7 Martin Schnitkemper 2019-03-17 21:43:58 UTC 
Almost fixed on Arch with latest package plasma-framework release 5.56.1-3, but tooltips have still a light gray background while the compositor is actve; with a disabled compositor it has a dark background as expected.  Can be easy verfied by switching the compositor on and off using Alt+Shift+F12.
Comment 8 Antonio Rojas 2019-03-18 17:04:52 UTC 
*** Bug 405607 has been marked as a duplicate of this bug. ***
Comment 9 Denis Falqueto 2019-03-18 23:28:33 UTC 
I would like to inform that my system (Arch Linux based) is back to normal behavior, after the latest plasma-workspace and plasma-framework packages were updated.
Comment 10 Vadym Krevs 2019-03-19 13:43:43 UTC 
Still a problem on openSUSE 15.0 with latest qt 5.12.2, plasma 5.15.3 and framework 5.56.1 from OBS.

$ rpm -q libQt5Core5 plasma5-desktop plasma5-workspace plasma-framework
libQt5Core5-5.12.2-lp150.1.1.x86_64
plasma5-desktop-5.15.3-lp150.353.2.x86_64
plasma5-workspace-5.15.3-lp150.445.2.x86_64
plasma-framework-5.56.1-lp150.244.1.x86_64

$ rpm -qa | grep -i breeze | sort
breeze4-style-5.15.3-lp150.240.1.x86_64
breeze-5.15.3-lp150.241.1.x86_64
breeze5-cursors-5.15.3-lp150.241.1.noarch
breeze5-decoration-5.15.3-lp150.241.1.x86_64
breeze5-icons-5.56.0-lp150.119.1.noarch
breeze5-style-5.15.3-lp150.241.1.x86_64
breeze5-style-lang-5.15.3-lp150.241.1.noarch
breeze5-wallpapers-5.15.3-lp150.241.1.noarch
firefox-theme-breeze-dark-1.1.1-lp150.6.1.x86_64
gtk2-metatheme-breeze-5.15.3-lp150.2.2.noarch
gtk3-metatheme-breeze-5.15.3-lp150.2.2.noarch
libbreezecommon4-5-5.15.3-lp150.240.1.x86_64
libbreezecommon5-5-5.15.3-lp150.241.1.x86_64
metatheme-breeze-common-5.15.3-lp150.2.2.x86_64
Comment 11 Fabian Vogt 2019-03-19 13:53:01 UTC 
Git commit 3aba8a7e10e509d4a321adb0b7540a73be023c10 by Fabian Vogt.
Committed on 19/03/2019 at 13:52.
Pushed by fvogt into branch 'master'.

Fix breeze dialog background with Qt 5.12.2

Summary:
style elements without type="text/css" were ignored before, but now they act as
if type was set. Set id and style properly to restore the working behaviour.

Test Plan:
Installed new files on a system with Qt 5.12.2, wiped the SVG cache
and it looks fine again.

Reviewers: #plasma, rooty

Reviewed By: rooty

Subscribers: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19821

M  +-    --    src/desktoptheme/breeze/dialogs/background.svgz
M  +-    --    src/desktoptheme/breeze/translucent/dialogs/background.svgz
M  +-    --    src/desktoptheme/breeze/translucent/widgets/tooltip.svgz
M  +-    --    src/desktoptheme/breeze/widgets/tooltip.svgz

https://commits.kde.org/plasma-framework/3aba8a7e10e509d4a321adb0b7540a73be023c10
Comment 12 Higa 2019-03-20 07:33:29 UTC 
arojas, could you please update the patch for the corresponding package in Arch Linux (plasma-framework)? The patch in Arch Linux's build is outdated - it does not contain the patch for src/desktoptheme/breeze/translucent/widgets/tooltip.svgz .
Comment 13 Martin Schnitkemper 2019-03-23 11:25:41 UTC 
Package has been rebuilt on Arch as plasma-framework-5.56.1-4 with the lastest patches included, and it seems that the tootips working for me now with dark background and compositing enabled.
Comment 14 Patrick Silva 2019-03-23 15:37:39 UTC 
*** Bug 405767 has been marked as a duplicate of this bug. ***
Comment 15 imraro 2019-04-09 06:50:35 UTC 
Created attachment 119313 [details]
Breeze Dark

Not fixed for me:

# lsb_release -a
LSB Version:    1.4
Distributor ID: Arch
Description:    Arch Linux
Release:        rolling
Codename:       Santiago

# pacman -Qi breeze
Name            : breeze
Version         : 5.15.4-1
...

# pacman -Qi plasma-workspace 
Name            : plasma-workspace
Version         : 5.15.4-1
...
Comment 16 Kai Uwe Broulik 2019-04-29 12:59:45 UTC 
*** Bug 407044 has been marked as a duplicate of this bug. ***
Comment 17 imraro 2019-04-29 13:03:25 UTC 
Please ignore #15. A had some customizes stuff at ~/.local/share/plasma/desktoptheme/default