Bug 404572 - Sorting by desktop not working
Summary: Sorting by desktop not working
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.15.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
Keywords: regression
: 405007 (view as bug list)
Depends on:
Reported: 2019-02-19 20:13 UTC by Michael D
Modified: 2019-03-13 12:28 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.3


Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2019-02-19 20:13:19 UTC
Sorting by desktop is no longer working after the update to 5.15 (from 5.14.5). There are a few entries I have on desktop 4 that are appearing first, such as Dolphin and a KWrite instance. Both are set to display *only* on desktop 4. (I have a 2x2 virtual desktop configuration.)

Other ways of sorting, e.g. alphabetical, seem to be working. It might be relevant that I switch from an internal to an external display, with only one display ever powered.
Comment 1 Lars Wendler (Polynomial-C) 2019-02-22 01:12:11 UTC
Same here on Gentoo Linux. Happens with plasma-5.15.0 and -5.15.1

It seems like entries from last virtual desktop get "wrapped around" and appear as if they were started on the first virtual desktop.
Comment 2 Eike Hein 2019-02-23 17:01:37 UTC
Hmm, having trouble reproducing this at the moment
Comment 3 Eike Hein 2019-02-23 17:01:59 UTC
Disregard the above comment, I wrote it just before reproducing it after all and then was going to set to Confirmed :-)
Comment 4 Eike Hein 2019-02-23 17:11:06 UTC
Patch under review: https://phabricator.kde.org/D19259
Comment 5 Lars Wendler (Polynomial-C) 2019-02-23 19:01:16 UTC
Thanks, the patch is a big improvement but doesn't fix the issue entirely.

If you have a window that is configured to appear on all desktops, this entry now moves around when you switch between first and and any other virtual desktop.
Comment 6 Eike Hein 2019-02-25 08:15:44 UTC
Thanks for testing, I'll go back and take another stab at it :)
Comment 7 Eike Hein 2019-02-27 01:16:58 UTC
Please give the updated patch another try now.
Comment 8 Lars Wendler (Polynomial-C) 2019-02-28 10:40:46 UTC
Unfortuantely the updated patch doesn't change anything regarding windows that appear on all virtual desktops.
Comment 9 Eike Hein 2019-02-28 19:00:02 UTC
Would you mind recording a video? Because it's working just fine for me.
Comment 10 Lars Wendler (Polynomial-C) 2019-02-28 19:18:22 UTC
(In reply to Eike Hein from comment #9)
> Would you mind recording a video? Because it's working just fine for me.

Hello Eike,

I've sent you a link to the video via mail.
Comment 11 Eike Hein 2019-03-04 15:18:45 UTC
Received & deemed helpful, thanks! Please re-test the new revision of the patch now.
Comment 12 Lars Wendler (Polynomial-C) 2019-03-04 22:29:58 UTC
The updated patch fixes the issue for me. Thank you very much!
Comment 13 Patrick Silva 2019-03-05 12:16:21 UTC
*** Bug 405007 has been marked as a duplicate of this bug. ***
Comment 14 Eike Hein 2019-03-11 16:34:34 UTC
Git commit 53290043796c90207c5b7b6aad4a70f030514a97 by Eike Hein.
Committed on 11/03/2019 at 16:34.
Pushed by hein into branch 'Plasma/5.15'.

[Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

Summary: BUG:404572

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: asturmlechner, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19259

M  +28   -27   libtaskmanager/tasksmodel.cpp

Comment 15 Eike Hein 2019-03-13 08:52:11 UTC
My pleasure! Thanks for the report/info, and especially for testing the patches.
Comment 16 Eike Hein 2019-03-13 08:53:39 UTC
(Whoops! Accidental Bugzilla reply.)
Comment 17 Michael D 2019-03-13 12:28:07 UTC
Yes, thanks very much for the quick fix!