Bug 403412 - Small Desktop Icons are too wide
Summary: Small Desktop Icons are too wide
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: master
Platform: Manjaro Linux
: NOR major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 406199 406618 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-01-19 19:43 UTC by olegbessbrony
Modified: 2019-04-17 13:46 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.9


Attachments
Wide icons (149.92 KB, image/png)
2019-01-19 19:43 UTC, olegbessbrony
Details

Note You need to log in before you can comment on or make changes to this bug.
Description olegbessbrony 2019-01-19 19:43:51 UTC
Created attachment 117563 [details]
Wide icons

SUMMARY
After upgrading system packages i get wide icons on desktop 

STEPS TO REPRODUCE

1. Update system pakages 

OBSERVED RESULT

Wide desctop icons

EXPECTED RESULT

???

SOFTWARE/OS VERSIONS


 ██████████████████  ████████     defective@AdmPC
 ██████████████████  ████████     OS: Manjaro 18.0.2 Illyria
 ██████████████████  ████████     Kernel: x86_64 Linux 4.19.14-1-MANJARO
 ██████████████████  ████████     Uptime: 30m
 ████████            ████████     Packages: 1343
 ████████  ████████  ████████     Shell: bash
 ████████  ████████  ████████     Resolution: 1600x900
 ████████  ████████  ████████     DE: KDE 5.53.0 / Plasma 5.14.5
 ████████  ████████  ████████     WM: KWin
 ████████  ████████  ████████     WM Theme: Breeze High Contrast
 ████████  ████████  ████████     GTK Theme: Breeze-Dark [GTK2/3]
 ████████  ████████  ████████     Icon Theme: Adwaita
 ████████  ████████  ████████     Font: Noto Sans Regular
 ████████  ████████  ████████     CPU: Intel Pentium 4 3.00GHz @ 2x 3GHz
                                  GPU: GeForce GT 610
                                  RAM: 1152MiB / 3252MiB



ADDITIONAL INFORMATION
Comment 1 Rog131 2019-01-20 09:39:06 UTC
Marking this as the dublicate of the 'Spacing too large between icons in "folder view mode" in the desktop' renamed as 'Implement a slider to control horizontal grid spacing'.

If not reopen this one.

*** This bug has been marked as a duplicate of bug 403094 ***
Comment 2 Nate Graham 2019-04-07 23:21:54 UTC
*** Bug 406199 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2019-04-07 23:23:29 UTC
While I still think we will ultimately need a label width/grid size control like Dolphin has (Bug 403094), that's controversial so I'll use this to improve the current hardcoded width. And who knows, maybe this time the default width will be good enough that nobody complains anymore and we won't have to. :)
Comment 4 Nate Graham 2019-04-07 23:39:15 UTC
Here's a patch: https://phabricator.kde.org/D20368
Comment 5 Nate Graham 2019-04-08 13:05:31 UTC
*** Bug 406199 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2019-04-08 14:44:23 UTC
Git commit 1c2dd97e8cd493d7cb92a3e398cc68317e01a996 by Nate Graham.
Committed on 08/04/2019 at 14:44.
Pushed by ngraham into branch 'Plasma/5.12'.

[Folder View] Use a more reasonable minimum cell width

Summary:
With the goal of making Folder View items' labels more legible,
78da28e7ab7d51e46fa26788d4890b692996ad36 increased the minimum cell
width, resulting in each cell being much wider when icon sizes are small.

The goal was achieved, but the change went a bit too far and people have
understandably complained about the width being too high and looking silly
when the icon size is small, especially for items with very short labels.

This patch reduces the minimum width a bit to improve the situation.

I still suspect that we may need to add a slider to control the label width just like
the one Dolphin has (see D20370), but hopefully this patch should improve the
situation for people using the LTS release, and reduce the pressure for yet
another user-facing setting.
FIXED-IN: 5.12.9

Test Plan:
Smallest icon size: {F6758566}
Small-medium icon size: {F6758568}
Medium icon size: {F6758569}
[No change for larger icon sizes]

Reviewers: hein, #plasma, #vdg

Reviewed By: hein, #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20368

M  +1    -1    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/1c2dd97e8cd493d7cb92a3e398cc68317e01a996
Comment 7 Kai Uwe Broulik 2019-04-17 09:06:54 UTC
*** Bug 406618 has been marked as a duplicate of this bug. ***
Comment 8 Alberto Zacchetti 2019-04-17 12:02:25 UTC
I tried the patch, but the difference is very little. I also believe that it would be a good idea to allow users to adjust the width of the grid a little more freely.
Comment 9 Kai Uwe Broulik 2019-04-17 13:06:36 UTC
Plasma 5.16 comes with a setting for this.
Comment 10 Nate Graham 2019-04-17 13:46:08 UTC
Yep, See Bug 403094!