Bug 403094 - Implement a slider to control horizontal grid spacing
Summary: Implement a slider to control horizontal grid spacing
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.14.5
Platform: Other Linux
: NOR task
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 10:29 UTC by Potomac
Modified: 2019-04-18 22:37 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0
Sentry Crash Report:


Attachments
spacing too large between icons (23.62 KB, image/jpeg)
2019-01-11 10:29 UTC, Potomac
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Potomac 2019-01-11 10:29:44 UTC
Created attachment 117397 [details]
spacing too large between icons

SUMMARY
I use archlinux, 
since plasma 5.14.5 I notice that the spacing between icons is too large when the desktop is configured in "folder view mode",

with the previous versions of plasma the spacing was smaller, I think it's a bug in 5.14.5, maybe triggered by one of these two commits :

https://cgit.kde.org/plasma-desktop.git/commit/containments/desktop/package/contents/ui/FolderItemDelegate.qml?id=5323adb7cfac55b2f702076d4f4ae7939b97c296

https://cgit.kde.org/plasma-desktop.git/commit/containments/desktop/package/contents/ui/FolderView.qml?id=78da28e7ab7d51e46fa26788d4890b692996ad36

STEPS TO REPRODUCE
1. install plasma 5.14.5
2. configure your desktop to "folder view mode"
3. select a directory to display on the desktop
4. you will notice that the spacing between the icons on the desktop is too large (see the screenshot as attached file)

OBSERVED RESULT
the spacing between the icons on the desktop is too large


EXPECTED RESULT
the spacing should be more smaller, like the previous version of plasma (5.14.4)

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: archlinux 64 bits, plasma 5.14.5
(available in About System)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 18.12.1
Qt Version: 5.12.0

ADDITIONAL INFORMATION
I use the oxygen theme
Comment 1 Potomac 2019-01-11 22:15:39 UTC
(In reply to Potomac from comment #0)
> with the previous versions of plasma the spacing was smaller, I think it's a
> bug in 5.14.5, maybe triggered by one of these two commits :
> 
> https://cgit.kde.org/plasma-desktop.git/commit/containments/desktop/package/
> contents/ui/FolderItemDelegate.
> qml?id=5323adb7cfac55b2f702076d4f4ae7939b97c296
> 
> https://cgit.kde.org/plasma-desktop.git/commit/containments/desktop/package/
> contents/ui/FolderView.qml?id=78da28e7ab7d51e46fa26788d4890b692996ad36
> 

If I revert these 2 commits then the bug disapears, the spacing becomes smaller, like the previous version of plasma (5.14.4)
Comment 2 Nate Graham 2019-01-15 16:17:15 UTC
It was https://cgit.kde.org/plasma-desktop.git/commit/containments/desktop/package/contents/ui/FolderView.qml?id=78da28e7ab7d51e46fa26788d4890b692996ad36.

We made this change because people complained (rightly) that with tiny icons, the labels were illegible. See https://phabricator.kde.org/file/data/bg6vqy2eq6mpms3befix/PHID-FILE-m6onff6ercyz3jqsrxw2/Before.png for an example of how long labels looked before this change.

It seems that no matter what we do here, someone is unhappy, so I strongly support the introduction of a slider to determine the grid spacing. I think it's the only way we can end the cycle of "it's too big!" "Now I can't read the labels!" "Now it's too big again!" "Now I can't read the labels again!"
Comment 3 Rog131 2019-01-20 09:39:06 UTC
*** Bug 403412 has been marked as a duplicate of this bug. ***
Comment 4 Dušan Dragić 2019-03-09 15:04:44 UTC
A slider for spacing would be great, I just updated plasma to 5.14.5 on my Fedora 29 system and the desktop icon spacing is ridiculous. Had to revert the changes to FolderView.qml to keep my sanity.

/rant
Honestly I don't understand why do people who use really small icons expect to see all of the text? Want to see the whole line? You got tooltips.

Cut it off aggressively, more so then now and only line split on space.
Comment 5 Nate Graham 2019-04-07 22:58:53 UTC
*** Bug 406199 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2019-04-07 23:41:42 UTC
We'll continue using this bug to track implementing a "Label Width" slider. Meanwhile, I'll improve the default minimum width in https://phabricator.kde.org/D20368
Comment 7 Nate Graham 2019-04-08 00:57:58 UTC
Here's a patch: https://phabricator.kde.org/D20370
Comment 8 Nate Graham 2019-04-08 16:05:38 UTC
Git commit bad5d2b8973c3f1d389227caf9926cc46e441ac5 by Nate Graham.
Committed on 08/04/2019 at 16:05.
Pushed by ngraham into branch 'master'.

[Folder View] Implement a user-configurable setting for label width

Summary:
It seems impossible to satisfy everyone's preferences regarding label width in Folder
View. Some people want small icons with narrow labels (403412). Other people want small
icons with wide labels (379432). There have been other complaints in the past too, which
have led to the current settings, but because these preferences are opposed, the more we
tweak the settings to please one group of people, the more we annoy another.

Accordingly, This patch implements a user-configurable setting to determine the label width
for Folder View items in Icons view. This should put the matter to rest once and for all.
FIXED-IN: 5.16

Test Plan:
Default settings (large icons + medium label width): {F6758619}

Small icons + narrow labels: {F6758622}

Small icons + medium labels: {F6758624}

SmallMedium icons + medium labels: {F6758625}

Large icons + wide labels: {F6758626}

Reviewers: hein, #plasma, #vdg

Reviewed By: hein, #plasma

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20370

M  +4    -0    containments/desktop/package/contents/config/main.xml
M  +15   -1    containments/desktop/package/contents/ui/ConfigIcons.qml
M  +1    -1    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/bad5d2b8973c3f1d389227caf9926cc46e441ac5