Bug 403258 - Margins of list items are wrong
Summary: Margins of list items are wrong
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 386040 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-01-16 06:33 UTC by Noah Davis
Modified: 2019-01-17 21:03 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/systemsettings/0f1f43c9897f531a7e9c6131946794b4c6131782
Version Fixed In: 5.16.0

Attachments
System Settings vs Okular (77.57 KB, image/png)
2019-01-16 06:33 UTC, Noah Davis 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Noah Davis 2019-01-16 06:33:59 UTC 
Created attachment 117482 [details]
System Settings vs Okular

SUMMARY
In System Settings, the margins for list items in the Sidebar View are much larger than similarly sized sidebar buttons in Qt Widget applications like Okular.

The list item height in SySe is 43px with 22px icons while the sidebar buttons in Okular are 42px high with 32px icons. The fact that the list items in SySe are 43px high also makes the icon and text slightly off center.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20190112
KDE Plasma Version: 5.14.5
Qt Version: 5.12.0
KDE Frameworks Version: 5.53.0
Comment 1 Nate Graham 2019-01-17 03:21:09 UTC 
Agreed. Code is in <kirigami repo>/src/controls/BasicListItem.qml if you wanna tinker.
Comment 2 Marco Martin 2019-01-17 17:07:25 UTC 
Git commit 0f1f43c9897f531a7e9c6131946794b4c6131782 by Marco Martin.
Committed on 17/01/2019 at 17:06.
Pushed by mart into branch 'master'.

default icons to 32x32 pixels
reviewed-by: VDG and Nate Graham

M  +1    -0    sidebar/package/contents/ui/CategoriesPage.qml
M  +1    -0    sidebar/package/contents/ui/SubCategoryPage.qml

https://commits.kde.org/systemsettings/0f1f43c9897f531a7e9c6131946794b4c6131782
Comment 3 Nate Graham 2019-01-17 18:20:16 UTC 
*** Bug 386040 has been marked as a duplicate of this bug. ***