Bug 402922 - Spell check
Summary: Spell check
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-SpellCheck (show other bugs)
Version: 5.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-06 12:48 UTC by Christian Gruber
Modified: 2022-08-29 11:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Gruber 2019-01-06 12:48:02 UTC
SUMMARY
It would be nice to do checking of correct spelling, especially when editing a picture description.

STEPS TO REPRODUCE
1. Click on 'Beschriftungen' (sth like 'label') on the right hand side,
2. Click on the tab 'Beschreibung' (sth like 'description')
3. Enter some text, including a misspelled word

OBSERVED RESULT
The word shows normally

EXPECTED RESULT
It should be marked


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 18.10
(available in About System)
KDE Plasma Version: ?
KDE Frameworks Version: 5.50.0
Qt Version: 5.11.1
Comment 1 caulier.gilles 2019-01-06 13:49:17 UTC
See my last comment from #360954

*** This bug has been marked as a duplicate of bug 360954 ***
Comment 2 caulier.gilles 2019-08-21 10:06:36 UTC
Fixed with bug #360954
Comment 3 Christian Gruber 2019-08-21 10:16:03 UTC
I would nut call it 'fixed', because this behavior is still there. I would give it 'upstream' instead. The KDE bug that I filed is still untouched, by the way. I believe that this feature is lost.
Comment 4 caulier.gilles 2022-08-01 08:40:48 UTC
Git commit d221946db853b8e4b977f65f83260c6d29ebfae5 by Gilles Caulier.
Committed on 01/08/2022 at 08:31.
Pushed by cgilles into branch 'master'.

Introduce usage of KF5::Sonnet to perform basis spell-checking in caption text fields.
We do not use voluntary the more complex KF5::KTextEdit as it introduces extra keyboard shortcuts which break the user workflow
while tagging items in collection or navigating in albums.
The spell-checking language is set with the text language code from caption settings.
The dictionaries must be installed of course from one of supported back-end as ASpell or Hunspell

M  +1    -0    Mainpage.dox
M  +1    -0    NEWS
M  +1    -0    core/app/DigikamCoreTarget.cmake
M  +1    -0    core/cmake/rules/RulesKDEFramework.cmake
M  +1    -0    core/libs/widgets/CMakeLists.txt
M  +30   -6    core/libs/widgets/metadata/utils/altlangstredit.cpp

https://invent.kde.org/graphics/digikam/commit/d221946db853b8e4b977f65f83260c6d29ebfae5
Comment 5 caulier.gilles 2022-08-01 12:51:09 UTC
Git commit 3fbab7e6768cfae273db95766c97c4d112922e2e by Gilles Caulier.
Committed on 01/08/2022 at 12:45.
Pushed by cgilles into branch 'master'.

Use QTexEdit and Sonnet to suppoet spell checking in metadata edit plugin
Related: bug 256471, bug 92310, bug 360954

M  +2    -0    core/dplugins/generic/metadata/metadataedit/CMakeLists.txt
M  +7    -6    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.cpp
M  +10   -3    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.h

https://invent.kde.org/graphics/digikam/commit/3fbab7e6768cfae273db95766c97c4d112922e2e
Comment 6 caulier.gilles 2022-08-01 13:09:44 UTC
Git commit 0f5c436745f8fea708aa07f9fa7d7fba21ff2234 by Gilles Caulier.
Committed on 01/08/2022 at 13:02.
Pushed by cgilles into branch 'master'.

Use QTexEdit and Sonnet to support spell checking in metadata edit plugin
Related: bug 256471, bug 92310, bug 360954

M  +1    -1    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.h
M  +21   -15   core/dplugins/generic/metadata/metadataedit/exif/exifcaption.cpp
M  +15   -9    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.cpp

https://invent.kde.org/graphics/digikam/commit/0f5c436745f8fea708aa07f9fa7d7fba21ff2234
Comment 7 caulier.gilles 2022-08-01 13:20:45 UTC
Git commit 3eaf564eebebd76951f1a6131a150d2937a52b3f by Gilles Caulier.
Committed on 01/08/2022 at 13:18.
Pushed by cgilles into branch 'master'.

Revert QPlainTextEdit conversion to QTextEdit as Sonnet spell checker can be applied to QPlainTextEdit too.
Related: bug 360954, bug 256471, bug 92310

M  +4    -4    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.cpp
M  +2    -2    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.h
M  +8    -8    core/dplugins/generic/metadata/metadataedit/exif/exifcaption.cpp
M  +5    -5    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.cpp

https://invent.kde.org/graphics/digikam/commit/3eaf564eebebd76951f1a6131a150d2937a52b3f
Comment 8 caulier.gilles 2022-08-03 12:38:28 UTC
Git commit dd436d167db768603b966c7a1697ccd020eedf86 by Gilles Caulier.
Committed on 03/08/2022 at 12:35.
Pushed by cgilles into branch 'master'.

Factoring spell-checking in common widget based on QTextEdit and QPlainTextEdit
These common widget provide a way to set visible lines to edit contents, in goal to optimize space on GUI.
Add more fields in Metadata Editpr with spell-checking.
Related: bug 360954, bug 256471, bug 92310

M  +0    -1    core/dplugins/generic/metadata/metadataedit/CMakeLists.txt
M  +4    -9    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.cpp
M  +7    -8    core/dplugins/generic/metadata/metadataedit/dialog/limitedtextedit.h
M  +36   -41   core/dplugins/generic/metadata/metadataedit/exif/exifcaption.cpp
M  +6    -1    core/dplugins/generic/metadata/metadataedit/exif/exifcaption.h
M  +4    -8    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.cpp
M  +1    -0    core/libs/widgets/CMakeLists.txt
A  +140  -0    core/libs/widgets/text/dtextedit.cpp     [License: GPL (v2+)]
A  +99   -0    core/libs/widgets/text/dtextedit.h     [License: GPL (v2+)]

https://invent.kde.org/graphics/digikam/commit/dd436d167db768603b966c7a1697ccd020eedf86
Comment 9 caulier.gilles 2022-08-03 14:56:12 UTC
Git commit f3f4de94637e1f8dcd5ac42667d9f72e68747691 by Gilles Caulier.
Committed on 03/08/2022 at 14:55.
Pushed by cgilles into branch 'master'.

ad spell-checking to IPTC/Contents/Headline
Related: bug 360954, bug 256471, bug 92310

M  +25   -26   core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.cpp

https://invent.kde.org/graphics/digikam/commit/f3f4de94637e1f8dcd5ac42667d9f72e68747691
Comment 10 caulier.gilles 2022-08-04 07:20:15 UTC
Git commit 96cb1846f4e419f048dfd9bc271aa26650da542a by Gilles Caulier.
Committed on 04/08/2022 at 07:19.
Pushed by cgilles into branch 'master'.

add spell-checking to IPTC/Credits/Credit|Source|Copyright
Related: bug 360954, bug 256471, bug 92310

M  +23   -25   core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.cpp

https://invent.kde.org/graphics/digikam/commit/96cb1846f4e419f048dfd9bc271aa26650da542a
Comment 11 caulier.gilles 2022-08-04 07:39:46 UTC
Git commit e83464b986c29df6d57aa1d8e8c18a2b3db0cdb9 by Gilles Caulier.
Committed on 04/08/2022 at 07:38.
Pushed by cgilles into branch 'master'.

Add spell-checking to IPTC/Keywords
Related: bug 360954, bug 256471, bug 92310

M  +26   -24   core/dplugins/generic/metadata/metadataedit/iptc/iptckeywords.cpp

https://invent.kde.org/graphics/digikam/commit/e83464b986c29df6d57aa1d8e8c18a2b3db0cdb9
Comment 12 caulier.gilles 2022-08-04 09:16:32 UTC
Git commit b4e1ac9de4ac69993df1aad8ab5e348c5e12c5dc by Gilles Caulier.
Committed on 04/08/2022 at 09:14.
Pushed by cgilles into branch 'master'.

Add spell-checking to IPTC/Categories
Related: bug 360954, bug 256471, bug 92310

M  +51   -29   core/dplugins/generic/metadata/metadataedit/iptc/iptccategories.cpp

https://invent.kde.org/graphics/digikam/commit/b4e1ac9de4ac69993df1aad8ab5e348c5e12c5dc
Comment 13 caulier.gilles 2022-08-04 13:26:13 UTC
Git commit 6ed87cec3bd9cef85adbedd2f4787a6547ad2c7c by Gilles Caulier.
Committed on 04/08/2022 at 13:24.
Pushed by cgilles into branch 'master'.

Add spell-checking to IPTC/Status/Title|Edit Status|Job Identifier
Related: bug 360954, bug 256471, bug 92310

M  +35   -52   core/dplugins/generic/metadata/metadataedit/iptc/iptcstatus.cpp
M  +0    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcstatus.h

https://invent.kde.org/graphics/digikam/commit/6ed87cec3bd9cef85adbedd2f4787a6547ad2c7c
Comment 14 caulier.gilles 2022-08-05 03:37:43 UTC
Git commit 834d3b3b710a7297553e5707c818859c3fff3f8e by Gilles Caulier.
Committed on 05/08/2022 at 03:28.
Pushed by cgilles into branch 'master'.

Spell-Checking with KF5::Sonet is now an optional dependencies with digiKam core.
Related: bug 360954, bug 256471, bug 92310

M  +1    -1    Mainpage.dox
M  +2    -0    core/CMakeLists.txt
M  +9    -1    core/app/DigikamCoreTarget.cmake
M  +3    -0    core/app/utils/digikam_config.h.cmake.in
M  +1    -1    core/cmake/rules/RulesKDEFramework.cmake
M  +8    -0    core/libs/dialogs/libsinfodlg.cpp
M  +4    -1    core/libs/widgets/CMakeLists.txt
M  +74   -13   core/libs/widgets/text/dtextedit.cpp
M  +5    -3    core/libs/widgets/text/dtextedit.h

https://invent.kde.org/graphics/digikam/commit/834d3b3b710a7297553e5707c818859c3fff3f8e
Comment 15 caulier.gilles 2022-08-05 09:26:20 UTC
Git commit c7448014d43529bf9d1b5280415665a7a88abc50 by Gilles Caulier.
Committed on 05/08/2022 at 09:24.
Pushed by cgilles into branch 'master'.

Add spell-checking support and configuration (aka dictionaries and backends available) on Components Info dialog.
Related: bug 360954, bug 256471, bug 92310

M  +15   -14   core/libs/dialogs/libsinfodlg.cpp

https://invent.kde.org/graphics/digikam/commit/c7448014d43529bf9d1b5280415665a7a88abc50
Comment 16 caulier.gilles 2022-08-05 11:44:14 UTC
Git commit 5e64e105b44759b9d0e30c185fc9c9982322ae16 by Gilles Caulier.
Committed on 05/08/2022 at 11:41.
Pushed by cgilles into branch 'master'.

Add spell-checking to XMP/Status/Headline|Caption Writer
Related: bug 360954, bug 256471, bug 92310

M  +9    -12   core/dplugins/generic/metadata/metadataedit/xmp/xmpcontent.cpp

https://invent.kde.org/graphics/digikam/commit/5e64e105b44759b9d0e30c185fc9c9982322ae16
Comment 17 caulier.gilles 2022-08-05 12:29:08 UTC
Git commit 144cf28c9b54de5864d5e31404495e353df192b5 by Gilles Caulier.
Committed on 05/08/2022 at 12:21.
Pushed by cgilles into branch 'master'.

Add spell-checking to XMP/Credits/Creator Title|Credit|Source
Related: bug 360954, bug 256471, bug 92310

M  +8    -8    core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.cpp
M  +11   -11   core/dplugins/generic/metadata/metadataedit/xmp/xmpcontent.cpp
M  +20   -21   core/dplugins/generic/metadata/metadataedit/xmp/xmpcredits.cpp

https://invent.kde.org/graphics/digikam/commit/144cf28c9b54de5864d5e31404495e353df192b5
Comment 18 caulier.gilles 2022-08-05 19:24:32 UTC
Git commit 59cad479108b7d192746531dd197c39530530738 by Gilles Caulier.
Committed on 05/08/2022 at 19:06.
Pushed by cgilles into branch 'master'.

Add spell-checking to XMP/Keywords|Categories|Status
Related: bug 360954, bug 256471, bug 92310

M  +15   -8    core/dplugins/generic/metadata/metadataedit/xmp/xmpcategories.cpp
M  +16   -7    core/dplugins/generic/metadata/metadataedit/xmp/xmpkeywords.cpp
M  +3    -5    core/dplugins/generic/metadata/metadataedit/xmp/xmpstatus.cpp

https://invent.kde.org/graphics/digikam/commit/59cad479108b7d192746531dd197c39530530738
Comment 19 caulier.gilles 2022-08-05 21:47:08 UTC
Git commit 65807f474fe98fd4ef52a0a6964574ee6549f200 by Gilles Caulier.
Committed on 05/08/2022 at 21:39.
Pushed by cgilles into branch 'master'.

Add spell-checking to metadata Template/Rights section
Related: bug 360954, bug 256471, bug 92310

M  +21   -24   core/libs/template/templatepanel.cpp

https://invent.kde.org/graphics/digikam/commit/65807f474fe98fd4ef52a0a6964574ee6549f200
Comment 20 caulier.gilles 2022-08-05 22:02:14 UTC
Git commit 70e85dfe8bc7d61fba7994d669c8ac86dbc59007 by Gilles Caulier.
Committed on 05/08/2022 at 22:01.
Pushed by cgilles into branch 'master'.

Add spell-checking to Album Caption from Album Properties dialog
Related: bug 360954, bug 256471, bug 92310

M  +3    -3    core/libs/album/widgets/albumpropsedit.cpp

https://invent.kde.org/graphics/digikam/commit/70e85dfe8bc7d61fba7994d669c8ac86dbc59007
Comment 21 caulier.gilles 2022-08-06 17:42:08 UTC
Git commit f5fd6da6ccfd1549762ef9d140ca90bd55e6bc3c by Gilles Caulier.
Committed on 06/08/2022 at 17:40.
Pushed by cgilles into branch 'master'.

Add spell-checking to BQM Watermark and Editor InsertText plugins
Related: bug 360954, bug 256471, bug 92310

M  +5    -6    core/dplugins/bqm/decorate/watermark/watermark.cpp
M  +4    -4    core/dplugins/editor/decorate/inserttext/inserttexttool.cpp

https://invent.kde.org/graphics/digikam/commit/f5fd6da6ccfd1549762ef9d140ca90bd55e6bc3c
Comment 22 caulier.gilles 2022-08-08 00:40:59 UTC
Git commit 6cb9ace70ca5177e7ff9ebb7b98c4f0dca4e444e by Gilles Caulier.
Committed on 08/08/2022 at 00:39.
Pushed by cgilles into branch 'master'.

Add spell-checking to HTML Export gallery title
Related: bug 360954, bug 256471, bug 92310

M  +3    -3    core/dplugins/generic/tools/htmlgallery/wizard/htmloutputpage.cpp

https://invent.kde.org/graphics/digikam/commit/6cb9ace70ca5177e7ff9ebb7b98c4f0dca4e444e
Comment 23 caulier.gilles 2022-08-08 00:51:54 UTC
Git commit 5c5c3d258ed7cd43265c232d18931ca29e8b9491 by Gilles Caulier.
Committed on 08/08/2022 at 00:50.
Pushed by cgilles into branch 'master'.

Add spell-checking to Font Properties dialog
Related: bug 360954, bug 256471, bug 92310

M  +3    -2    core/libs/properties/captions/captionedit.cpp
M  +0    -1    core/libs/properties/captions/itemdescedittab.cpp
M  +4    -3    core/libs/widgets/fonts/dfontproperties.cpp

https://invent.kde.org/graphics/digikam/commit/5c5c3d258ed7cd43265c232d18931ca29e8b9491
Comment 24 caulier.gilles 2022-08-08 01:12:49 UTC
Git commit 6f9396acf33729349dd17327d9a3777888e3e624 by Gilles Caulier.
Committed on 08/08/2022 at 01:11.
Pushed by cgilles into branch 'master'.

Add spell-checking to WebService new album dialog for Title and Description properties
Related: bug 360954, bug 256471, bug 92310

M  +0    -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpproperties.cpp
M  +10   -8    core/dplugins/generic/webservices/smugmug/smugnewalbumdlg.cpp
M  +2    -1    core/dplugins/generic/webservices/smugmug/smugnewalbumdlg.h
M  +12   -12   core/libs/dplugins/webservices/wsnewalbumdialog.cpp
M  +4    -4    core/libs/dplugins/webservices/wsnewalbumdialog.h
M  +1    -1    core/libs/properties/captions/captionedit.cpp
M  +2    -2    core/libs/properties/captions/captionedit.h
M  +1    -0    core/libs/widgets/text/dtextedit.cpp

https://invent.kde.org/graphics/digikam/commit/6f9396acf33729349dd17327d9a3777888e3e624
Comment 25 caulier.gilles 2022-08-08 01:21:04 UTC
Git commit 7eaac578d84120d788e71d9fe9595a201d925ac5 by Gilles Caulier.
Committed on 08/08/2022 at 01:20.
Pushed by cgilles into branch 'master'.

Add spell-checking to Media Wiki Export settings text properties
Related: bug 360954, bug 256471, bug 92310

M  +17   -13   core/dplugins/generic/webservices/mediawiki/mediawikiwidget.cpp

https://invent.kde.org/graphics/digikam/commit/7eaac578d84120d788e71d9fe9595a201d925ac5
Comment 26 caulier.gilles 2022-08-08 01:30:34 UTC
Git commit 0ad81015d9002e04447284a9db40cba02dd58116 by Gilles Caulier.
Committed on 08/08/2022 at 01:29.
Pushed by cgilles into branch 'master'.

Add spell-checking to iNaturalist Export observation description property
Related: bug 360954, bug 256471, bug 92310

M  +0    -1    core/dplugins/generic/webservices/facebook/fbtalker.cpp
M  +0    -1    core/dplugins/generic/webservices/facebook/fbtalker_wizard.cpp
M  +0    -1    core/dplugins/generic/webservices/imageshack/imageshackwindow.cpp
M  +1    -1    core/dplugins/generic/webservices/inaturalist/inatwidget.cpp
M  +2    -2    core/dplugins/generic/webservices/inaturalist/inatwidget_p.h
M  +2    -1    core/dplugins/generic/webservices/inaturalist/inatwindow.cpp

https://invent.kde.org/graphics/digikam/commit/0ad81015d9002e04447284a9db40cba02dd58116
Comment 27 caulier.gilles 2022-08-08 09:16:26 UTC
Git commit b93cd82f03330811541693c58abd1dc1a4a7f8b4 by Gilles Caulier.
Committed on 08/08/2022 at 09:10.
Pushed by cgilles into branch 'master'.

More place holder text to use
More text filed supporting spell-checking in IPTC editor
Factoring IPTC object edit code
Related: bug 360954, bug 256471, bug 92310

M  +17   -10   core/dplugins/generic/metadata/metadataedit/dialog/objectattributesedit.cpp
M  +1    -3    core/dplugins/generic/metadata/metadataedit/dialog/objectattributesedit.h
M  +5    -5    core/dplugins/generic/metadata/metadataedit/exif/exifcaption.cpp
M  +2    -2    core/dplugins/generic/metadata/metadataedit/exif/exifdevice.cpp
M  +2    -2    core/dplugins/generic/metadata/metadataedit/iptc/iptccategories.cpp
M  +2    -2    core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.cpp
M  +3    -3    core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.cpp
M  +1    -0    core/dplugins/generic/metadata/metadataedit/iptc/iptckeywords.cpp
M  +9    -31   core/dplugins/generic/metadata/metadataedit/iptc/iptcproperties.cpp
M  +0    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcproperties.h
M  +4    -0    core/dplugins/generic/metadata/metadataedit/iptc/iptcstatus.cpp

https://invent.kde.org/graphics/digikam/commit/b93cd82f03330811541693c58abd1dc1a4a7f8b4
Comment 28 caulier.gilles 2022-08-08 12:04:46 UTC
Git commit 7b5474766de968ab91803c009bf8c23e78bab07e by Gilles Caulier.
Committed on 08/08/2022 at 11:40.
Pushed by cgilles into branch 'master'.

Add spell-checking to Metadata Editor with muli-strings edit properties
Code factoring
Related: bug 360954, bug 256471, bug 92310

M  +25   -14   core/dplugins/generic/metadata/metadataedit/dialog/multistringsedit.cpp
M  +1    -3    core/dplugins/generic/metadata/metadataedit/dialog/multistringsedit.h
M  +0    -17   core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.cpp
M  +0    -4    core/dplugins/generic/metadata/metadataedit/iptc/iptccontent.h
M  +0    -23   core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.cpp
M  +0    -4    core/dplugins/generic/metadata/metadataedit/iptc/iptccredits.h

https://invent.kde.org/graphics/digikam/commit/7b5474766de968ab91803c009bf8c23e78bab07e
Comment 29 caulier.gilles 2022-08-10 17:04:22 UTC
Maik,

I fixed all the places to support spell checking in text fields. All uses the KF5::Sonnet component to provide this feature on QTextEdit and QPlainTextEdit. New classes are hosted to libs/widgets/text/dtextedit.h|.cpp

One important point is the lack of support of DLineEdit for the spell-checking with KF5::Sonnet. For this purpose i created a mode to mimic DLineEdit with 2 classes based on DTextEdit and DPlainTextEdit hosted in dtextedit implementation. But it's not perfect as QValidator and QCompleter are not supported in these classes.

It still todo : 

1/ the Album Properties dialog and the Title property. This field is based on QLineEdit+QValidator to limit characters. 
2/ the tags enter text field in Image Properties sidebar view. It's a AddTagsLineEdit based on QLineEdit+QCompleter. 

1/ Can be easy to do to wrap QPlainTextEdit::textChanged() signal to a slot where characters will be filtered. It's not an universal solution as to use QValidator.

2/ I'm not sure if spell-checking + auto-completion will be compatible at run-time.

What do you think about ?

Gilles
Comment 30 Maik Qualmann 2022-08-10 18:42:30 UTC
I don't think we should replace QLineEdit that uses a QCompleter. The QCompleter popup in manual face input above the preview is quite a hack. Especially since the spell checker probably fails anyway when entering the tag and face names.

Maik
Comment 31 Maik Qualmann 2022-08-10 18:46:18 UTC
Album name input should also not have a spell checker. I've just seen a screenshot of a user using any codes for names, it would just have red lines when typing.

Maik
Comment 32 caulier.gilles 2022-08-11 14:45:48 UTC
Git commit 12b4cd0f378e6df41eeeec36f9b32cfdcb69f0a3 by Gilles Caulier.
Committed on 11/08/2022 at 14:43.
Pushed by cgilles into branch 'master'.

Add spell checking to caption settings from Print Creator plugin.
Related: bug 360954, bug 256471, bug 92310

M  +6    -1    core/dplugins/generic/tools/printcreator/ui/advprintcaptionpage.ui
M  +12   -0    core/dplugins/generic/tools/printcreator/wizard/advprintcaptionpage.cpp

https://invent.kde.org/graphics/digikam/commit/12b4cd0f378e6df41eeeec36f9b32cfdcb69f0a3
Comment 33 caulier.gilles 2022-08-11 15:16:02 UTC
Git commit 7a5d2830e3aa50f8655ed2c57f7ab2e97859ec8e by Gilles Caulier.
Committed on 11/08/2022 at 15:14.
Pushed by cgilles into branch 'master'.

add spell-checking support to HTML Gallery plugin to caption text settings
Related: bug 360954, bug 256471, bug 92310

M  +4    -0    core/dplugins/generic/tools/htmlgallery/CMakeLists.txt
M  +11   -3    core/dplugins/generic/tools/htmlgallery/generator/gallerytheme.cpp
A  +51   -0    core/dplugins/generic/tools/htmlgallery/parameters/captionthemeparameter.cpp     [License: GPL (v2+)]
A  +49   -0    core/dplugins/generic/tools/htmlgallery/parameters/captionthemeparameter.h     [License: GPL (v2+)]
M  +1    -1    core/dplugins/generic/tools/htmlgallery/themes/bluecurved/bluecurved.desktop
M  +1    -1    core/dplugins/generic/tools/htmlgallery/themes/dateframes/dateframes.desktop
M  +1    -1    core/dplugins/generic/tools/htmlgallery/themes/details/details.desktop
M  +2    -2    core/dplugins/generic/tools/htmlgallery/themes/simplerounded/simplerounded.desktop
M  +1    -1    core/dplugins/generic/tools/htmlgallery/wizard/htmloutputpage.cpp

https://invent.kde.org/graphics/digikam/commit/7a5d2830e3aa50f8655ed2c57f7ab2e97859ec8e
Comment 34 caulier.gilles 2022-08-11 23:31:23 UTC
Git commit 5043eee626e3143924637936f869f5b66dc95e2b by Gilles Caulier.
Committed on 11/08/2022 at 23:30.
Pushed by cgilles into branch 'master'.

Add spell-checking to JAlbumExport project title settings
Related: bug 360954, bug 256471, bug 92310

M  +12   -10   core/dplugins/generic/tools/jalbum/wizard/jalbumoutputpage.cpp

https://invent.kde.org/graphics/digikam/commit/5043eee626e3143924637936f869f5b66dc95e2b
Comment 35 caulier.gilles 2022-08-14 12:04:32 UTC
Git commit b8dcdabf0da6927a5633201e69becc33e92877d4 by Gilles Caulier.
Committed on 14/08/2022 at 12:02.
Pushed by cgilles into branch 'master'.

add spell-checking to album category editor
Related: bug 360954, bug 256471, bug 92310

M  +5    -4    core/utilities/setup/album/setupcategory.cpp

https://invent.kde.org/graphics/digikam/commit/b8dcdabf0da6927a5633201e69becc33e92877d4
Comment 36 caulier.gilles 2022-08-15 03:30:23 UTC
Git commit e0aede775f5d5a8b88586da6136b2cfa132ce054 by Gilles Caulier.
Committed on 15/08/2022 at 03:28.
Pushed by cgilles into branch 'master'.

Add spell-checking support in Tags Manager / tags properties view / tags title settings.
Related: bug 360954, bug 256471, bug 92310

M  +8    -5    core/libs/tags/manager/tagpropwidget.cpp
M  +8    -2    core/libs/widgets/text/dtextedit.cpp
M  +20   -4    core/libs/widgets/text/dtextedit.h

https://invent.kde.org/graphics/digikam/commit/e0aede775f5d5a8b88586da6136b2cfa132ce054
Comment 37 caulier.gilles 2022-08-17 20:01:40 UTC
Git commit 613ed81b09651aee468c6d663fa32fed2c392ca9 by Gilles Caulier.
Committed on 17/08/2022 at 19:55.
Pushed by cgilles into branch 'master'.

Spell-Checking: add settings to ignore a list of words.
Related: bug 92310, bug 200223, bug 256471, bug 360954, bug 376345

M  +1    -0    core/app/main/digikamapp.cpp
M  +1    -0    core/app/main/digikamapp_p.h
M  +10   -0    core/libs/widgets/text/dtextedit.cpp
M  +166  -11   core/libs/widgets/text/spellcheckconfig.cpp
M  +6    -2    core/libs/widgets/text/spellcheckconfig.h
M  +13   -5    core/libs/widgets/text/spellcheckcontainer.cpp
M  +3    -2    core/libs/widgets/text/spellcheckcontainer.h
M  +4    -1    core/libs/widgets/text/spellchecksettings.cpp
M  +1    -0    core/showfoto/main/showfoto.cpp
M  +1    -0    core/showfoto/main/showfoto_p.h

https://invent.kde.org/graphics/digikam/commit/613ed81b09651aee468c6d663fa32fed2c392ca9
Comment 38 caulier.gilles 2022-08-29 10:41:16 UTC
Git commit ed8140a3b3998a3854c4d874a0a8ce4ec46bc8b3 by Gilles Caulier.
Committed on 29/08/2022 at 10:38.
Pushed by cgilles into branch 'master'.

Customized Subject text edit widget (name, matter, details) use now DTextEdit with spellcheck capabilties.
Related: bug 360954, bug 256471, bug 92310

M  +1    -1    core/dplugins/generic/metadata/metadataedit/dialog/objectattributesedit.cpp
M  +3    -3    core/dplugins/generic/metadata/metadataedit/iptc/iptcsubjects.cpp
M  +7    -3    core/dplugins/generic/metadata/metadataedit/xmp/xmpsubjects.cpp
M  +3    -3    core/libs/template/subjectedit.cpp
M  +6    -6    core/libs/widgets/metadata/utils/subjectwidget.cpp
M  +5    -4    core/libs/widgets/metadata/utils/subjectwidget.h

https://invent.kde.org/graphics/digikam/commit/ed8140a3b3998a3854c4d874a0a8ce4ec46bc8b3
Comment 39 caulier.gilles 2022-08-29 11:02:46 UTC
Git commit 7f2b0ded2142657705ff2aa9a459c754b678d3d8 by Gilles Caulier.
Committed on 29/08/2022 at 11:01.
Pushed by cgilles into branch 'master'.

add spellcheck to favorite and bookmark properties dialog
Related: bug 360954, bug 256471, bug 92310

M  +1    -1    core/showfoto/folderview/showfotofolderviewbar.cpp
M  +6    -4    core/showfoto/folderview/showfotofolderviewbookmarkdlg.cpp
M  +11   -8    core/showfoto/stackview/showfotostackviewfavoriteitemdlg.cpp

https://invent.kde.org/graphics/digikam/commit/7f2b0ded2142657705ff2aa9a459c754b678d3d8
Comment 40 caulier.gilles 2022-08-29 11:56:56 UTC
Git commit 9d270f0800726d1984fb8acee2daabe3998214c1 by Gilles Caulier.
Committed on 29/08/2022 at 11:55.
Pushed by cgilles into branch 'master'.

add spellcheck support in all title/description/name properties edit widget
Related: bug 360954, bug 256471, bug 92310

M  +5    -4    core/app/views/sidebar/timelinesidebarwidget.cpp
M  +1    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptccategories.cpp
M  +1    -1    core/dplugins/generic/metadata/metadataedit/iptc/iptcenvelope.cpp
M  +8    -11   core/dplugins/generic/webservices/flickr/flickrlist.cpp
M  +2    -1    core/dplugins/generic/webservices/flickr/flickrwidget.cpp
M  +2    -1    core/dplugins/generic/webservices/flickr/flickrwidget_p.h
M  +1    -1    core/dplugins/generic/webservices/flickr/flickrwindow.cpp
M  +4    -2    core/dplugins/generic/webservices/imageshack/imageshackwidget.cpp
M  +2    -1    core/dplugins/generic/webservices/imageshack/imageshackwidget_p.h
M  +4    -3    core/dplugins/generic/webservices/mediawiki/mediawikiwidget.cpp
M  +3    -3    core/libs/dplugins/webservices/wsnewalbumdialog.cpp
M  +1    -1    core/libs/dplugins/webservices/wsnewalbumdialog.h
M  +1    -1    core/utilities/advancedrename/parser/modifiers/defaultvaluemodifier.cpp
M  +3    -2    core/utilities/fuzzysearch/fuzzysearchview_p.h
M  +2    -2    core/utilities/fuzzysearch/fuzzysearchview_similar.cpp
M  +2    -2    core/utilities/fuzzysearch/fuzzysearchview_sketch.cpp
M  +7    -4    core/utilities/geolocation/geoiface/bookmark/bookmarksdlg.cpp
M  +5    -4    core/utilities/geolocation/mapsearches/gpssearchview.cpp
M  +16   -18   core/utilities/queuemanager/views/workflowdlg.cpp
M  +1    -1    core/utilities/queuemanager/views/workflowdlg.h
M  +4    -2    core/utilities/setup/camera/cameraselection.cpp
M  +4    -2    core/utilities/setup/camera/importfilterdlg.cpp
M  +3    -3    core/utilities/setup/collections/setupcollectionview.cpp
M  +4    -4    core/utilities/setup/setuptemplate.cpp

https://invent.kde.org/graphics/digikam/commit/9d270f0800726d1984fb8acee2daabe3998214c1