Bug 200223 - default language of spellchecker is ignored
Summary: default language of spellchecker is ignored
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-SpellCheck (show other bugs)
Version: 0.10.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 21:11 UTC by entwanzer
Modified: 2022-08-17 20:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0


Attachments
Screenshot of Country/Region Dialogue (76.27 KB, image/png)
2009-07-15 17:51 UTC, entwanzer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description entwanzer 2009-07-14 21:11:03 UTC
Version:           0.10.0 (using KDE 4.2.4)
OS:                Linux
Installed from:    Fedora RPMs

when entering a caption, the text is automatically spell checked. In my KDE settings (system settings -> Country/Region and Language) the default language for spell checking is German (Germany) but digkikam checks for the English language.
Comment 1 Mikolaj Machowski 2009-07-14 22:15:50 UTC
What is language of your interface (locale)?
Comment 2 entwanzer 2009-07-15 17:50:47 UTC
the interface (Menus, Buttons, etc.) is English.
But the setting in System Settings -> Country/Region & Language -> Locale -> Country or region is "Germany". The field "Languages:" is empty
Comment 3 entwanzer 2009-07-15 17:51:40 UTC
Created attachment 35357 [details]
Screenshot of Country/Region Dialogue
Comment 4 caulier.gilles 2009-07-16 04:49:18 UTC
Please, can you test with current code from svn trunk (1.0.0-beta3).

Code is changed indeep everywhere here, and a lots of new features have been
added, especially multiple language comments support.

http://farm4.static.flickr.com/3499/3724445487_ef34588e49_o.png

With this feature, spellchecker is set accordingly with caption language.

Gilles Caulier
Comment 5 Andi Clemens 2009-07-16 09:32:10 UTC
The spellchecker has nothing to do at all with digiKam. If it is not working for you in digiKam, it shouldn't work in other applications either.
I just tried it and it works fine here, with digiKam 0.10 and 1-0.0-SVN.
Comment 6 Andi Clemens 2009-07-16 09:35:51 UTC
Oh my mistake :D
I checked the versions that have either no multiple language support or where already fixed :)

So like Gilles mentioned, try to use the latest SVN code.
Comment 7 entwanzer 2009-07-17 16:06:23 UTC
(In reply to comment #4)
> Please, can you test with current code from svn trunk (1.0.0-beta3).

sorry, I tried to compile the current code form svn but there are too many missing dependencies. I can't get it to compile. I'll have to wait for a rpm from my distro.
Comment 8 Mikolaj Machowski 2009-07-17 22:07:36 UTC
Using todays SVN trunk: WORKSFORME.
Comment 9 caulier.gilles 2009-07-17 22:14:56 UTC
Thanks Mik to test. closed

Gilles Caulier
Comment 10 caulier.gilles 2022-08-16 20:37:33 UTC
With next 8.0.0 release, we will use KF5::Sonnet SpellChecker to perform spell error detection and provide correction.

It will be available everywhere in digiKam where users needs to enter a text (aka captions, titles, etc.)

The language will be automatically detected by powerful algorithms by parsing words entered in text widgets.
If a text widget as a specific language property as XMP alternative languages strings, the selected language by user will be used to check words.

It's explained in the new setup/Miscs/SpellCheck config panel, as rhe spellchecking in digiKam and Showfoto will not depend of KDE/Plasma desktop (after all, we work under Windows, MacOS, and other Linux desktops...)

https://i.imgur.com/HI6wZ86.png
 
Gilles Caulier
Comment 11 caulier.gilles 2022-08-17 03:09:10 UTC
Git commit fb9bc61ea2cc4d5045d7adde54d3b03bc59e888f by Gilles Caulier.
Committed on 17/08/2022 at 02:59.
Pushed by cgilles into branch 'master'.

If user change a current language from an alternative language text edit widget,
and if the language is not "x-default", force spell-checker to use this language as well.

If user change a current language from an alternative language text edit widget to "x-default",
turn on the auto-detection of language in spell-checker.

Note: By default, an alternative language text edit widget always use the auto-detection of language in spell-checker.
Related: bug 376345

M  +5    -1    core/libs/widgets/metadata/utils/altlangstredit.cpp
M  +56   -10   core/libs/widgets/text/dtextedit.cpp
M  +2    -0    core/libs/widgets/text/dtextedit.h
M  +2    -2    core/libs/widgets/text/spellcheckconfig.cpp
M  +5    -5    core/libs/widgets/text/spellcheckcontainer.cpp
M  +2    -1    core/libs/widgets/text/spellcheckcontainer.h

https://invent.kde.org/graphics/digikam/commit/fb9bc61ea2cc4d5045d7adde54d3b03bc59e888f
Comment 12 caulier.gilles 2022-08-17 20:01:47 UTC
Git commit 613ed81b09651aee468c6d663fa32fed2c392ca9 by Gilles Caulier.
Committed on 17/08/2022 at 19:55.
Pushed by cgilles into branch 'master'.

Spell-Checking: add settings to ignore a list of words.
Related: bug 92310, bug 256471, bug 360954, bug 376345, bug 402922

M  +1    -0    core/app/main/digikamapp.cpp
M  +1    -0    core/app/main/digikamapp_p.h
M  +10   -0    core/libs/widgets/text/dtextedit.cpp
M  +166  -11   core/libs/widgets/text/spellcheckconfig.cpp
M  +6    -2    core/libs/widgets/text/spellcheckconfig.h
M  +13   -5    core/libs/widgets/text/spellcheckcontainer.cpp
M  +3    -2    core/libs/widgets/text/spellcheckcontainer.h
M  +4    -1    core/libs/widgets/text/spellchecksettings.cpp
M  +1    -0    core/showfoto/main/showfoto.cpp
M  +1    -0    core/showfoto/main/showfoto_p.h

https://invent.kde.org/graphics/digikam/commit/613ed81b09651aee468c6d663fa32fed2c392ca9