Bug 401634 - Brush Disappears from Presets Filtered by a Tag After Override Brush
Summary: Brush Disappears from Presets Filtered by a Tag After Override Brush
Status: RESOLVED DUPLICATE of bug 391025
Alias: None
Product: krita
Classification: Applications
Component: Tagging (show other bugs)
Version: 4.1.5
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
: 412812 413860 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-02 01:40 UTC by Kenneth Evans
Modified: 2020-03-13 10:43 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Evans 2018-12-02 01:40:57 UTC
SUMMARY
I have made a variant of a brush, (f) Bristles-3 Large Smooth, that has Texture.  I have assigned two tags, KE and Oil.  It appears in the Brush Panel with the presets showing and tags filtered to Oil.  If I change a parameter, e.g. Size, and do Overwrite Brush, then it no longer appears in the presets with the tag filter still set to Oil.  If I set the tag filter to All, then I see the brush, and it has both tags.  I cannot find a way to get it to appear with filter set to Oil, other than by restarting.

I have reproduced this twice, restarting Krita in between.

STEPS TO REPRODUCE
1. Make a variant of a brush, tag it, and save it.
2. Change a parameter and do Override Brush.
3. 

OBSERVED RESULT
Disappears from presets filtered by the tag where it appeared before the Override but still has the tag.

EXPECTED RESULT
Stays in the presets filtered by the tag where it appeared before the Override.
Comment 1 Kenneth Evans 2018-12-02 01:50:11 UTC
I restarted Krita once again.  The brush did not appear with the filter set to Oil.  On setting it to All, it did not have the tags set (as it did when I exited).  I set them and exited Krita again without doing anything else.  On restarting Krita, it appears to be working Ok; that is, the brush has the tags assigned and appears when the tag filter is set to one of them.

I haven't tried Override brush again.
Comment 2 mvowada 2018-12-02 16:54:18 UTC
(Krita 4.2.0-pre-alpha (git 4fb7b5b) - Ubuntu 14.04, Unity)

Hi, I've followed these steps without success:

    1. fresh configs
    2. created tags "KE" and "Oil"
    3. created a a copy of "(f) Bristles-3 Large Smooth"
    4. assigned the copy to tags "KE" and "Oil"
    5. toolbar > "Choose brush preset" > filtered by "Oil"
    6. "Brush presets" docker > filtered by "Oil"
    7. toolbar > "Edit brush settings" > "Brush tip" > changed the "Size"
    8. toolbar > "Edit brush settings" > "Overwrite Brush"

Actual Results: the overwritten preset remains listed under both "Oil" and "KE" tag. It does not disappear in my case.
Comment 3 Kenneth Evans 2018-12-02 20:56:05 UTC
(I wasn't imagining it.)

I tried what you did, keeping notes on just what happened.

Per my second message, I had got the brush apparently straightened out yesterday by restarting Krita a few times and doing nothing but look at the brush.  (I did open an image.)

These are the steps I took today.

1. Restarted Krita again, and opened the image.
2. Verified new brush is tagged as Oil.  (I am only using the Brush Panel, not a Docker for now.  I am also forgetting about the KE tag for now.)
3. For f) Bristles-3 Large Smooth I again added a texture.  The texture I am using is from Digital Atelier (DA_Oil_Primed DMF cotten mid.png), which means it is in a bundle, not loose in the file system.
4. I saved it as a new brush.
5. I tagged it as Oil, and it appeared when filtered by Oil.
6. I then tested it.  It did not have texture, even though I had checked the Pattern checkbox.  (You can't, in fact, pick a pattern unless it is checked.)
7. I went back to the Brush Panel and checked Pattern again.  (It remembered the pattern used, just not the checkbox.)
8. I tested it, and it did now have a pattern.
9. I did Overwrite Brush.
10. It remained under the brushes filtered by Oil.
11. I changed the tip size, and tested again.  (The tip size changed.)
12. I did Overwrite Brush again.
13. It remained under the brushes filtered by Oil.

So I am not reproducing it myself at the moment.  I have done nothing else except the few test strokes.  It did not handle the pattern correctly, but is not having the tag problem.

I was also having trouble yesterday with the pattern properties page working correctly.  (And I have also had problems in the past.)  I did not document these problems carefully enough to submit an issue.  Even though the pattern properties behavior would be a separate issue, it may be this behavior that is causing the behavior with the tags.  I don't normally have problems with tags for brushes.

In any event it seems to be intermittent.
Comment 4 Kenneth Evans 2018-12-02 22:22:53 UTC
Later: It happened again.

I continued working from where I left off above.  I changed the pattern in the new brush, did Overwrite Brush, and it behaved ok.  This pattern was imported from the file system, not from the Digital Atelier patterns.

I then changed the pattern in the brush I was using yesterday to the same pattern, did Overwrite brush, and it disappeared from the brushes filtered by Oil (where it was when I changed the texture, and where it has been since I thought I got it straightened out).  So this brush is clobbered somehow.

I can, of course, delete all the brushes I recently created from f) Bristles-3 Large Smooth, clean out the kis_paintoppresets.blacklist, and start over, but I will leave it for now in case you have some suggestions to try to track this down.

The problem does seem to be happening somewhat reproducibly with this brush.
Comment 5 Kenneth Evans 2018-12-02 22:50:32 UTC
Just for the record.  I added another pattern from the file system.  The one just previously added was not the one I thought it was, so I deleted it via the trash can icon in the Pattern properties.  Krita crashed.

On restart, the deleted pattern was not there. However the original problem brush has a name like f)_Bristles-3_Large_Smooth_Texture(f)_Bristles-3_Large_Smooth_Texture_backup_2018-12-02-173620.kpp) and the new test brush has a name like f)_Bristles-3_Large_Smooth_Test(f)_Bristles-3_Large_Smooth_Test_backup_2018-12-02-170756.kpp).

So it is all screwed up.

I want to use this brush and don't want it causing other problems, so I am going to try to clean it up as I said and start over, rather than waiting for your response.  Given you are on another platform and using a different version of Krita, I don't see much prospect for anything useful happening in any event.  Sorry.
Comment 6 wolthera 2019-04-08 16:02:37 UTC
resource issue, will probably be fixed by the resource management rewrite.
Comment 7 grzegorzpedrycz 2019-05-21 16:53:51 UTC
Issue with tag disappear after overwrite brush still appear in Krita 4.2
Comment 8 Eri 2019-07-07 05:27:59 UTC
I was just about to report this exact issue. I have this exact same problem. I'm not sure if I should make a report for 4.2.2 since this is the version I was using.
In order to create a convenient environment, I like to make use of the tagging system and create a custom tag for all my most frequently used brush presets, as well as duplicate and customize my own brushes presets.

1. I would select an existing brush preset, and change the parameters. In this case, I modified the settings of Basic 5 size, and did "Save as new preset" and named it Basic 5 custom. The box at the bottom of the brush options is normally checked, "Temporarily save tweaks to presets" but I have found that this is irrelevant to the bug.
2. I would add it to a new tag that I simply called "use"
3. I save and restart Krita
4. I open a new canvas, and select the custom brush preset. I tweak the settings a bit, and hit "overwrite brush". 

Result: At this point the brush preset disappears from every tag, and will only show up in the All tag, and can't be added or re-added to any tag until Krita is restarted.

I also attempted to save a new brush custom off of my existing brush custom preset; I saved it as a new brush preset called Basic 5 custom2. Whenever I try to modify and save this brush, it will display the same behavior and remove itself from all tags, as well as occasionally renaming itself to a very long backup file string it looks like. Inconsistent.

(Modification in this context meaning, changing any settings or sliders and saving)

From the looks of it, it only seems to affect a small minority of users, but for folks like myself who frequently experiment with brush settings, it can be very disruptive.
I am using a fresh new 4.2.2 install, but this was a problem on all older versions I had used before.
Comment 9 wolthera 2019-10-10 13:10:15 UTC
*** Bug 412812 has been marked as a duplicate of this bug. ***
Comment 10 vanyossi 2019-11-06 02:29:34 UTC
*** Bug 413860 has been marked as a duplicate of this bug. ***
Comment 11 Tiar 2020-03-13 10:43:23 UTC

*** This bug has been marked as a duplicate of bug 391025 ***