Bug 401489 - New icon request: "trim margins" and "trim to selection"
Summary: New icon request: "trim margins" and "trim to selection"
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks: 397768
  Show dependency treegraph
 
Reported: 2018-11-27 23:06 UTC by Nate Graham
Modified: 2019-01-26 17:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.55


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-11-27 23:06:06 UTC
Okular has two menu items that need icons: "trim margins" and "trim to selection". See Bug 397768.

"Trim Margins" automatically trims off the empty whitespace around a document.

"Trim to selection" does the same thing, but for a user-specified selection.

Currently these menu items do not have icons because there isn't anything appropriate in the Breeze icon theme. `ratiocrop` probably comes the closest, but doesn't really communicate the point as well as it could. Also there's only one of it and we try not to use the same icons for two different menu items

We need distinct, custom-made Breeze icons for these tools.
Comment 1 Nate Graham 2019-01-26 17:21:44 UTC
Git commit 8b412d0fc4be98464fa6aee1d9339cee138ec2ca by Nate Graham, on behalf of Rafael Brandmaier.
Committed on 26/01/2019 at 17:11.
Pushed by ngraham into branch 'master'.

Add trim margins and trim to selection icons

Summary:

FIXED-IN: 5.55

Add `trim-margins` and `trim-to-selection` action icons.

Test Plan:
{F6569208}
With Breeze-dark theme:
{F6569209}

Reviewers: #vdg, ngraham, ndavis

Reviewed By: #vdg, ngraham, ndavis

Subscribers: ndavis, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18552

A  +1    -0    icons-dark/actions/16/trim-margins.svg
A  +1    -0    icons-dark/actions/16/trim-to-selection.svg
A  +1    -0    icons-dark/actions/22/trim-margins.svg
A  +1    -0    icons-dark/actions/22/trim-to-selection.svg
A  +1    -0    icons-dark/actions/24/trim-margins.svg
A  +1    -0    icons-dark/actions/24/trim-to-selection.svg
A  +1    -0    icons-dark/actions/32/trim-margins.svg
A  +1    -0    icons-dark/actions/32/trim-to-selection.svg
A  +1    -0    icons/actions/16/trim-margins.svg
A  +1    -0    icons/actions/16/trim-to-selection.svg
A  +1    -0    icons/actions/22/trim-margins.svg
A  +1    -0    icons/actions/22/trim-to-selection.svg
A  +1    -0    icons/actions/24/trim-margins.svg
A  +1    -0    icons/actions/24/trim-to-selection.svg
A  +1    -0    icons/actions/32/trim-margins.svg
A  +1    -0    icons/actions/32/trim-to-selection.svg

https://commits.kde.org/breeze-icons/8b412d0fc4be98464fa6aee1d9339cee138ec2ca