Bug 397768 - "Trim" menu items need appropriate icons
Summary: "Trim" menu items need appropriate icons
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.5.0
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
Depends on: 401489
  Show dependency treegraph
Reported: 2018-08-23 03:11 UTC by Clinton
Modified: 2019-01-26 20:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.04.0


Note You need to log in before you can comment on or make changes to this bug.
Description Clinton 2018-08-23 03:11:54 UTC
Using Okular as my primary ebook reader, I am constantly applying the "Trim to margins" feature to decrease useless whitespace.

I suggest assigning the very intuitive "ratiocrop" (or "transform-crop") icon as default to this entry when made a toolbar button.
Comment 1 Nate Graham 2018-08-31 23:17:38 UTC
Submitted a patch for this: https://phabricator.kde.org/D15193
Comment 2 Nate Graham 2018-11-27 23:07:31 UTC
After review, it became clear that we need new icons before we can do this. See Bug 401489.
Comment 3 Nate Graham 2019-01-26 20:57:37 UTC
Git commit 259961f6d18fde46d0faf57b18a482324e888a24 by Nate Graham.
Committed on 26/01/2019 at 20:57.
Pushed by ngraham into branch 'master'.

Add icons for the Trim Margins tools

New icons were added in D18552.
FIXED-IN: 19.04.0

Test Plan: {F6569231, size=full}

Reviewers: #okular, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, trickyricky26, aacid, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D15193

M  +2    -2    ui/pageview.cpp