SUMMARY Icon picker is not responsive during icon loading. STEPS TO REPRODUCE 1. Open icon picker (from KDE Menu Editor or Dolphin’s properties window) 2. Try to close the window when OBSERVED RESULT It closes as soon as it has finished loading. EXPECTED RESULT It should closes as soon as alt-f4/window cross/close button is pressed. SOFTWARE/OS VERSIONS Arch Linux KDE Plasma Version: 5.14.3 KDE Frameworks Version: 5.52.0 Qt Version: 5.12.0
Git commit ed30c6c5bad397444f78a70f89b2f4aec152466c by Kai Uwe Broulik. Committed on 05/07/2021 at 11:43. Pushed by broulik into branch 'master'. [KIconDialog] Revamp UI This modernizes the UI of KIconDialog that hasn't changed since childhood. The code is overall tidied up and layout moved into a `.ui` file. The default size is changed from 4x4 to 6x3 to accommodate more widescreen monitors and the grid allows for three lines of text since many icon names are longer than just one line. Furthermore, the stark separation between "system" and "user" icons is lifted, and instead the "Browse..." button is always accessible and "Other" is just another item in the "context" combo box. Also, a "No icons" placeholder is shown when there are no icons in the given category or because of the search term input. Finally, the icons are now loaded on demand as the view scrolls along rather than loading all thousands of them at once with a slow progress bar. Related: bug 388807 M +4 -0 src/CMakeLists.txt M +340 -362 src/kicondialog.cpp M +1 -9 src/kicondialog.h A +88 -0 src/kicondialog.ui M +27 -109 src/kicondialog_p.h A +55 -0 src/kicondialogmodel_p.h [License: LGPL(v2.0+)] https://invent.kde.org/frameworks/kiconthemes/commit/ed30c6c5bad397444f78a70f89b2f4aec152466c