Bug 388807 - Choose icon dialog: distant of widgets is too high when dialog is wide
Summary: Choose icon dialog: distant of widgets is too high when dialog is wide
Alias: None
Product: frameworks-kiconthemes
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Christoph Feck
Depends on:
Reported: 2018-01-11 14:08 UTC by Gregor Mi
Modified: 2021-07-08 00:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.85

choose icon dialog (34.41 KB, image/png)
2018-01-11 14:08 UTC, Gregor Mi

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2018-01-11 14:08:16 UTC
Created attachment 109794 [details]
choose icon dialog

See the attached screenshot: The distance between the widgets in the top group box is too high. At first glance it is hard to recognise these widgets as belonging together.
Comment 1 Nate Graham 2018-01-12 20:51:24 UTC
Only when you make the window really really wide though, right?
Comment 2 Gregor Mi 2018-01-12 22:06:35 UTC
(In reply to Nate Graham from comment #1)
> Only when you make the window really really wide though, right?

Yes. I stumbled over it like this: 1) Open the icon chooser, 2) make it wider to see more icons, 3) realized that there are options at the top to show other icons, 4) being confused why the distance between corresponding elements is so high.
Comment 3 Nate Graham 2018-01-12 22:09:06 UTC
This is sort of a hard one, because if we make the comboboxes stay with the text when the window is resized, it'll look really weird to have a ton of whitespace between them and the right edge of the window.
Comment 4 Gregor Mi 2018-01-12 22:26:12 UTC
As it is now, you have the amount of whitespace in between, and in the middle a heading over this whitespace. :)

Why not right align the contents of top groupbox and maybe also do not expand up to the right side? Or put everything in one row.
Comment 5 Bug Janitor Service 2021-06-24 19:53:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/34
Comment 6 Kai Uwe Broulik 2021-07-05 11:43:58 UTC
Git commit ed30c6c5bad397444f78a70f89b2f4aec152466c by Kai Uwe Broulik.
Committed on 05/07/2021 at 11:43.
Pushed by broulik into branch 'master'.

[KIconDialog] Revamp UI

This modernizes the UI of KIconDialog that hasn't changed since childhood.
The code is overall tidied up and layout moved into a `.ui` file.

The default size is changed from 4x4 to 6x3 to accommodate more widescreen
monitors and the grid allows for three lines of text since many icon names
are longer than just one line.

Furthermore, the stark separation between "system" and "user" icons is lifted,
and instead the "Browse..." button is always accessible and "Other" is just
another item in the "context" combo box.

Also, a "No icons" placeholder is shown when there are no icons in the
given category or because of the search term input.

Finally, the icons are now loaded on demand as the view scrolls along rather
than loading all thousands of them at once with a slow progress bar.
Related: bug 401408

M  +4    -0    src/CMakeLists.txt
M  +340  -362  src/kicondialog.cpp
M  +1    -9    src/kicondialog.h
A  +88   -0    src/kicondialog.ui
M  +27   -109  src/kicondialog_p.h
A  +55   -0    src/kicondialogmodel_p.h     [License: LGPL(v2.0+)]