Bug 399159 - Lenses name lost on converting to DNG
Summary: Lenses name lost on converting to DNG
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Import-PostProcessing (show other bugs)
Version: 5.9.0
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-27 21:18 UTC by Rafael Linux User
Modified: 2019-12-28 18:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments
Incorrect lenses name content (675.45 KB, image/png)
2018-09-27 21:18 UTC, Rafael Linux User
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Linux User 2018-09-27 21:18:15 UTC
Created attachment 115276 [details]
Incorrect lenses name content

SUMMARY
Import + conversion to DNG lost lenses name.

STEPS TO REPRODUCE
1. Open Import window and select RAW files (in my case, Lumix GX8 files)
2. Show "Preferences" panel on right side 
3. Enable "Convert RAW images to DNG container"
4. Enable "Incorporate original file"
5. Enable "Losless compression"
6. Click "Download" button
7. Compare original RAW file properties with the DNG one

OBSERVED RESULT
Lenses name doesn't match between original RAW and converted DNG file

EXPECTED RESULT
Lenses name should be exact the same.
Comment 1 Maik Qualmann 2018-09-28 06:33:02 UTC
After a quick analysis, I pinpoint the problem in the Adobe DNG-SDK. With my RAW files from Nikon everything is OK, but with a test sample from the Panasonic camera, I can confirm the problem and there are more fields wrong. Gilles, I think we need to update the SDK.

Maik
Comment 2 Rafael Linux User 2018-09-28 08:21:05 UTC
Thank you Maik. I'll carry over DNG conversion till it's fixed.
Comment 3 caulier.gilles 2018-09-28 08:58:13 UTC
Maik,

to update the DNG SDK from Adode, this require also to update the XMP SDK from Adobe.

I already tried to do it in the past, with 5.x release, and... it fail due to incompatibility between both SDK (Adobe is magic)...

We can try again, in hope that Adobe has fixed the problem. 

Gilles
Comment 4 Maik Qualmann 2018-09-28 11:00:53 UTC
I think updating the DNG-SDK will not help us. Exiv2 reported an error reading the maker notes. Presumably, the data in the QByteArray is wrong. We have the copy of the maker notes for Canon disabled, I would then suggest it for Panasonic at the moment. And wait and see what changes with Exiv2-0.27.

Maik
Comment 5 caulier.gilles 2018-09-28 11:17:16 UTC
As i know, Exiv2 0.27-RC will out next week-end

Gilles
Comment 6 Maik Qualmann 2018-09-28 11:19:41 UTC
I had already tried to compile it with digiKam, but there are probably API changes.

Maik
Comment 7 caulier.gilles 2018-09-28 11:20:52 UTC
Exiv2 0.27 ? I compiled digiKam with it 2 week ago without problem...

I will take a look this week end.

Gilles
Comment 8 Maik Qualmann 2018-09-28 12:01:26 UTC
Yes, 15 days ago, for example, the change Exiv2::version() no longer existed, now versionNumber() and versionString(). But it was even more.

Maik
Comment 9 Maik Qualmann 2018-09-28 16:30:44 UTC
Git commit a057c1535993b941e376d977826b456f1337444e by Maik Qualmann.
Committed on 28/09/2018 at 16:29.
Pushed by mqualmann into branch 'master'.

do not copy the makernote from Panasonic

M  +2    -1    core/libs/dngwriter/dngwriter.cpp

https://commits.kde.org/digikam/a057c1535993b941e376d977826b456f1337444e
Comment 10 Maik Qualmann 2018-09-28 16:34:46 UTC
With this patch, you not have a makernote in the image, but correct lens data, because we read and copy and these are stored in XMP. We look to Exiv2-0.27RC.

Maik
Comment 11 Rafael Linux User 2018-09-28 19:02:34 UTC
I don't know what's the markernote for, but it seems the important info will be preserved in the DNG. I guess the patch is for version 6, it is not?

Thank you
Comment 12 Maik Qualmann 2018-10-10 19:22:35 UTC
This issue will not be resolved with Exiv2-0.27 at this time, so we will continue to ignore makernote from Pansonics.

Maik
Comment 13 Rafael Linux User 2018-10-11 08:08:47 UTC
:( well, meanwhile I'll forgot to convert to DNG my RAW files ...
Comment 14 Maik Qualmann 2019-05-14 20:15:28 UTC
*** Bug 407540 has been marked as a duplicate of this bug. ***
Comment 15 caulier.gilles 2019-12-24 14:18:58 UTC
digiKam 7.0.0-beta1 is out :

https://download.kde.org/unstable/digikam/

This problem still reproducible with this version which include Libraw engine
version 0.20.0 ?

Thanks in advance and merry Christmas
Comment 16 Dirk 2019-12-28 18:28:55 UTC
... I have tested with 7.0.0 today and did not find problems anymore.

Thanks!!!

Am 24.12.2019 um 15:18 schrieb bugzilla_noreply@kde.org:
> https://bugs.kde.org/show_bug.cgi?id=399159
>
> --- Comment #15 from caulier.gilles@gmail.com ---
> digiKam 7.0.0-beta1 is out :
>
> https://download.kde.org/unstable/digikam/
>
> This problem still reproducible with this version which include Libraw engine
> version 0.20.0 ?
>
> Thanks in advance and merry Christmas
>
Comment 17 caulier.gilles 2019-12-28 18:32:08 UTC
Thanks for the feedback and happy new year

Gilles Caulier