Bug 397595 - Window Decorations are not properly highlighting the selected theme
Summary: Window Decorations are not properly highlighting the selected theme
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 5.13.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-18 18:46 UTC by isalliswell
Modified: 2020-02-21 14:31 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.2


Attachments
screenshot taken on neon dev unstable (3.01 MB, image/png)
2019-03-18 18:15 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description isalliswell 2018-08-18 18:46:13 UTC
Say I am using Breeze then when I go to: 

System Settings->Application Style->Window Decorations

it should highlight the selected theme to improve the User experience.
See the below screenshot:

https://i.imgur.com/wFUvhwy.png 


Second thing sometimes it asks me to Apply settings every time I switch to the Window Decorations tab even without selecting/changing any theme.
Comment 1 Nate Graham 2018-08-21 20:39:58 UTC
Quite true. When the KCM is rewritten, this problem will be solved automatically.

> Second thing
One issue per bug report please! :) See https://community.kde.org/Get_Involved/Bug_Reporting#One_issue_per_bug_report
Comment 2 Patrick Silva 2018-08-23 18:59:30 UTC
second thing already reported as bug 381806
Comment 3 Valerio Pilo 2019-01-03 18:08:15 UTC
Fixed by commit ef1692eea6912c7a70773901bcfd91fb70d0b8cf in kwin:

[kcmkwin/kwindecoration] Set current decoration index on start

Summary:
Fixes the preselected decoration style on module load.

Also:
* Prevent the module state to be set to modified on resize.
* Fix QML errors in logs.

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D17775
Comment 4 Nate Graham 2019-01-07 02:45:40 UTC
That commit doesn't fully fix the issue for me. The active decoration theme is correctly selected when opening the KCM standalone in `kcmshell5`, but not from within System Settings itself.
Comment 5 Nate Graham 2019-02-11 17:25:07 UTC
author	Valerio Pilo <vpilo@coldshock.net>	2019-02-07 16:32:05 +0100
committer	Valerio Pilo <vpilo@coldshock.net>	2019-02-10 13:01:04 +0100
commit	8350c0f2ce666e60ad468a0f2fdce6086d2210f2 (patch)
tree	c5eb4d45b0ff004111b32afeaca8cfd790ab09c9
parent	698b40dbbde327a6824c2c6495201a27b34bc4a2 (diff)
[kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModuleHEADmaster
Summary:
* Wrote new KCM based on KQuickAddons::ConfigModule.
* Remade QMLs for Buttons and Themes tabs.
* Updated bridge model code for new plugin lookup API (fixes warnings).
* Fixed decoration shadow changing messing with the previews sizes.
* Fixed button drag and drop issues (see D18104).
* Fixed default settings button behavior and detection of settings changes.
* Updated Get Hot New Stuff.
* Removed apply button in previewbridge.cpp: After applying changes, a theme's KCModule is invalidated.

BUG: 389431
BUG: 350122
BUG: 346222
BUG: 342816
BUG: 397595

{F6574963} | {F6574962} | {F6574961} | {F6574960}

Test Plan:
* Verified saving and loading for every setting
* Checked shadows of Breeze and Oxygen
* Tested all possible drag&drop operations on both sides of the fake titlebar
* Changed color schemes (with `kcmshell5 colors`) while showing the Themes tab to see if all previews update correctly their palettes
* Tested on a fresh Neon-developer account, via kcmshell and systemsettings

Reviewers: #vdg, abetts, ngraham, #kwin, davidedmundson

Reviewed By: #vdg, #kwin, davidedmundson

Subscribers: zzag, GB_2, ngraham, broulik, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18458
Comment 6 Patrick Silva 2019-03-18 18:15:55 UTC
Created attachment 118895 [details]
screenshot taken on neon dev unstable

This bug persists with the new kcm on neon dev unstable.

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.0
Comment 7 Nate Graham 2019-03-18 22:28:35 UTC
Can confirm. :(

Valerio, any ideas?
Comment 8 Patrick Silva 2019-05-17 15:10:29 UTC
plasma 5.16 beta has the same bug.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.90
KDE Frameworks Version: 5.58.0
Qt Version: 5.13.0 beta3
Comment 9 Patrick Silva 2020-02-05 19:32:44 UTC
This issue persists on Plasma 5.18 beta. I can reproduce switching between Breeze and Breeze dark global themes.

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.1
Comment 10 Cyril Rossi 2020-02-18 13:44:30 UTC
Can reproduce here.

When I apply Breeze or Breeze Dark theme in the KCM Look and Feel, it writes a `theme=` with no value in kwinrc, then the KCM KWin Decoration can not highlight Breeze theme.
Comment 11 Cyril Rossi 2020-02-21 09:12:51 UTC
Git commit 6d3d3ffa76a5125da843fe6f58a684bdba6e6d26 by Cyril Rossi.
Committed on 21/02/2020 at 09:08.
Pushed by crossi into branch 'master'.

KCM look and feel : set proper default values for kwin kdecoration when applying global style

Summary: BUG: 397595

Test Plan:
KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid.
In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value.

With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted.

Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27483

M  +3    -3    kcms/lookandfeel/kcm.cpp

https://commits.kde.org/plasma-desktop/6d3d3ffa76a5125da843fe6f58a684bdba6e6d26
Comment 12 Nate Graham 2020-02-21 13:57:01 UTC
This should also be on the Plasma/5.18 branch. :) Can you cherry-pick it?
Comment 13 Cyril Rossi 2020-02-21 14:29:40 UTC
Git commit 56fd983308d1e86d63db9d566dabd0967df91133 by Cyril Rossi.
Committed on 21/02/2020 at 14:21.
Pushed by crossi into branch 'Plasma/5.18'.

KCM look and feel : set proper default values for kwin kdecoration when applying global style

Summary: BUG: 397595

Test Plan:
KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid.
In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value.

With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted.

Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27483

(cherry picked from commit 6d3d3ffa76a5125da843fe6f58a684bdba6e6d26)

M  +3    -3    kcms/lookandfeel/kcm.cpp

https://commits.kde.org/plasma-desktop/56fd983308d1e86d63db9d566dabd0967df91133
Comment 14 Nate Graham 2020-02-21 14:31:19 UTC
Thanks!