Bug 381806 - Window Decorations KCM pop up even there is no change
Summary: Window Decorations KCM pop up even there is no change
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.13.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 379868 395154 395511 395775 396077 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-29 18:15 UTC by Xu Zhao
Modified: 2019-01-03 18:07 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Popup window even nothing is changed in Window Decoration (461.93 KB, image/png)
2017-06-29 18:15 UTC, Xu Zhao
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xu Zhao 2017-06-29 18:15:27 UTC
Created attachment 106375 [details]
Popup window even nothing is changed in Window Decoration

How to reproduce it:
1. Open system settings -> Application Style 
2. Open tab: Window Decorations
3. Do nothing, wait ~1sec
4. Click "Widget Style" tab
5. Popup window appear: "The settings of current module have changed. Do you want to apply the changes or discard them?"

Desired behavior:
There is no popup window.
This is because I am not changing the window decoration, it does not need to inform me to apply/discard changes, since there is no change at all.
Comment 1 Patrick Silva 2017-06-30 14:50:58 UTC
My bug report about this issue
https://bugs.kde.org/show_bug.cgi?id=379868
Comment 2 Martin Flöser 2017-06-30 18:45:43 UTC
*** Bug 379868 has been marked as a duplicate of this bug. ***
Comment 3 Patrick Silva 2017-09-27 15:36:19 UTC
Still happening on neon dev unstable.
Comment 4 Rik Mills 2017-11-21 21:45:24 UTC
Also seen in Neon and Kubuntu, Plasma 5.11.3
Comment 5 Patrick Silva 2018-01-16 22:08:23 UTC
Same bug in plasma 5.12 beta, Arch Linux.
Comment 6 Patrick Silva 2018-01-20 13:47:02 UTC
Sometimes if I click "discard" and open another kcm in sequence, Wayland session freezes and 1 minute later my system goes to login screen or to a black screen without cursor. I need force the computer to restart.
Comment 7 Patrick Silva 2018-06-14 15:19:27 UTC
*** Bug 395154 has been marked as a duplicate of this bug. ***
Comment 8 Christoph Feck 2018-06-17 04:07:44 UTC
*** Bug 395511 has been marked as a duplicate of this bug. ***
Comment 9 Christoph Feck 2018-06-27 14:19:26 UTC
*** Bug 395775 has been marked as a duplicate of this bug. ***
Comment 10 Patrick Silva 2018-07-12 18:02:22 UTC
*** Bug 396077 has been marked as a duplicate of this bug. ***
Comment 11 Neousr 2018-10-30 22:41:15 UTC
This continue to happen on 5.14.2.

The only extra information i can give is that the "Window decoration" menu is the possible culprit.
If trying to navigate to the other existing menus (Widget/GTK) while maximized or exceeding certain size on the window the message will pop up.

Resize the window to the minimum size from the border and the message will not appear while moving from menus. Since once inside window decoration the default tab "Theme" seems to trigger the message.

Once the minimum size of the theme tab is exceeded it will trigger, this can be seen and replicated by navigating from menus on different windows sizes. Is pretty evident that once the second theme in this case Plastik moves to the right from the bottom when the window is resized. At least that why i can gather hope this information is helpful.
Comment 12 Valerio Pilo 2019-01-03 18:07:44 UTC
Fixed by commit ef1692eea6912c7a70773901bcfd91fb70d0b8cf in kwin:

[kcmkwin/kwindecoration] Set current decoration index on start

Summary:
Fixes the preselected decoration style on module load.

Also:
* Prevent the module state to be set to modified on resize.
* Fix QML errors in logs.

Reviewers: davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D17775