Bug 396337 - In tag filter view (or any other filitered view), grouped photos should not always have "group" thumbnail
Summary: In tag filter view (or any other filitered view), grouped photos should not a...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 6.0.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-09 13:12 UTC by Jens
Modified: 2019-11-10 20:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2018-07-09 13:12:25 UTC
To reproduce:
1. Group some images
2. Tag one of these grouped images with Tag "Foo"
3. Switch to tag filter view (right sidebar) and check to filter by "Foo" tag

Result: Image thumbnail has "group" thumbnail border (the one I suggested), but if you expand it, the border vanishes. This is confusing, since I did not tag any other images of the group.
Expected: Image is the only one of the group being tagged, so it should not have a group thumbnail border.

This also happens in date filter view and might happen in other views too.
Please check grouped images that are in separate months, then switch to time line view and show "by month", for example.
Comment 1 Maik Qualmann 2018-07-09 16:50:15 UTC
Hmm, I do not see a problem here. The grouped frame only shows if the group is closed or open, then the frame disappears. The grouped frame can be completely deactivated in the settings. When it comes to the fact that the other images are also displayed, if you filter according to the tag of the group leader - no, you can "hide" them in the view behind a image, but they are independently. So you have to assign them the tag of the group leader. If we disable the grouping function completely in filters, the other user will probably not like it.

Maik
Comment 2 caulier.gilles 2018-07-10 06:10:35 UTC
I agree with Maik here too from comment #1. The current behavior work fine here.

Gilles Caulier
Comment 3 Jens 2018-09-02 22:21:59 UTC
Hm. I have some images here where I only tag the group leader, but in filtered view, all images are visible (= can be expanded).

I think in a filtered view (by tag, or whatever), images should only appear if they match the filter - not if they are in a group whose leader matches the filter.

This is what is happening on my Digikam setup and I still think this is a bug...
Comment 4 Maik Qualmann 2019-11-02 22:27:21 UTC
Git commit 13207d2091f579cfb93ede0ad65ac1557617c2db by Maik Qualmann.
Committed on 02/11/2019 at 22:25.
Pushed by mqualmann into branch 'master'.

ignore in a filtered view the grouped function
Related: bug 382311, bug 413704
FIXED-IN: 7.0.0

M  +4    -1    NEWS
M  +10   -6    core/libs/database/models/itemfiltermodel.cpp

https://invent.kde.org/kde/digikam/commit/13207d2091f579cfb93ede0ad65ac1557617c2db
Comment 5 Maik Qualmann 2019-11-10 20:40:51 UTC
Git commit cfcbed2adb646e21066c8615199586ab3cb49169 by Maik Qualmann.
Committed on 10/11/2019 at 20:38.
Pushed by mqualmann into branch 'master'.

add option in the view menu to show all groups as open
Related: bug 303239, bug 321339, bug 382311, bug 413704
FIXED-IN: 7.0.0

M  +3    -1    NEWS
M  +11   -4    core/app/items/views/digikamitemview.cpp
M  +1    -0    core/app/items/views/digikamitemview.h
M  +5    -0    core/app/main/digikamapp.cpp
M  +2    -0    core/app/main/digikamapp.h
M  +2    -0    core/app/main/digikamapp_p.h
M  +8    -1    core/app/main/digikamapp_setup.cpp
M  +3    -1    core/app/main/digikamui5.rc
M  +10   -0    core/app/views/stack/itemiconview.cpp
M  +1    -0    core/app/views/stack/itemiconview.h
M  +4    -3    core/app/views/tableview/tableview_model.cpp
M  +10   -13   core/libs/database/models/itemfiltermodel.cpp
M  +2    -0    core/libs/settings/applicationsettings.cpp
M  +3    -0    core/libs/settings/applicationsettings.h
M  +10   -0    core/libs/settings/applicationsettings_albums.cpp
M  +3    -0    core/libs/settings/applicationsettings_p.cpp
M  +2    -0    core/libs/settings/applicationsettings_p.h

https://invent.kde.org/kde/digikam/commit/cfcbed2adb646e21066c8615199586ab3cb49169