Bug 382311 - Photos in collapsed groups are incorrectly excluded if first photo in group does not match filter.
Summary: Photos in collapsed groups are incorrectly excluded if first photo in group d...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 5.6.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-13 18:27 UTC by Trevor Giddings
Modified: 2019-11-10 20:40 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Trevor Giddings 2017-07-13 18:27:10 UTC
When a filter is set in the "filters" tab on the right sidebar, and the first photo in a collapsed group does not match the filter, all photos in the group are excluded from album view.

Expected behaviour: The group appears in album view if any of its photos match the filter, and when expanded, only photos matching the filter are shown.

The expected behaviour described above is identical to the actual behaviour of DigiKam when the first photo matches the filter.

Steps to reproduce:
    place two pictures in an album
    mark one picture with the "rejected" label
    group the pictures selecting the "rejected" picture last
    in the filters tab, click the black flag

expected behaviour: the album view shows one group with the photo that was not marked rejected as the thumbnail. Expanding the group does not show any more photos.

actual behaviour: the album view is empty.

This occurs in the thumbnails view if the group is collapsed (I.e, the "show grouped images" button was not clicked) and in the table view if the "ignore grouping" option is not checked.
Comment 1 caulier.gilles 2019-03-20 15:16:12 UTC
After 3 weeks of work, i finally completed the compilation of AppImage using Qt
5.11.3 + QWebkit 5.212.

New 6.1.0 pre-release AppImage bundle can be found here (64 bits only for the
moment) :

https://files.kde.org/digikam/

Please check if this bugzilla entry still valid.

Thanks in advance

Gilles Caulier
Comment 2 Trevor Giddings 2019-03-29 19:34:47 UTC
The bug is resolved in the 6.1.0 pre-release. However, groups with no matching photos now remain in the album view. While I would not classify that as a bug, it is a user-experience regression.

(In reply to caulier.gilles from comment #1)
> After 3 weeks of work, i finally completed the compilation of AppImage using
> Qt
> 5.11.3 + QWebkit 5.212.
> 
> New 6.1.0 pre-release AppImage bundle can be found here (64 bits only for the
> moment) :
> 
> https://files.kde.org/digikam/
> 
> Please check if this bugzilla entry still valid.
> 
> Thanks in advance
> 
> Gilles Caulier
Comment 3 caulier.gilles 2019-03-30 14:59:48 UTC
Trevor,

Thanks for the feddback.

Please open a new file about the "groups with no matching photos now remain in the album view" problem.

I close this file now.

Gilles Caulier
Comment 4 Maik Qualmann 2019-11-02 20:21:51 UTC
*** Bug 413704 has been marked as a duplicate of this bug. ***
Comment 5 Maik Qualmann 2019-11-02 20:23:27 UTC

*** This bug has been marked as a duplicate of bug 413704 ***
Comment 6 Maik Qualmann 2019-11-02 22:27:21 UTC
Git commit 13207d2091f579cfb93ede0ad65ac1557617c2db by Maik Qualmann.
Committed on 02/11/2019 at 22:25.
Pushed by mqualmann into branch 'master'.

ignore in a filtered view the grouped function
Related: bug 396337, bug 413704
FIXED-IN: 7.0.0

M  +4    -1    NEWS
M  +10   -6    core/libs/database/models/itemfiltermodel.cpp

https://invent.kde.org/kde/digikam/commit/13207d2091f579cfb93ede0ad65ac1557617c2db
Comment 7 Maik Qualmann 2019-11-10 20:40:50 UTC
Git commit cfcbed2adb646e21066c8615199586ab3cb49169 by Maik Qualmann.
Committed on 10/11/2019 at 20:38.
Pushed by mqualmann into branch 'master'.

add option in the view menu to show all groups as open
Related: bug 303239, bug 321339, bug 396337, bug 413704
FIXED-IN: 7.0.0

M  +3    -1    NEWS
M  +11   -4    core/app/items/views/digikamitemview.cpp
M  +1    -0    core/app/items/views/digikamitemview.h
M  +5    -0    core/app/main/digikamapp.cpp
M  +2    -0    core/app/main/digikamapp.h
M  +2    -0    core/app/main/digikamapp_p.h
M  +8    -1    core/app/main/digikamapp_setup.cpp
M  +3    -1    core/app/main/digikamui5.rc
M  +10   -0    core/app/views/stack/itemiconview.cpp
M  +1    -0    core/app/views/stack/itemiconview.h
M  +4    -3    core/app/views/tableview/tableview_model.cpp
M  +10   -13   core/libs/database/models/itemfiltermodel.cpp
M  +2    -0    core/libs/settings/applicationsettings.cpp
M  +3    -0    core/libs/settings/applicationsettings.h
M  +10   -0    core/libs/settings/applicationsettings_albums.cpp
M  +3    -0    core/libs/settings/applicationsettings_p.cpp
M  +2    -0    core/libs/settings/applicationsettings_p.h

https://invent.kde.org/kde/digikam/commit/cfcbed2adb646e21066c8615199586ab3cb49169