Bug 395735 - Add ability to change song ratings
Summary: Add ability to change song ratings
Status: RESOLVED DUPLICATE of bug 406472
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 0.1.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-22 10:10 UTC by Michael D
Modified: 2020-11-11 18:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael D 2018-06-22 10:10:24 UTC
Ratings are displayed in the playlist and there is an option to filter ratings, yet there is no way to change ratings. It would be nice to have this option.

Perhaps this is better marked as a wish than a bug, and the component set to baloo instead of general.

May I ask whether the ratings are retrieved from a file's xattrs, namely user.baloo.rating, or is it taken from the file's id3 tag? (I would personally prefer the latter.)
Comment 1 Matthieu Gallien 2018-06-22 10:35:02 UTC
Currently, Elisa does not know how to modify the track files.
The rating is read through KF5:: KFileMetaData. Its support has been extended to be able to read ratings specific to audio files.
We will work on this but I cannot make any promises for a date. Would you like to help us ?
Comment 2 Michael D 2018-06-25 07:55:57 UTC
Thanks for the info, and glad to hear you'll be working on this. I myself have virtually no programming skills, so I wouldn't be of any help--sorry!
Comment 3 Alexander Stippich 2018-11-17 09:10:42 UTC
Git commit 813203051377c6b7c9bdda1212312c64da076133 by Alexander Stippich.
Committed on 17/11/2018 at 09:10.
Pushed by astippich into branch 'master'.

use rating and comment stored in metadata tags

Summary:
if no xattr rating and comment are found, use the
data stored in the metadata. First step for T5375

Test Plan:
Create an audio file with rating written into the metadata.
The rating shows up in Elisa.
If xattr rating is set through dolphin, this rating is shown instead.
Same for comment

Reviewers: mgallien

Reviewed By: mgallien

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D16362

M  +25   -6    src/filescanner.cpp

https://commits.kde.org/elisa/813203051377c6b7c9bdda1212312c64da076133
Comment 4 Nate Graham 2020-11-11 18:42:14 UTC
This is being worked on!

*** This bug has been marked as a duplicate of bug 406472 ***