Bug 394013 - Application menu doesn't update
Summary: Application menu doesn't update
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.12.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
: 394231 394238 394648 394719 395011 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-08 17:43 UTC by pmargeti34
Modified: 2018-06-04 08:33 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Power/Session menu glitch (1.68 MB, image/png)
2018-05-08 17:43 UTC, pmargeti34
Details
Graphics menu glitch (1.68 MB, image/png)
2018-05-08 17:44 UTC, pmargeti34
Details
Bug Behaviour (984.25 KB, image/gif)
2018-05-08 18:46 UTC, aenima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pmargeti34 2018-05-08 17:43:12 UTC
Created attachment 112513 [details]
Power/Session menu glitch

Top 2 and bottom 2 submenus of Application menu don't update on mouse-over.
In my example I see items from utilities listed in Power/Session and items from Internet listed in Graphics. It works the other way around, e.g. had I first hovered Graphics, I would see those menu items under Internet.

Menu entries in the middle of the Application menu aren't affected.

I first noticed this with 5.12.5 update, I believe it was working fine in 5.12.4 Plasma.

OS: Arch Linux
Plasma: 5.12.5
Qt: 5.10.8
Comment 1 pmargeti34 2018-05-08 17:44:13 UTC
Created attachment 112514 [details]
Graphics menu glitch
Comment 2 aenima 2018-05-08 18:43:52 UTC
I can confirm this behaviour on Manjaro Linux. It occurs when the "next" category you hover have the exact same number of item of the previous one. It also affect the "Application Dashboard" widget.
Comment 3 aenima 2018-05-08 18:46:06 UTC
Created attachment 112515 [details]
Bug Behaviour
Comment 4 pmargeti34 2018-05-09 06:48:47 UTC
(In reply to aenima from comment #2)
> category you hover have the exact same number of item of the previous one.

Good observation, I can confirm my troublesome submenus share the same number of items.
Comment 5 Eike Hein 2018-05-09 07:12:44 UTC
Confirmed. Thanks for a good bug report, we'll try to fix it very soon.
Comment 6 Eike Hein 2018-05-09 07:16:48 UTC
This is a recent regression caused by 38403268aad3, authored by David Faure.

I'm looking into a fix for it.
Comment 7 Eike Hein 2018-05-09 07:28:03 UTC
Patch under review: https://phabricator.kde.org/D12774
Comment 8 pmargeti34 2018-05-09 09:59:17 UTC
(In reply to Eike Hein from comment #7)
> Patch under review: https://phabricator.kde.org/D12774

I have tried your patch and it fixes the issue. Thank you!
Comment 9 aenima 2018-05-09 13:07:26 UTC
(In reply to pmargeti34 from comment #8)
> (In reply to Eike Hein from comment #7)
> > Patch under review: https://phabricator.kde.org/D12774
> 
> I have tried your patch and it fixes the issue. Thank you!

Sorry for the noob question, do I have to compile the entire plasma-desktop from source in order to try this fix?
Comment 10 Eike Hein 2018-05-09 13:10:53 UTC
You can also just run `make` and `make install` in the applets/kicker subdir after you have created a build dir.

I don't think it's worth it though. This bug is pretty clear-cut and this fix will go into 5.12.x release as soon as it's cleared review.
Comment 11 aenima 2018-05-09 13:44:21 UTC
Ok, thank you very much! :)
Comment 12 Eike Hein 2018-05-11 08:51:22 UTC
Git commit c0cd1f8d49e6d63f1988d4749c366a0bef177790 by Eike Hein.
Committed on 11/05/2018 at 08:51.
Pushed by hein into branch 'Plasma/5.12'.

Fix submenus not updating when switching between categories of the same size

Summary:
This fixes a regression introduced in 38403268aad3, which forgot to
handle the branch where the counts are the same.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12774

M  +2    -0    applets/kicker/plugin/funnelmodel.cpp

https://commits.kde.org/plasma-desktop/c0cd1f8d49e6d63f1988d4749c366a0bef177790
Comment 13 Eike Hein 2018-05-14 07:21:00 UTC
*** Bug 394231 has been marked as a duplicate of this bug. ***
Comment 14 Eike Hein 2018-05-14 08:46:21 UTC
*** Bug 394238 has been marked as a duplicate of this bug. ***
Comment 15 Eike Hein 2018-05-24 11:30:09 UTC
*** Bug 394648 has been marked as a duplicate of this bug. ***
Comment 16 Eike Hein 2018-05-27 10:48:45 UTC
*** Bug 394719 has been marked as a duplicate of this bug. ***
Comment 17 Christoph Feck 2018-06-04 00:29:04 UTC
*** Bug 395011 has been marked as a duplicate of this bug. ***
Comment 18 Christoph Feck 2018-06-04 02:33:29 UTC
*** Bug 395011 has been marked as a duplicate of this bug. ***