Bug 393547 - New Libinput mouse KCM removed single-click/double-click setting
Summary: New Libinput mouse KCM removed single-click/double-click setting
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_mouse (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI major
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
Keywords: regression
Depends on:
Reported: 2018-04-26 16:08 UTC by Nate Graham
Modified: 2018-05-17 19:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-04-26 16:08:25 UTC
We need to re-add this setting either to the Mouse KCM, or to a more appropriate place (see Bug 377310). But it needs to be *somewhere*; I consider this a blocker for the 5.13 release.
Comment 1 Roman Gilg 2018-04-26 17:26:45 UTC
It makes more sense to put it in:
"Desktop Behavior -> Workspace"

My long term goal is to gather there other general config options too, for example animation speed from the Compositor KCM.
Comment 2 Nate Graham 2018-04-26 17:39:21 UTC
Sounds good to me, but FWIW I proposed that in Bug 377310 a year ago, and you shot it down! :P

Maybe we should rename that KCM to be "General", then.
Comment 3 Roman Gilg 2018-04-26 20:08:45 UTC
Not sure why I said this back then. Probably because the plan was to get rid of this KCM with the only two checkboxes.

But I now think it's better to keep it and make it more relevant by moving settings from other KCMs to this one (as for example animation speed from compositor KCM).
Comment 4 Furkan Tokac 2018-04-28 02:38:27 UTC
I made the investigation and working on it.

1- Porting "Dekstop Behavior -> Workspace" KCM to QML (KDeclarative::ConfigModule)
2- kdeglobals.[KDE].SingleClick configuration should be controlled by two radio buttons from "Desktop Behavior -> Workspace".
3- All the things about "SingleClick" in "plasma-desktop -> kcms -> input" needs to be removed. No need them anymore.

This patch will solve Bug 377310 too.
Comment 5 Nate Graham 2018-04-28 04:53:52 UTC
Thanks for grabbing this, Furkan! Keep in mind that this needs to ship with Plasma 5.13; we can't ship without a GUI method to change the click settings. The 5.13 branch is created in a little over two weeks, on 2018-05-17, and it would be nice to get it in before then if possible. If not, the latest it can go in is 2018-06-07, which is a little over 5 weeks from now.

See https://community.kde.org/Schedules/Plasma_5
Comment 6 Christoph Feck 2018-05-16 22:28:40 UTC
What is the status of this issue?
Comment 7 Nate Graham 2018-05-16 22:47:19 UTC
A patch is in progress and should be submitted shortly.
Comment 8 Furkan Tokac 2018-05-17 19:32:52 UTC
Git commit d3ef895516fed319956e4ba843206dd118b998f5 by Furkan Tokac.
Committed on 17/05/2018 at 19:31.
Pushed by furkantokac into branch 'master'.

Single/Double Click Option at Workspace KCM

This patch adds the single/double click option to
the Workspace KCM.
Related: bug 377310

Reviewers: romangg, ngraham, #plasma, mart

Reviewed By: romangg, #plasma, mart

Subscribers: mart, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12946

M  +3    -0    kcms/workspaceoptions/CMakeLists.txt
M  +33   -1    kcms/workspaceoptions/package/contents/ui/main.qml
M  +54   -3    kcms/workspaceoptions/workspaceoptions.cpp
M  +8    -0    kcms/workspaceoptions/workspaceoptions.h